Re: [OE-core] [PATCH 1/4] devtool: account for sources in UNPACKDIR

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2025-04-24 at 13:10 +0200, Alexander Kanavin via lists.openembedded.org wrote:
> From: Alexander Kanavin <alex@linutronix.de>
> 
> There's a couple of assumptions in devtool that sources
> are always in a directory under WORKDIR; this is no longer
> the case since introduction of UNPACKDIR: some recipes
> are starting to use
> 
> S = "${UNPACKDIR}/git"
> 
> or similar, and so the logic to determine source locations
> needs to be tweaked accordingly.
> 
> The issue is that oe-core has no concept of 'top level source
> path' (S points to where the build is started from, inside that
> top level location), and yet devtool needs to know that in order
> to move the complete source tree correctly to a workspace (and possibly
> other uses).
> 
> And so devtool performs convoluted path calculations from WORKDIR and S;
> now this has been extended to include UNPACKDIR and became more convoluted
> but hopefully it won't get any worse.
> 
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> ---
>  meta/classes/devtool-source.bbclass |  8 ++++++--
>  scripts/lib/devtool/ide_sdk.py      |  2 +-
>  scripts/lib/devtool/standard.py     | 25 +++++++++++++++++++------
>  scripts/lib/devtool/upgrade.py      |  2 +-
>  4 files changed, 27 insertions(+), 10 deletions(-)

UNPACKDIR was meant to help with this. If devtool is changing the
location, can't it just change UNPACKDIR and leave everything else
alone? S will still be under UNPACKDIR/git even after devtool moves it?

Cheers,

Richard