From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Vince Weaver <vincent.weaver@maine.edu>, Wang Nan <wangnan0@huawei.com>
Cc: mtk.manpages@gmail.com, pi3orama@163.com,
linux-kernel@vger.kernel.org, linux-man@vger.kernel.org,
lizefan@huawei.com
Subject: Re: [PATCH 1/2] perf_event_open.2: Document PERF_EVENT_IOC_PAUSE_OUTPUT
Date: Sat, 22 Oct 2016 12:00:14 +0200 [thread overview]
Message-ID: <cf11df62-04f6-57fc-12ee-975f91ef0bd6@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1610211710440.16183@macbook-air>
On 10/21/2016 11:16 PM, Vince Weaver wrote:
> On Fri, 21 Oct 2016, Wang Nan wrote:
>
>
>> -.SS Using prctl(2)
>> +.SS Using prctl
>
> why this change?
I suspect a diff against a slight stale version of the page,
since I added the '(2)' just a few days ago. Wang Nan, please
do pull the latest version of the page :-).
>> +.BR PERF_EVENT_IOC_PAUSE_OUTPUT " (since Linux 4.7)"
>> +.\" commit 86e7972f690c1017fd086cdfe53d8524e68c661c
>> +This allows pausing and resuming the event's ring-buffer. A
>> +paused ring-buffer does not prevent samples generation, but simply
>> +discards them. The discarded samples are considered lost, causes
>> +.BR PERF_RECORD_LOST
>> +to be generated when possible.
>
> I don't know if it's worth mentioning that the reason to add this is to
> allow reading the ring-buffer without having to worry about data being
> overwritten.
Wang Nan, what do you you thing. Should this be added?
> There are a few odd wording choices (mostly plural nouns) but otherwise
> looks fine to me.
>
> Reviewed-by: Vince Weaver <vincent.weaver@maine.edu>
Wang Nan, I'll send a few wording corrections. Could you please include
Vince's reviewed by tag on your next revision?
Thanks,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2016-10-22 10:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 11:38 [PATCH 1/2] perf_event_open.2: Document PERF_EVENT_IOC_PAUSE_OUTPUT Wang Nan
2016-10-21 11:38 ` Wang Nan
[not found] ` <1477049893-143199-1-git-send-email-wangnan0-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-10-21 11:38 ` [PATCH 2/2] perf_event_open.2: Document write_backward Wang Nan
2016-10-21 11:38 ` Wang Nan
2016-10-21 21:25 ` Vince Weaver
2016-10-22 10:05 ` Michael Kerrisk (man-pages)
2016-10-24 6:44 ` Wangnan (F)
2016-10-24 6:44 ` Wangnan (F)
2016-10-21 21:16 ` [PATCH 1/2] perf_event_open.2: Document PERF_EVENT_IOC_PAUSE_OUTPUT Vince Weaver
2016-10-21 21:16 ` Vince Weaver
2016-10-22 10:00 ` Michael Kerrisk (man-pages) [this message]
2016-10-22 10:02 ` Michael Kerrisk (man-pages)
2016-10-22 10:02 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf11df62-04f6-57fc-12ee-975f91ef0bd6@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=pi3orama@163.com \
--cc=vincent.weaver@maine.edu \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.