From: Anand Gadiyar <gadiyar@ti.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: linux-omap@vger.kernel.org, linux-wireless@vger.kernel.org,
Tony Lindgren <tony@atomide.com>
Subject: RE: [PATCH] omap: zoom2: fix build break when CONFIG_WL12XX_PLATFORM_DATA=n
Date: Sat, 2 Oct 2010 04:32:04 +0530 [thread overview]
Message-ID: <cf2c8b9dc6762d53dcaf522d874cb37b@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=+dtqdZLb8rfu8NZRU5GceUL5+S3B=MeW1xF=M@mail.gmail.com>
Ohad Ben-Cohen wrote:
> On Fri, Oct 1, 2010 at 10:33 PM, Anand Gadiyar <gadiyar@ti.com> wrote:
> > Fix this build break when CONFIG_WL12XX_PLATFORM_DATA is not set.
>
> A similar fix was already submitted and is pending to be merged
> (http://permalink.gmane.org/gmane.linux.kernel.wireless.general/56595)
>
> > There are still many warnings about the function
wl12xx_set_platform_data
> > being unused. Haven't fixed those. Ohad, care to take a look?
>
> Sure. Which warnings do you refer to (I haven't seen any) ?
>
I picked up your patch and the warnings are gone. The key difference
was I missed marking the alternative function as an inline.
Without that, I was seeing warnings like these:
include/linux/wl12xx.h:42: warning: 'wl12xx_set_platform_data' defined but
not used
- Anand
next prev parent reply other threads:[~2010-10-01 23:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 20:33 [PATCH] omap: zoom2: fix build break when CONFIG_WL12XX_PLATFORM_DATA=n Anand Gadiyar
[not found] ` <1285965236-17907-1-git-send-email-gadiyar-l0cyMroinI0@public.gmane.org>
2010-10-01 21:21 ` Ohad Ben-Cohen
2010-10-01 21:21 ` Ohad Ben-Cohen
2010-10-01 23:02 ` Anand Gadiyar [this message]
2010-10-01 23:09 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf2c8b9dc6762d53dcaf522d874cb37b@mail.gmail.com \
--to=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.