All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tokunori Ikegami <ikegami.t@gmail.com>
To: Kanchan Joshi <joshi.k@samsung.com>, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: initialize identify ns data to NULL
Date: Tue, 26 Mar 2024 23:56:06 +0900	[thread overview]
Message-ID: <cf2d212a-49bb-43e6-8ab5-e46e18626a43@gmail.com> (raw)
In-Reply-To: <3efcf01d-e83a-e5ad-d335-7516b857eef0@samsung.com>

Thanks for your comments. Understood them so let me abandon the patch. 
By the way I thought also the nvme functions allocating memory handling 
is not unified for example the nvme_identify_ns_nvm(), etc. about this I 
will do consider more. (The nvm version function caller seems still have 
a similar issue.)

On 2024/03/26 23:02, Kanchan Joshi wrote:
> Not a compelling case of future convenience, IMHO.
>
> In the current scheme of things, the assignment to NULL in all the
> callers of nvme_identify_ns (there are few more than what this patch
> covered) is redundant.


  reply	other threads:[~2024-03-26 14:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240325154544epcas5p4acf7f376241637872a433314489586fa@epcas5p4.samsung.com>
2024-03-25 15:45 ` [PATCH] nvme: initialize identify ns data to NULL Tokunori Ikegami
2024-03-26  8:20   ` Sagi Grimberg
2024-03-26 13:35     ` Tokunori Ikegami
2024-03-26  8:50   ` Kanchan Joshi
2024-03-26 13:51     ` Tokunori Ikegami
     [not found]     ` <a92a1493-29ae-4f89-b17b-54d03ec0becc@gmail.com>
2024-03-26 14:02       ` Kanchan Joshi
2024-03-26 14:56         ` Tokunori Ikegami [this message]
2024-03-26 15:37   ` Keith Busch
2024-03-26 15:54     ` Tokunori Ikegami

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf2d212a-49bb-43e6-8ab5-e46e18626a43@gmail.com \
    --to=ikegami.t@gmail.com \
    --cc=joshi.k@samsung.com \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.