From: "Alex G." <mr.nuke.me@gmail.com>
To: Tyler Baicar <tbaicar@codeaurora.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>,
alex_gagniuc@dellteam.com, austin_bolen@dell.com,
shyam_iyer@dell.com, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Tony Luck <tony.luck@intel.com>,
Will Deacon <will.deacon@arm.com>,
James Morse <james.morse@arm.com>,
Shiju Jose <shiju.jose@huawei.com>,
"Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>,
Dongjiu Geng <gengdongjiu@huawei.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES
Date: Tue, 22 May 2018 10:18:02 -0500 [thread overview]
Message-ID: <cf2e0a02-fb99-efde-0b41-63585c9d8844@gmail.com> (raw)
In-Reply-To: <50e318d3-b581-ad8b-d0e3-3e6c7b0da080@codeaurora.org>
On 05/22/2018 10:15 AM, Tyler Baicar wrote:
> On 5/22/2018 10:32 AM, Alex G. wrote:
>> I think the biggest problem is having a policy to panic on "fatal"
>> errors, instead of letting the error handler make that decision. I'd
>> much rather kill that stupid policy, but people seem to like it for some
>> reason.
>>
> You can get around that panic and still have the error handled as
> AER_FATAL in
> the current code. Your FW needs to mark the error as RECOVERABLE and then
> set the CPER_SEC_RESET flag.
Of course, that would be ideal. But experience shows that firmware
doesn't do this. That's the whole point: firmware sends questionable data.
Alex
> https://elixir.bootlin.com/linux/v4.17-rc6/source/drivers/acpi/apei/ghes.c#L450
>
>
> Thanks,
> Tyler
>
prev parent reply other threads:[~2018-05-22 15:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 13:49 [PATCH v6 0/2] acpi: apei: Improve PCIe error handling with FFS Alexandru Gagniuc
2018-05-21 13:49 ` [PATCH v6 1/2] acpi: apei: Rename ghes_severity() to ghes_cper_severity() Alexandru Gagniuc
2018-05-22 8:55 ` Rafael J. Wysocki
2018-05-22 13:38 ` Alex G.
2018-05-22 13:50 ` Borislav Petkov
2018-05-22 14:39 ` Alex G.
2018-05-22 14:54 ` Borislav Petkov
2018-05-22 15:22 ` Alex G.
2018-05-22 15:33 ` Borislav Petkov
2018-05-22 17:57 ` Luck, Tony
2018-05-22 18:10 ` Rafael J. Wysocki
2018-05-22 18:19 ` Alex G.
2018-05-22 18:45 ` Luck, Tony
2018-05-22 18:49 ` Alex G.
2018-05-22 18:33 ` Luck, Tony
2018-05-22 18:13 ` Alex G.
2018-05-22 18:13 ` Rafael J. Wysocki
2018-05-22 18:20 ` Alex G.
2018-05-22 21:20 ` Rafael J. Wysocki
2018-05-21 13:49 ` [PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES Alexandru Gagniuc
2018-05-21 14:27 ` Tyler Baicar
2018-05-21 17:40 ` Alex G.
2018-05-22 9:02 ` Rafael J. Wysocki
2018-05-22 14:32 ` Alex G.
2018-05-22 15:15 ` Tyler Baicar
2018-05-22 15:18 ` Alex G. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf2e0a02-fb99-efde-0b41-63585c9d8844@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=bp@alien8.de \
--cc=gengdongjiu@huawei.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shiju.jose@huawei.com \
--cc=shyam_iyer@dell.com \
--cc=tbaicar@codeaurora.org \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
--cc=zjzhang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.