From: Martin KaFai Lau <martin.lau@linux.dev>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: brouer@redhat.com, Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
bpf@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Gal Pressman <gal@nvidia.com>,
Nimrod Oren <noren@nvidia.com>, Tariq Toukan <tariqt@nvidia.com>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
drosen@google.com, Joanne Koong <joannelkoong@gmail.com>,
henning.fehrmann@aei.mpg.de, oliver.behnke@aei.mpg.de,
Jesper Dangaard Brouer <jbrouer@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH bpf-next 1/2] samples/bpf: fixup xdp_redirect tool to be able to support xdp multibuffer
Date: Tue, 30 May 2023 10:22:11 -0700 [thread overview]
Message-ID: <cf3903b0-9258-d000-c8b4-1f196ea726c5@linux.dev> (raw)
In-Reply-To: <dc19366d-8516-9f2a-b6ed-d9323e9250c9@gmail.com>
On 5/30/23 6:40 AM, Tariq Toukan wrote:
>>> I initiated a discussion on this topic a few months ago. dynptr was accepted
>>> since then, but I'm not aware of any in-progress followup work that addresses
>>> this.
>>>
>>
>> Are you saying some more work is needed on dynptr?
>>
>
> AFAIU yes.
> But I might be wrong... I need to revisit this.
> Do you think/know that dynptr can be used immediately?
Not sure if you are aware of the bpf_dynptr_slice[_rdwr]() which could be useful
here. It only does a copy when the requested slice is across different frags:
https://lore.kernel.org/all/20230301154953.641654-10-joannelkoong@gmail.com/
next prev parent reply other threads:[~2023-05-30 17:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 11:06 [PATCH bpf-next 0/2] multi-buffer support for XDP_REDIRECT samples Tariq Toukan
2023-05-29 11:06 ` [PATCH bpf-next 1/2] samples/bpf: fixup xdp_redirect tool to be able to support xdp multibuffer Tariq Toukan
2023-05-30 11:33 ` Jesper Dangaard Brouer
2023-05-30 12:17 ` Tariq Toukan
2023-05-30 12:40 ` Jesper Dangaard Brouer
2023-05-30 13:40 ` Tariq Toukan
2023-05-30 15:05 ` Toke Høiland-Jørgensen
2023-05-30 17:22 ` Martin KaFai Lau [this message]
2023-05-31 12:02 ` Tariq Toukan
2023-05-29 11:06 ` [PATCH bpf-next 2/2] samples/bpf: fixup xdp_redirect_map " Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf3903b0-9258-d000-c8b4-1f196ea726c5@linux.dev \
--to=martin.lau@linux.dev \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=drosen@google.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=hawk@kernel.org \
--cc=henning.fehrmann@aei.mpg.de \
--cc=jbrouer@redhat.com \
--cc=joannelkoong@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=oliver.behnke@aei.mpg.de \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.