From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: david@ixit.cz, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
phone-devel@vger.kernel.org
Subject: Re: [PATCH RFC 3/3] arm64: dts: qcom: sdm845-oneplus-fajita: Enable speaker codec
Date: Tue, 18 Aug 2026 12:50:44 +0200 [thread overview]
Message-ID: <cf3935fb-2aaa-4944-b879-9d7ef4927bf0@oss.qualcomm.com> (raw)
In-Reply-To: <20260802-tfa98xx-upstream-v1-3-4dd55cdd658a@ixit.cz>
On 8/2/26 2:42 PM, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> OnePlus 6 uses NXP TFA9894 audio codec. Enable it.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
[...]
> -/*
> - * The TFA9894 codec is currently unsupported.
> - * We need to delete the node to allow the soundcard
> - * to probe for headphones/earpiece.
> - */
> -/delete-node/ &speaker_playback_dai;
> +&speaker_playback_dai {
> + codec {
I'd rather you take a direct label to speaker_playback_dai_codec here
Konrad
prev parent reply other threads:[~2026-08-18 10:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-02 12:42 [PATCH RFC 0/3] Initial TFA2 family driver for tfa98xx David Heidelberg via B4 Relay
2026-08-02 12:42 ` David Heidelberg
2026-08-02 12:42 ` [PATCH RFC 1/3] dt-bindings: sound: Add NXP TFA98XX TFA2 amplifier binding David Heidelberg via B4 Relay
2026-08-02 12:42 ` David Heidelberg
2026-08-02 12:45 ` sashiko-bot
2026-08-03 21:39 ` Mark Brown
2026-08-02 12:42 ` [PATCH RFC 2/3] ASoC: codecs: tfa98xx: add driver for TFA2 amplifiers David Heidelberg via B4 Relay
2026-08-02 12:42 ` David Heidelberg
2026-08-02 12:48 ` sashiko-bot
2026-08-02 22:17 ` Uwe Kleine-König
2026-08-02 12:42 ` [PATCH RFC 3/3] arm64: dts: qcom: sdm845-oneplus-fajita: Enable speaker codec David Heidelberg via B4 Relay
2026-08-02 12:42 ` David Heidelberg
2026-08-02 12:55 ` sashiko-bot
2026-08-18 10:50 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf3935fb-2aaa-4944-b879-9d7ef4927bf0@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.