From: "Dwivedi, Avaneesh Kumar (avani)" <akdwived@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Sarangdhar Joshi <spjoshi@codeaurora.org>,
sboyd@codeaurora.org, agross@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [RFC 1/3] remoteproc: qcom: Introduce Qualcomm low pass sensor peripheral loader.
Date: Thu, 19 Jan 2017 10:30:42 +0530 [thread overview]
Message-ID: <cf3cd7b4-7422-a6c1-eff0-528f2cb039ac@codeaurora.org> (raw)
In-Reply-To: <20170118233450.GW10531@minitux>
On 1/19/2017 5:04 AM, Bjorn Andersson wrote:
> On Sun 15 Jan 21:15 PST 2017, Dwivedi, Avaneesh Kumar (avani) wrote:
>
>>
>> On 1/13/2017 2:11 AM, Sarangdhar Joshi wrote:
>>> Hi Avaneesh,
>>>
>>> On 01/12/2017 05:53 AM, Avaneesh Kumar Dwivedi wrote:
>>>> This patch is to load and boot slpi core on Qualcomm plateforms. It is
>>>> used for loading the firmware images of the subsystems into memory
>>>> and preparing the subsystem's processor to execute code.
>>> Can't we modify qcom_adsp_pil.c to use SLPI as well?
>> clocks, regulators, PAS_ID, firmware name, crash reason smem id these are
>> few driver specific resource/variable, if it is ok to initialize these
>> variables based on compatible string, i think we can have single driver for
>> adsp and slpi. let me know your further comment.
> I would prefer this too.
>
> The only thing that stands out is that you're not allowed to
> regulator_set_voltage(5), because that's not how we will do corners
> upstream - which tells us that we need to get corner voltages sorted
> out.
>
>
> I'm still undecided on aggre2_noc being handled in this driver or in a
> aggre2_noc bus surrounding the device, but that's a smaller issue than
> the corners.
>
> Regardless of these two issues we want a common adsp + slpi driver, so
> please submit a patch where you add the slpi support to the existing
> adsp driver.
OK, sure today i will try to submitt this.
but i need your comments on two things.
1- if we are going to have single driver, can we rename also this common
driver so that it doesnt sound like only loading and booting adsp.
2- this was(using regulator API to enable supply) what even i was
hesitant to submit slpi driver, so any comment on? how to go till time
we dont have alternative?
>
> Regards,
> Bjorn
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-01-19 5:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 13:53 [RFC 0/3] remoteproc: Introducing Qualcomm SLPI rproc driver Avaneesh Kumar Dwivedi
2017-01-12 13:53 ` [RFC 1/3] remoteproc: qcom: Introduce Qualcomm low pass sensor peripheral loader Avaneesh Kumar Dwivedi
2017-01-12 20:41 ` Sarangdhar Joshi
2017-01-16 5:15 ` Dwivedi, Avaneesh Kumar (avani)
2017-01-17 19:30 ` Sarangdhar Joshi
2017-01-18 23:34 ` Bjorn Andersson
2017-01-19 5:00 ` Dwivedi, Avaneesh Kumar (avani) [this message]
2017-01-12 13:53 ` [RFC 2/3] dt-binding: remoteproc: Introduce DT binding for Qualcomm slpi subsystem Avaneesh Kumar Dwivedi
2017-01-12 18:39 ` Bjorn Andersson
2017-01-16 6:01 ` Dwivedi, Avaneesh Kumar (avani)
2017-01-12 13:53 ` [RFC 3/3] arm64: dts: msm8996: Add SMP2P node for Qualcomm SLPI rproc driver Avaneesh Kumar Dwivedi
2017-01-12 18:24 ` Bjorn Andersson
2017-01-16 6:03 ` Dwivedi, Avaneesh Kumar (avani)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf3cd7b4-7422-a6c1-eff0-528f2cb039ac@codeaurora.org \
--to=akdwived@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=spjoshi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.