From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AC19C61DD6 for ; Wed, 2 Sep 2026 16:25:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x1nlh-0002d0-Km; Wed, 02 Sep 2026 12:24:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x1nlf-0002ck-Vl for qemu-riscv@nongnu.org; Wed, 02 Sep 2026 12:24:55 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x1nle-0005Yh-8r for qemu-riscv@nongnu.org; Wed, 02 Sep 2026 12:24:55 -0400 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 682FZFkh2670674 for ; Wed, 2 Sep 2026 16:24:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NT7fsWn7WkRi3MBOpJK/+nI5I/HXhNLNG7oqjX/+H+s=; b=Abb6y0MimzzBCyG0 EY28Bfk9yZ4npWX6dIootTEz0qepCroIGBtTF+Q+B+95C9BJgjeZJAHGHhC0ktL4 i58CuWs6RFmLFz0+dj2eBMTz20M0o8hsjgSeNw6GTuVLKDwz6FptEd8nfqPXPT5o 44H8OArCKWD7w54XoMs4Pyr1BahTepQC+q21ZZruLXSurLmjN41/cLvgBDAF0nmx 2UqT+xfiu2+cOPhevQqG4suJ7KrRSUnp92oIz/KFcQpFN/fm86DcvpLNUGAIQ/YA +EpX7dNZG1DYFK3nSz6TDASKA81I2iI1aO35rpQSDWp/xG0pwSPmvmzVn6yvpXGV /hiubQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gebsx2wdq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 02 Sep 2026 16:24:52 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e820609d9so262018585a.2 for ; Wed, 02 Sep 2026 09:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788366291; x=1788971091; darn=nongnu.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=NT7fsWn7WkRi3MBOpJK/+nI5I/HXhNLNG7oqjX/+H+s=; b=KIzx4Tb75palXcY6lNSgzkFsfbgFVKtkUNYdI2E3MkfHwuy49alePDx16SEl+LL7Lu YL8vWF15h0gUix1QRdgo7h34/+geYMRGuqeNtRG2Hh2qkUzIoMs5Lrmn5c6UPk+0X1T9 8QhU4RF3wmm9YI5XqQaHmHXhCSvOK7mUrDPjqfi0c9L0m6OHYXSzrywF6iGKrSxhIZDT fag/yUL2S/RVnwADhQ4KR00dc0MVJYF1P11pH9HMxgzNcr0Jvyt22OCm8T5Qc1XvDeKV ZRny7E+U7NL/nCCtOOJqXNsSRIG/F6wlITMR7M/dvcEhnJoWIuNuWzyAizAnmjM5dKr4 P0pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788366291; x=1788971091; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NT7fsWn7WkRi3MBOpJK/+nI5I/HXhNLNG7oqjX/+H+s=; b=Ho65qNw6E4olUWUaMekufaZW2IBxoKvXGcQ1B21j5XSGIOYRNhkTZKDnSskGV1z7Vm b2GMeM+TCsiTVDqExbdMA/7e72r4seQqMiJGHJnnBXAjc6n7bn1Mkta+rA62istAh2ah HEZ/156T5LwwtJ31eCOMk3Qrja7O1CEWRFHm58nphQL45JQrM7F0Lyl+vhJQ5xUB8FhJ 7mklS1r9Sg4j9RhUnlW+H+w6496nx+FWR0l4slD0UMSHRSkVFcOCh3QLXnQ7GEHzCm4J Ln9ojpbKyURNpgkB67WtxmVKAuse+lp/3OZiDA0c18CKrOCMZ30irFbBxB9wX6mcLGrT wp9Q== X-Gm-Message-State: AFuF++lfg1yswwpN1G5a/5yeV3fvRSw8FdjVRASYltcH+Hwjf1iu/o6x +F+Ma/Bcy8WK7zJYWud1EJFYRKD7q4jdwA4iEQcG36WJHTNC52rUoiKj3SnbQGntlOXgm8NtVaH y8dP7Tvvo64xNYJVXgJPHfuzf7K88c9qhJgrJ1R2Irgq852mOV7wWRMIfZg== X-Gm-Gg: AR+sD11bJajC+okM/nX8yO0OcfTJIwM9uvott+ru9yclbPeTf/SkS38qaEIMdyiY/Is mOf57GyQLShM9HgmNbvLM6IWA0Wj9yNfHb0qRsSJqLg9ssT9oFORGKTZYpyYUhgbTf+MVQPJmKs 2fR3pbneAKiqDfAZk2MZKgi8aUAjkJdZL7FR3KM+NKGXF5GOanW88zNBaXdVbcI8mxktfI4DTLY qAjGYWEeTQ/1TpXuhXGxjPt+auRdZhq2f/1yID46KrwU5B7UiXT5NBYiA+hhv9MSAsS2epZ5c6U S7FQ1ipjR2KaFwognplojdibr1My9WNlwsShfufOZ3ZvFxp7c9kwWM4tJl2Yu/dkXKbNIWrBF0Y TfpHgjxWDSwb3fEdQSGCIEqOUuH7jw3DOrg== X-Received: by 2002:a05:620a:bd4:b0:939:4a30:975b with SMTP id af79cd13be357-93960de7f8emr767811985a.14.1788366291304; Wed, 02 Sep 2026 09:24:51 -0700 (PDT) X-Received: by 2002:a05:620a:bd4:b0:939:4a30:975b with SMTP id af79cd13be357-93960de7f8emr767803785a.14.1788366290780; Wed, 02 Sep 2026 09:24:50 -0700 (PDT) Received: from [192.168.69.200] (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48448eeae34sm7797182f8f.32.2026.09.02.09.24.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Sep 2026 09:24:49 -0700 (PDT) Message-ID: Date: Wed, 2 Sep 2026 18:24:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 01/15] hw/riscv/fdt-common: prepend helpers with "riscv_" Content-Language: en-US To: Daniel Henrique Barboza , qemu-devel@nongnu.org, Yonggang Luo Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, chao.liu@processmission.com, Palmer Dabbelt , Joel Stanley , Nicholas Piggin , Anirudh Srinivasan , Michael Ellerman , Portia Stephens References: <20260828203918.350131-1-daniel.barboza@oss.qualcomm.com> <20260828203918.350131-2-daniel.barboza@oss.qualcomm.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20260828203918.350131-2-daniel.barboza@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: tuj7KYbaFF2oE8wtIUtICPuEQkX-ScRl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAyMDE0NCBTYWx0ZWRfX2q7TWDZlWPL1 5/pFmCChOjQXjJAxW/b8Oiy5lStK7TvKB27/8Uh5ANW/ELY4HCZAix8A3KAv6nCiZljUiKZhDXs NDm6Cl543MCrEDMrp2N/9H1lAT9T0d3dBTGXzPhc4l7cAwqYSNedGW2dlZcinnqwjecL2+V12ht XxVNAjxAqJQEQ1kQVh2w+DOfDoDINcQlFWZThclEAoSPAuwWvNJI1qy92yV65m/de5xj9GYZUSt o1mjepE350Wr7Bu+cQAL3+Za17Pki40TFETYumB82RKdau793p4b4NocPPUpc9lKHCBZ+bY02Yh LH1exbgS6z11jzOBOI8T0X+nhtzI3lZsPjOVYHbS/4Y7Zo5cSA74ebVxpFeIh0Wp1bNxSQjo4wj Z6KeJphFiGGp8mF1/XJalI0ORMPHFvLDMO41w4soykK0CaVq/FaKrGuMR6q4oQ7qIbO6RiPOe52 nsFe02Zov2mPcnGgPoQ== X-Proofpoint-GUID: tuj7KYbaFF2oE8wtIUtICPuEQkX-ScRl X-Authority-Analysis: v=2.4 cv=AufeGu9P c=1 sm=1 tr=0 ts=6a984dd4 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=FRSEYCzRAAAA:8 a=GtS8KpC4QQmZ-MVVqrkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=H4N_Y-AU75W7NKDNhZlT:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAyMDE0NCBTYWx0ZWRfX6393ytcvFgBq +HQg4oP7PeV8gKlWhFDVh2yZAgHKVTRCxmyXQBbDyP9RxW1PCkxCW6P6LcewKuMhvW2kdSaGibW mnc7lKbVVnZRS6uuAEUDHh813o0GqfE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-02_04,2026-09-01_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609020144 Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Hi Daniel, On 28/8/26 22:39, Daniel Henrique Barboza wrote: > Given that the helpers are public API we should prefix them with > "riscv_" to avoid conflicts when linking with different targets in the > future, i.e. we should not use generic names like > "create_fdt_socket_memory". > > Despite the amount of lines this is a mechanical change and no real > FDT changes are intended. > > Suggested-by: Philippe Mathieu-Daudé > Signed-off-by: Daniel Henrique Barboza > Reviewed-by: Chao Liu > Reviewed-by: Philippe Mathieu-Daudé > --- > hw/riscv/fdt-common.c | 45 ++++++++++++++++---------------- > hw/riscv/sifive_u.c | 34 +++++++++++++------------ > hw/riscv/spike.c | 30 ++++++++++++---------- > hw/riscv/tt_atlantis.c | 22 ++++++++-------- > hw/riscv/virt.c | 42 +++++++++++++++--------------- > include/hw/riscv/fdt-common.h | 48 ++++++++++++++++++----------------- > 6 files changed, 117 insertions(+), 104 deletions(-) I had the following patch tagged but it will conflict with your series which is apparently ready (and at v5): https://lore.kernel.org/qemu-devel/20260823150731.896-6-luoyonggang@gmail.com/ I'll let see with Yonggang what is the simpler (likely have his patch rebased once your series is merged). Regards, Phil.