From: "Hubert Wiśniewski" <hubert.wisniewski.25632@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: u_ether: Use __netif_rx() in rx_callback()
Date: Tue, 17 Sep 2024 12:29:20 +0200 [thread overview]
Message-ID: <cf50c26f89b38a4b0cba7fc2329a9040ac5f5b67.camel@gmail.com> (raw)
In-Reply-To: <2024091116-wound-golf-9f03@gregkh>
On Wed, 2024-09-11 at 15:28 +0200, Greg KH wrote:
> On Fri, Sep 06, 2024 at 08:57:25PM +0200, Hubert Wiśniewski wrote:
> > netif_rx() now disables bottom halves, which causes the USB gadget to be
> > unable to receive frames if the interface is not brought up quickly enough
> > after being created by the driver (a bug confirmed on AM3352 SoC).
> >
> > Replacing netif_rx() with __netif_rx() restores the old behavior and fixes
> > the bug. This can be done since rx_callback() is called from the interrupt
> > context.
> >
> > Signed-off-by: Hubert Wiśniewski <wiih@viessmann.com>
>
> Doesn't match the "From:" line, so we can't take this :(
Sorry, my mistake. I will fix that.
> What commit id does this fix?
This fixes baebdf48c360 ("net: dev: Makes sure netif_rx() can be invoked in
any context."). I will add an appropriate Fixes tag in v2.
Thank you for your feedback.
Hubert Wiśniewski
prev parent reply other threads:[~2024-09-17 10:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 18:57 [PATCH] usb: gadget: u_ether: Use __netif_rx() in rx_callback() Hubert Wiśniewski
2024-09-11 13:28 ` Greg KH
2024-09-17 10:29 ` Hubert Wiśniewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf50c26f89b38a4b0cba7fc2329a9040ac5f5b67.camel@gmail.com \
--to=hubert.wisniewski.25632@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.