Re: [kvm-unit-tests PATCH 11/16] x86/sev: Use VC_VECTOR from processor.h

From: "Mi, Dapeng" <dapeng1.mi@linux.intel.com>
To: "Sean Christopherson" <seanjc@google.com>,
	"Andrew Jones" <andrew.jones@linux.dev>,
	"Janosch Frank" <frankja@linux.ibm.com>,
	"Claudio Imbrenda" <imbrenda@linux.ibm.com>,
	"Nico Böhr" <nrb@linux.ibm.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Cc: kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 11/16] x86/sev: Use VC_VECTOR from processor.h
Date: Tue, 10 Jun 2025 15:25:42 +0800	[thread overview]
Message-ID: <cf52eac4-a366-41a1-9a4a-962efdb260ca@linux.intel.com> (raw)
In-Reply-To: <20250529221929.3807680-12-seanjc@google.com>


On 5/30/2025 6:19 AM, Sean Christopherson wrote:
> Use VC_VECTOR (defined in processor.h along with all other known vectors)
> and drop the one-off SEV_ES_VC_HANDLER_VECTOR macro.
>
> No functional change intended.
>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>  lib/x86/amd_sev.c | 4 ++--
>  lib/x86/amd_sev.h | 6 ------
>  2 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/lib/x86/amd_sev.c b/lib/x86/amd_sev.c
> index 66722141..6c0a66ac 100644
> --- a/lib/x86/amd_sev.c
> +++ b/lib/x86/amd_sev.c
> @@ -111,9 +111,9 @@ efi_status_t setup_amd_sev_es(void)
>  	 */
>  	sidt(&idtr);
>  	idt = (idt_entry_t *)idtr.base;
> -	vc_handler_idt = idt[SEV_ES_VC_HANDLER_VECTOR];
> +	vc_handler_idt = idt[VC_VECTOR];
>  	vc_handler_idt.selector = KERNEL_CS;
> -	boot_idt[SEV_ES_VC_HANDLER_VECTOR] = vc_handler_idt;
> +	boot_idt[VC_VECTOR] = vc_handler_idt;
>  
>  	return EFI_SUCCESS;
>  }
> diff --git a/lib/x86/amd_sev.h b/lib/x86/amd_sev.h
> index ed6e3385..ca7216d4 100644
> --- a/lib/x86/amd_sev.h
> +++ b/lib/x86/amd_sev.h
> @@ -39,12 +39,6 @@
>  bool amd_sev_enabled(void);
>  efi_status_t setup_amd_sev(void);
>  
> -/*
> - * AMD Programmer's Manual Volume 2
> - *   - Section "#VC Exception"
> - */
> -#define SEV_ES_VC_HANDLER_VECTOR 29
> -
>  /*
>   * AMD Programmer's Manual Volume 2
>   *   - Section "GHCB"

LGTM. 

Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>


-- 
kvm-riscv mailing list
kvm-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kvm-riscv