From: Richard Henderson <richard.henderson@linaro.org>
To: Stafford Horne <shorne@gmail.com>,
QEMU Development <qemu-devel@nongnu.org>
Cc: "Jason A . Donenfeld" <Jason@zx2c4.com>
Subject: Re: [PATCH] target/openrisc: Do not reset delay slot flag on early tb exit
Date: Wed, 11 May 2022 07:32:58 -0700 [thread overview]
Message-ID: <cf7c27e9-3bc9-888e-dbba-25c0bb583e09@linaro.org> (raw)
In-Reply-To: <20220511120541.2242797-1-shorne@gmail.com>
On 5/11/22 05:05, Stafford Horne wrote:
> +static void openrisc_cpu_synchronize_from_tb(CPUState *cs,
> + const TranslationBlock *tb)
> +{
> + OpenRISCCPU *cpu = OPENRISC_CPU(cs);
> +
> + cpu->env.pc = tb->pc;
> +}
If mips is a guide, you'd want to set dflag based on
tb->flags & TB_FLAGS_DFLAG
as well. But I think openrisc is more careful to keep dflag up-to-date.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-05-11 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 12:05 [PATCH] target/openrisc: Do not reset delay slot flag on early tb exit Stafford Horne
2022-05-11 14:32 ` Richard Henderson [this message]
2022-05-11 21:43 ` Stafford Horne
2022-05-11 21:56 ` Richard Henderson
2022-05-11 22:34 ` Stafford Horne
2022-05-12 2:11 ` Richard Henderson
2022-05-12 12:47 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf7c27e9-3bc9-888e-dbba-25c0bb583e09@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Jason@zx2c4.com \
--cc=qemu-devel@nongnu.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.