Re: [PATCH] iio: imu: bmi270: Match ACPI ID found on newer GPD firmware

[David Lechner <dlechner@baylibre.com>]

On 7/30/25 7:56 AM, Cryolitia PukNgae via B4 Relay wrote:
> From: Cryolitia PukNgae <liziyao@uniontech.com>
> 
> Some GPD devices ship a buggy firmware that describes on-device BMI260
> with ACPI ID "BMI0160". Since this is fixed in BIOS update v0.40,
> let's match the correct ID to detect the device. The buggy ID "BMI0160"
> is kept as well to maintain compatibility with older firmwares.
> 
> Signed-off-by: Cryolitia PukNgae <liziyao@uniontech.com>
> ---
> Some GPD devices ship a buggy firmware that describes on-device BMI260
> with ACPI ID "BMI0160". Since this is fixed in BIOS update v0.40[1],
> let's match the correct ID to detect the device. The buggy ID "BMI0160"
> is kept as well to maintain compatibility with older firmwares.
> 
> Link: http://download.softwincn.com/WIN%20Max%202024/Max2-7840-BIOS-V0.41.zip
> 
> [1]. See the update nodes in the archive file above
> ---
>  drivers/iio/imu/bmi270/bmi270_i2c.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/imu/bmi270/bmi270_i2c.c b/drivers/iio/imu/bmi270/bmi270_i2c.c
> index c77839b03a969f6f149c025a0305c4b9b8ac6571..b909a421ad0176ee414f2f96ff09db2297586ded 100644
> --- a/drivers/iio/imu/bmi270/bmi270_i2c.c
> +++ b/drivers/iio/imu/bmi270/bmi270_i2c.c
> @@ -41,6 +41,8 @@ static const struct i2c_device_id bmi270_i2c_id[] = {
>  static const struct acpi_device_id bmi270_acpi_match[] = {
>  	/* GPD Win Mini, Aya Neo AIR Pro, OXP Mini Pro, etc. */
>  	{ "BMI0160",  (kernel_ulong_t)&bmi260_chip_info },
> +	/* GPD Win Max 2 2023(sincice BIOS v0.40), etc. */

Is this supposed to say "since" instead of "sincice"?

> +	{ "BMI0260",  (kernel_ulong_t)&bmi260_chip_info },
>  	{ }
>  };
>  
> 
> ---
> base-commit: 0db240bc077fd16cc16bcecfd7f4645bc474aa7e
> change-id: 20250206-bmi270-gpd-acpi-de4d12bce567
> 
> Best regards,