From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010013.outbound.protection.outlook.com [52.101.193.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C020447ACCC for ; Thu, 20 Aug 2026 15:44:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.13 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787240654; cv=fail; b=fnwtsiBaQTJ+jysMUjWSzBK/Jn4EVBoiLoreGTFvTv8nQm33x3nB+v4IoKPccM8e/mjW89AMpcXk9wwcjKoUQyjW+WvuuFrsaPFqHRGIpTWmV3cl9YAnsPvOEElGX7aEdja503KaP4jJq25zwA+PH9R+Qj0zumubu5poIi5Qo0c= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787240654; c=relaxed/simple; bh=oNohIkuRB8dvfvP23anf+T6djLfj+5wkWw1mHU3k+y4=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=O9CjCrBNF1UX3y18/DELk9fc1UU/UZl0GVpaDke1Z4M1pEheEBc0n93R2oXxG7ytMWXTETyXiIlMySa/n89DssztYdAAHB/A8B5QKpkK3oXGNPWeTOljVrRDakmuHk1Y008tBXANLY8NDv56LvDg8c5NqMtMoEZa5jokLc/BD7Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=nioBHpP3; arc=fail smtp.client-ip=52.101.193.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="nioBHpP3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AHozm5sP1cJbgiJh+yxbmwy+gfodlUVaJd0n3XTcWnIIMZcuOvQPiH/CMOgXQoihV946w9V1arOBXxwqtgDO9gghJYoLujMpd/Ej8X66adTfvhf2YrdkePRgrpDeoVcICiStdyURsF6F4oVClubkMa0xgAHPuZ2BO3qQ4HjfReLpHJpkbiacoabOI3rSQA8QEbO5CZj+8IX2Q6OMTXd8oCYOvkhjL0/m9tDYOv0wbmr4B1mF2aQ67t71gNmh8/9A5LkB23V/5fGyWWhWvJcdnb9CuZevpYMAXOaFMqyhgtCH5KxdKulV7g0prkD3ghl8pXS+ryUHJVSDJa1RcGpdEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7aJCwIF6+t6OQr0TsA6taDOpIO09ZHl2CJ1balytg6c=; b=dQ3ZX62ZQo/9DD0N4tZLeRXn1abJpJmNGbC1fjqLiP8901eAjFB0Lb6JKhBw7pBSA0vLGt4410phKPwcsueYKDDakRrr/ISx3g2Yk/1BDYyJgwIkEw1k7xi8hBRO44xnzU26s9qiyC/1/pX20TCikbudlgb4yJPtm+uD0TwkIO3+aw6EojO6/6WFrtS5sHLs4FJ+AbwnGi7W5hdrLQog3cDGIgWaMvdx2QnuDJDmXGjidxTH5/z7R+v8r+gXciJj42pj6diS+0It8fXRVKCwSNPww1V/o/4GwRtmtisNYWCehCM1xXq4ANSQXn5ppZYHYR/87NH17Ib50Wzv6jltZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7aJCwIF6+t6OQr0TsA6taDOpIO09ZHl2CJ1balytg6c=; b=nioBHpP36xrau6NWdvxG7s/pUBOQLVTmk4yvFEFeNIlhc2aAbXgvsFjc6ObQEFSyACGASbSpjXm9rft+Vam4OUluWG/vM58yjhhaKupQp3PDSyeXmkYSbEOoRMWHxC4Xwk3a5LXTrNQ3lHYMcw2pEcuUEkSCRJPvzke24kqPGRc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SN7PR12MB8131.namprd12.prod.outlook.com (2603:10b6:806:32d::12) by MW6PR12MB8949.namprd12.prod.outlook.com (2603:10b6:303:248::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.10; Thu, 20 Aug 2026 15:43:59 +0000 Received: from SN7PR12MB8131.namprd12.prod.outlook.com ([fe80::c2dd:62c5:67fe:aa46]) by SN7PR12MB8131.namprd12.prod.outlook.com ([fe80::c2dd:62c5:67fe:aa46%4]) with mapi id 15.21.0339.007; Thu, 20 Aug 2026 15:43:59 +0000 Message-ID: Date: Thu, 20 Aug 2026 10:43:57 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/7] x86/apic: Add an SVSM APIC driver To: Melody Wang Cc: LKML , x86@kernel.org References: <7c4f962cb0c993f0cb136a9abcbd4f3e4759282c.1785375271.git.huibo.wang@amd.com> <0514ffca-89a3-42e9-bc30-50c317aa7bd9@amd.com> <1bd358fe-39f8-4a95-bf87-24a4a34d5b64@amd.com> Content-Language: en-US From: Tom Lendacky Autocrypt: addr=thomas.lendacky@amd.com; keydata= xsFNBFaNZYkBEADxg5OW/ajpUG7zgnUQPsMqWPjeAxtu4YH3lCUjWWcbUgc2qDGAijsLTFv1 kEbaJdblwYs28z3chM7QkfCGMSM29JWR1fSwPH18WyAA84YtxfPD8bfb1Exwo0CRw1RLRScn 6aJhsZJFLKyVeaPO1eequEsFQurRhLyAfgaH9iazmOVZZmxsGiNRJkQv4YnM2rZYi+4vWnxN 1ebHf4S1puN0xzQsULhG3rUyV2uIsqBFtlxZ8/r9MwOJ2mvyTXHzHdJBViOalZAUo7VFt3Fb aNkR5OR65eTL0ViQiRgFfPDBgkFCSlaxZvc7qSOcrhol160bK87qn0SbYLfplwiXZY/b/+ez 0zBtIt+uhZJ38HnOLWdda/8kuLX3qhGL5aNz1AeqcE5TW4D8v9ndYeAXFhQI7kbOhr0ruUpA udREH98EmVJsADuq0RBcIEkojnme4wVDoFt1EG93YOnqMuif76YGEl3iv9tYcESEeLNruDN6 LDbE8blkR3151tdg8IkgREJ+dK+q0p9UsGfdd+H7pni6Jjcxz8mjKCx6wAuzvArA0Ciq+Scg hfIgoiYQegZjh2vF2lCUzWWatXJoy7IzeAB5LDl/E9vz72cVD8CwQZoEx4PCsHslVpW6A/6U NRAz6ShU77jkoYoI4hoGC7qZcwy84mmJqRygFnb8dOjHI1KxqQARAQABzSZUb20gTGVuZGFj a3kgPHRob21hcy5sZW5kYWNreUBhbWQuY29tPsLBmQQTAQoAQwIbIwcLCQgHAwIBBhUIAgkK CwQWAgMBAh4BAheAAhkBFiEE3Vil58OMFCw3iBv13v+a5E8wTVMFAmkbaKgFCRZQah8ACgkQ 3v+a5E8wTVPFyg//UYANiuHfxxJET8D6p/vIV0xYcf1SXCG78M+5amqcE/4cCIJWyAT3A1nP zwyQIaIjUlGsXQtNgC1uVteCnMNJCjVQm0nLlJ9IVtXxzRg0QKjuSdZxuL5jrIon4xW9hTJR 94i2v3Fx5UWyP2TB6qZOcB0jgh0l01GHF9/DVJbmQlpvQB4Z1uNv09Q7En6EXi28TSv0Ffd1 p8vKqxwz7CMeAeZpn5i7s1QE/mQtdkyAmhuGD12tNbWzFamrDD1Kq3Em4TIFko0+k5+oQAAf JFaZc1c0D4GtXwvv4y+ssI0eZuOBXapUHeNNVf3JGuF6ZPLNPAe5gMQrmsJinEArVYRQCuDA BZakbKw9YJpGhnSVeCl2zSHcVgXuDs4J2ONxdsGynYv5cjPb4XTYPaE1CZH7Vy1tqma8eErG rcCyP1seloaC1UQcp8UDAyEaBjh3EqvTvgl+SppHz3im0gPJgR9km95BA8iGx9zqDuceATBc +A007+XxdFIsifMGlus0DKPmNAJaLkEEUMedBBxH3bwQ+z8tmWHisCZQJpUeGkwttD1LK/xn KRnu8AQpSJBB2oKAX1VtLRn8zLQdGmshxvsLUkKdrNE6NddhhfULqufNBqul0rrHGDdKdTLr cK5o2dsf9WlC4dHU2PiXP7RCjs1E5Ke0ycShDbDY5Zeep/yhNWLOwU0EVo1liQEQAL7ybY01 hvEg6pOh2G1Q+/ZWmyii8xhQ0sPjvEXWb5MWvIh7RxD9V5Zv144EtbIABtR0Tws7xDObe7bb r9nlSxZPur+JDsFmtywgkd778G0nDt3i7szqzcQPOcR03U7XPDTBJXDpNwVV+L8xvx5gsr2I bhiBQd9iX8kap5k3I6wfBSZm1ZgWGQb2mbiuqODPzfzNdKr/MCtxWEsWOAf/ClFcyr+c/Eh2 +gXgC5Keh2ZIb/xO+1CrTC3Sg9l9Hs5DG3CplCbVKWmaL1y7mdCiSt2b/dXE0K1nJR9ZyRGO lfwZw1aFPHT+Ay5p6rZGzadvu7ypBoTwp62R1o456js7CyIg81O61ojiDXLUGxZN/BEYNDC9 n9q1PyfMrD42LtvOP6ZRtBeSPEH5G/5pIt4FVit0Y4wTrpG7mjBM06kHd6V+pflB8GRxTq5M 7mzLFjILUl9/BJjzYBzesspbeoT/G7e5JqbiLWXFYOeg6XJ/iOCMLdd9RL46JXYJsBZnjZD8 Rn6KVO7pqs5J9K/nJDVyCdf8JnYD5Rq6OOmgP/zDnbSUSOZWrHQWQ8v3Ef665jpoXNq+Zyob pfbeihuWfBhprWUk0P/m+cnR2qeE4yXYl4qCcWAkRyGRu2zgIwXAOXCHTqy9TW10LGq1+04+ LmJHwpAABSLtr7Jgh4erWXi9mFoRABEBAAHCwXwEGAEKACYCGwwWIQTdWKXnw4wULDeIG/Xe /5rkTzBNUwUCaRto5wUJFlBqXgAKCRDe/5rkTzBNUw4/EAClG106SeHXiJ+ka6aeHysDNVgZ 8pUbB2f8dWI7kzD5AZ5kLENnsi1MzJRYBwtg/vVVorZh6tavUwcIvsao+TnV57gXAWr6sKIc xyipxRVEXmHts22I6vL1DirLAoOLAwWilkM+JzbVE3MMvC+cCVnMzzchrMYDTqn1mjCCwiIe u5oop+K/RgeHYPsraumyA9/kj8iazrLM+lORukCNM7+wlRClcY8TGX+VllANym9B6FMxsJ5z Q7JeeXIgyGlcBRME+m3g40HfIl+zM674gjv2Lk+KjS759KlX27mQfgnAPX4tnjLcmpSQJ77I Qg+Azi/Qloiw7L/WsmxEO5ureFgGIYDQQUeM1Qnk76K5Z3Nm8MLHtjw3Q7kXHrbYn7tfWh4B 7w5Lwh6NoF88AGpUrosARVvIAd93oo0B9p40Or4c5Jao1qqsmmCCD0dl7WTJCboYTa2OWd99 oxS7ujw2t1WMPD0cmriyeaFZnT5cjGbhkA+uQGuT0dMQJdLqW3HRwWxyiGU/jZUFjHGFmUrj qFAgP+x+ODm6/SYn0LE0VLbYuEGfyx5XcdNnSvww1NLUxSvuShcJMII0bSgP3+KJtFqrUx9z l+/NCGvn/wMy6NpYUpRSOmsqVv0N71LbtXnHRrJ42LzWiRW2I5IWsb1TfdMAyVToHPNaEb0i WiyqywZI5g== In-Reply-To: <1bd358fe-39f8-4a95-bf87-24a4a34d5b64@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: CH2PR17CA0016.namprd17.prod.outlook.com (2603:10b6:610:53::26) To SN7PR12MB8131.namprd12.prod.outlook.com (2603:10b6:806:32d::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN7PR12MB8131:EE_|MW6PR12MB8949:EE_ X-MS-Office365-Filtering-Correlation-Id: 66df0b65-b29d-4f36-513b-08defed1d9e5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|23010399003|366016|6133799003|3023799007|56012099006|10067099003|4143699003|5023799004|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: vQRUNKOzjcXebyULWwlKmKdAnbGBVBE14N+oLSpPo6aUVX9ueJbWZZhXMBYjmwwQLRAWysCOWQFzMk9+0lNTIntIuPPBYbdnICBxkXrZ/R4B2aRhSA+G04NG3L5/xsivfbEdf8jbp6Eic8vCiqYL73sDJ0kiGOsbfEdq2t8qDD4fvqj+g5zCzp0dd3mwMtXFsIHbGspTdode/0gmngm18/UMz+0KvZSAyUlno9vZcGeN9ziVYwF38ykYzXTDGpSPTGFQ2KO9Wokr0O2NiO76dAa6ql3C48xY6nKT7uwK4h2oQS5vZZFcS4kwEmyNazh6AjdWaWGy81KGsEyacYO4kBlGZkvTDUG23+78F3VHfH0wUBbYQxhF+qKhl/Zp615HODMglUaWNyJuojbVeOSDp8zjR+v1ucqgOY1fXR0IL1DmBWxbduUwuFT/BuI4umu98RXwyweZmGaHKv+KiKwLiojfUwTSjUU4tV4UhkyzvyJ9U70NZYy0jTRUWYcNVbbT/ofSnHqWD1P969mn/fp2F1kE1rBvt5lLVDasRNnFhLSmy4Sls+COWGMl77lyte3Y17tCVU2uc0/CXGHNE9LSbRzG7FSsxGLJy/Tmz2TNZnOopnNo3Dis+3x8kYwGcPYui5sPQ0HUKYHlbyZLBh21ZKhNtcm87NmAjYHu/Z9j2Dk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR12MB8131.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(23010399003)(366016)(6133799003)(3023799007)(56012099006)(10067099003)(4143699003)(5023799004)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXl2endlclhRT0YwbnlScGxTL0tIQnRMMFFOSEpORFVESFNiR1pmYWVjQmxm?= =?utf-8?B?YzNkZkJWQlZzdmExT0x0OHorQTFwc3R2MG5aNlA1VHZKYzNZMWo5MkkwRHZl?= =?utf-8?B?YVlCVnZWaFdDZ3dYaU5wVDh1TWdLMWh4bHZFZC9tN1JERVJaS0M4NHhubXhL?= =?utf-8?B?aHFQUTlPK2psWnVIdVpXck9xU0VLS1JweGRHRFZWdTBVcGpLd0NTT1VaM3NW?= =?utf-8?B?T3lZTnFMUlJoZWtpZlowcXFnV2lYb3F2Wnp3OVJYSExMWlBPeE9qZCt2V1Qx?= =?utf-8?B?Z1FjL2Z1Q2FTTzJUeDZLOThRall6dXQ1N0VNWjJGVkgzMFhKWEdJQk9WVWQy?= =?utf-8?B?M2tIOXVrbGVXaEkxUEVZSHhVMmxidU9yOHJ6dVRCRVJwYlo5QzFoR2JSQ0pU?= =?utf-8?B?RGd5TG5LVmIzVnIrOGZXNlFobGl0dnIybkYrWjBYRWFWdzBuMjJ0TmtQVHNi?= =?utf-8?B?K29BNTNSSzBjeEhHdjlpQzZhZW8wSHFBY08yRkVPSmRCYUFWK0xRU3JRNGJu?= =?utf-8?B?L05qQ1F5TklySS8rUzVzbUtpMnRsd1FOdmRjUU5CWFRKcEhvRi94K1VIVnBN?= =?utf-8?B?RFU4cXplQndadmo2WlhmV1ZCTjR5cHh6bzBIM09YTFZJcXJBZ3NKQ0hMT3pX?= =?utf-8?B?Y0VsV3RUODFMN25yUmkyeFV0WGEycFZqb2NKTHF1YkxIejVldFJOeEJueTlK?= =?utf-8?B?NWNrbzRDUHFpQXF2WlpoTHRCdksyUlJNNDJuMHMrTU5VYkxQVHZrUjBsTkxZ?= =?utf-8?B?c3loTFNvVTBlQTI5aUJPWkdCWXd3M3lOZDlEenpHeFFZZ2YxNXpybXd5U1dO?= =?utf-8?B?aTdDUmIzaTNNdlBWVWpMWnJ0dkFVQnlBUnhkczRRTXNpNkM1VG0ya1liVkE3?= =?utf-8?B?WFRsem5wclNHTDlFWUlzTnhrcW9acFEwdktZRm80TGZQZy9iRFB4TElIN2k3?= =?utf-8?B?QWtPNm1hQlJkQ1VUcGZUVHZyZit6YkFyRnBoMGowZXplWW1GVXR4TjA2dUFz?= =?utf-8?B?QkltTXNod0greHk5ODFWRENkcnlSaDhBdnpWVnhtdGpLcElISVdpOUgzYVV3?= =?utf-8?B?dEtlMEU4ZG5POHpGTkYraFI3K0gyQWtCSGgxaTlCZjF4eW9vYU42UjBWTkty?= =?utf-8?B?M00wcTZxUVYxemJYSnNGY1JZTkkzRmhORzNtYjBMUHIya1V0U1RaT0NSd1Rn?= =?utf-8?B?NnNKL0xnMTcvRmxQV0kxM245MEhpM1ZiazNodDhuWFUzcXoyUVlOZGVEdXlD?= =?utf-8?B?UVp1WU96Y0t0VUdOS3hKd3ZaeWxndU9VYUV1QlI2UWdvdzFBd0lkbGE3bDQy?= =?utf-8?B?SDZ5Y3A4M0dKYS9rK2tKM2pKRkdUSUtISEdCdmk4OG1OZ3lKK3Z3dlFTbWJC?= =?utf-8?B?TVQyMmd5RU9EMkdBSDMxNkRiRVJMelAvZVl5VHJld2RQM3ZnQVFzY0UwLzhZ?= =?utf-8?B?ekN2NXZubS9XdmVLd2wvU1lTeDI4M0JJMVprTEtFbTJEdTV0a1llOWFlR2c1?= =?utf-8?B?QXIrOGZtOWpDV294Wkc1eWt2R1d6eHZ0aU90dlc3MjV6Tml4WFlZcitUc1pH?= =?utf-8?B?UytNYzJ0R0JwOVhFdzNrekplaXNUbTZoSGc5M1c5WWsyUUQ1UUNHNkxicHFR?= =?utf-8?B?eXc1czUzREJIY28xckNhOWpwdWZ4djRsNU1JS0RRN3pvTHU2ZllqYUlJdXph?= =?utf-8?B?eW9iN2xLcFloMzhBZ2VJZ3dTc2Y0UEFKYzRnN1NVTUZjbENRdXNUNmpyUisy?= =?utf-8?B?TDk5UUwrZk5FTVB4NkIrcGQ5OWdvMnhDUHlnNUtwQnViaUhZbG4zU0pBU2Rs?= =?utf-8?B?bDJYTXdWc2poMThkUWtvcHBnV2RsRC9DK0hJT0gyLy9TM05NdzFxV2pFU3Aw?= =?utf-8?B?b0lJNnEyRU9qUy8vVVBpbzNBK2I4blJ4RHorbm1mWkNnb2pSUFlKbE1jWUtQ?= =?utf-8?B?VytKMFBnb2Z0dS82WFJ4eDY0NGFUYjNlNFVxdFRkc1REVS9HcjBSSGhOblNF?= =?utf-8?B?ZTl5UlF1NC9ZbElURlhKNFptMjFSbjJQbmp3TEFNelZacGE1UW94bjV6QThN?= =?utf-8?B?bEQxQzViamZqY2hLZHhvWlF6dkswc2lvRTZhdkR4d3I5QWtTelZpd2FwUkpo?= =?utf-8?B?MVZQYlpsckVNaDVNc2pTUWFHSi8xOUZ6blQxYXFGL2VtY2dVeEZZOFFzeWg0?= =?utf-8?B?b1ptZ2RyOXU1WmVEOE5aTWxPV1NGaE1iNmEwbDk0SlV4a1h5VGxWbmx5aklt?= =?utf-8?B?VWNNbVJYZEdYTmUwT1lETHVuejJNK3ZuelUraThHdkRWMGJuK2VkWTEyV2d6?= =?utf-8?Q?VHXSewgu9s+oR3l9w7?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66df0b65-b29d-4f36-513b-08defed1d9e5 X-MS-Exchange-CrossTenant-AuthSource: SN7PR12MB8131.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2026 15:43:59.2028 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a0MUpkMQUV3JNg0QaN2V2p8jphhe1bnlHp1cejlZcAb29oUY+YSAuT06LbcMGFTrsG7M6q9iijSgFsp7AWmdtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8949 On 8/20/26 00:06, Melody Wang wrote: > Hi Tom, Hi Melody, > > On 7/31/26 10:39 AM, Tom Lendacky wrote: >>> +int svsm_do_call(struct svsm_call *call) >>> +{ >>> +    call->caa = svsm_get_caa(); >>> +    return svsm_perform_call_protocol(call); >>> +} >> >> This helper is unneeded, all it does is set the calling area and then >> issue svsm_perform_call_protocol(). You're already setting other call >> values where you use this helper, so just add setting the calling area to >> those and directly issue svsm_perform_call_protocol(). > > Since svsm_perform_call_protocol() and svsm_get_caa() are all internal > functions to coco (arch/x86/coco/sev/internal.h), I can not call them > directly from the apic driver, so perhaps it is better that I have this > helper function here. Why not move svsm_get_caa() and svsm_perform_call_protocol() from internal.h then and make them available? Or create a callable function that lives in arch/x86/coco/sev/svsm.c that builds the svsm_call struct and performs the SVSM call? > >>> diff --git a/arch/x86/kernel/apic/svsm_apic.c b/arch/x86/kernel/apic/ >>> svsm_apic.c >>> new file mode 100644 >>> +static int svsm_apic_probe(void) >>> +{ >>> +    if (!cc_platform_has(CC_ATTR_SNP_ALTERNATE_INJECTION) || !snp_vmpl) >> >> Do you need both checks? Shouldn't the attribute only be set if the >> feature is set and the VMPL level is greater than 0? > > Yes, the cc_platform_has() just checks if the sev_status has the > MSR_AMD64_SNP_ALTERNATE_INJ bit set. Isn't that all that is needed? If the attribute is set none of the other injection methods can be used. If anything, you should terminate if alternate injection is enabled and you are running at VMPL0, because nothing can update the VMSA to set the injection/irq fields. > >>> +    /* Alternate Injection and Secure AVIC are mutually exclusive */ >>> +    if (cc_platform_has(CC_ATTR_SNP_SECURE_AVIC)) >>> +        return 0; >> >> What happens in this situation? Will Secure AVIC still work if Alternate >> Injection is enabled? > > Secure AVIC and Alternate Injection are mutually exclusive, if the > sev_status has secure AVIC set, we should not probe svsm apic: > > "15.36.21.2 VMRUN and #VMEXIT > Secure AVIC mode is mutually exclusive with Restricted Injection, > Alternate Injection, and > hypervisor controlled AVIC modes. If the SecureAvic bit is set to 1, and > the AVIC Enable bit in the > VMCB is set to 1 or the RestrictedInjection or AlternateInjection bits > in SEV_FEATURES are set to 1, > VMRUN will fail with #VMEXIT(VMEXIT_INVALID)." > > I'm thinking I should probably check for secure AVIC first and if set, > return 0. If the VMRUN fails because both are set, how can you possibly be running in the guest with both set? So I see no need to check for Secure AVIC. > >>> + >>> +    if (!x2apic_mode) { >>> +        pr_err("Alternate Injection in non x2APIC mode impossible. >>> Terminating.\n"); >>> +        sev_es_terminate(SEV_TERM_SET_GEN, GHCB_SNP_UNSUPPORTED); >>> +    } >>> + >>> +    pr_info("Alternate Injection SVSM APIC enabled\n"); >>> + >> >> Should the probe routine query the SVSM for the APIC protocol? > > Right now, the query for the APIC protocol is hardcoded as 0 which means > basic APIC functionality related to interrupt delivery. So it is not What if the version of the SVSM that is running doesn't have the APIC emulation protocol? > needed to query the APIC protocol now. In the future, when the SVSM code > changes with different set, we can adjust the guest code accordingly. > >> >>> +    return 1; >>> +} >>> + >>> +static int svsm_acpi_madt_oem_check(char *oem_id, char *oem_table_id) >>> +{ >>> +    return x2apic_enabled() && >>> cc_platform_has(CC_ATTR_SNP_ALTERNATE_INJECTION) && snp_vmpl; >>> +} >>> + >>> +static void svsm_apic_msr_write(u32 reg, u32 v) >>> +{ >>> +    u32 msr = APIC_BASE_MSR + (reg >> 4); >>> +    struct svsm_call call = {}; >>> +    int ret; >>> + >>> +    switch (reg) { >>> +    case APIC_ID: >>> +    case APIC_TASKPRI: >>> +    case APIC_PROCPRI: >>> +    case APIC_EOI: >>> +    case APIC_ISR ... APIC_ISR + 0x70: >>> +    case APIC_TMR ... APIC_TMR + 0x70: >>> +    case APIC_IRR ... APIC_IRR + 0x70: >>> +    case APIC_ICR: >>> +    case APIC_SELF_IPI: >>> +        call.rax = SVSM_APIC_CALL(SVSM_APIC_WRITE_REGISTER); >>> +        call.rcx = msr; >>> +        call.rdx = v; >>> + >>> +        ret = svsm_do_call(&call); >>> +        if (ret) { >>> +            pr_err("SVSM_APIC_WRITE_REGISTER: 0x%x, error: %d\n", >>> reg, ret); >>> +            sev_es_terminate(SEV_TERM_SET_GEN, GHCB_SNP_UNSUPPORTED); >> >> Can this be a new SEV_TERM_SET_LINUX value? >> >>> +        } >>> +        break; >>> +    default: >>> +        pr_err("SVSM_APIC_WRITE_REGISTER 0x%x not supported\n", reg); >>> +        break; >>> +    } >>> +} >>> + >>> +static u32 svsm_apic_msr_read(u32 reg) >>> +{ >>> +    u32 msr = APIC_BASE_MSR + (reg >> 4); >>> +    struct svsm_call call = {}; >>> +    int ret; >>> + >>> +    switch (reg) { >>> +    case APIC_ID: >>> +    case APIC_TASKPRI: >>> +    case APIC_PROCPRI: >>> +    case APIC_EOI: >>> +    case APIC_ISR ... APIC_ISR + 0x70: >>> +    case APIC_TMR ... APIC_TMR + 0x70: >>> +    case APIC_IRR ... APIC_IRR + 0x70: >>> +    case APIC_ICR: >>> +    case APIC_SELF_IPI: >>> +        call.rax = SVSM_APIC_CALL(SVSM_APIC_READ_REGISTER); >>> +        call.rcx = msr; >>> + >>> +        ret = svsm_do_call(&call); >>> +        if (ret) { >>> +            pr_err("SVSM_APIC_READ_REGISTER: 0x%x, error: %d\n", >>> reg, ret); >>> +            sev_es_terminate(SEV_TERM_SET_GEN, GHCB_SNP_UNSUPPORTED); >>> +        } >>> +        break; >>> +    default: >>> +        pr_err("SVSM_APIC_READ_REGISTER: 0x%x not supported\n", reg); >>> +        return 0; >>> +    } >>> + >>> +    return call.rdx_out; >>> +} >> >> The read and write are very similar. Can you have a common function that >> takes a reg paramter, value parameter (that is input and output), and a >> mode parameter (read/write) and then have small read and write functions? > > Yes, and Sashiko pointed that I need to prevent preemption for the caa > call, I agree with it, but I think I should prevent interrupts here - I > should do native_local_irq_save(), because there should not be any > interrupts during a caa call as those things are not reentrant. Thoughts? svsm_perform_call_protocol() already disables interrupts. Thanks, Tom > > Thanks, > Melody