Re: [2/3] drm/xe: Access MMIO after pcode init

["Poosa, Karthik" <karthik.poosa@intel.com>]

On 15-10-2026 22:24, Vinay Belgaumkar wrote:
> Allow pcode initialization to complete before we start poking around
> the MMIO space during resume. This ensures MMIO space is ready for access.
>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_pm.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index daa7ba2df317..1f5097875bcd 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -241,9 +241,6 @@ int xe_pm_resume(struct xe_device *xe)
>   	drm_dbg(&xe->drm, "Resuming device\n");
>   	trace_xe_pm_resume(xe, __builtin_return_address(0));
>   
> -	for_each_gt(gt, xe, id)
> -		xe_gt_idle_disable_c6(gt);
> -
>   	for_each_tile(tile, xe, id)
>   		xe_wa_apply_tile_workarounds(tile);

shouldn't xe_wa_apply_tile_workarounds() also be after pcode ready ?
are the MMIOs accessed inside independent of pcode readiness ?
if it is okay, below changes look right to me.

>   
> @@ -251,6 +248,9 @@ int xe_pm_resume(struct xe_device *xe)
>   	if (err)
>   		return err;
>   
> +	for_each_gt(gt, xe, id)
> +		xe_gt_idle_disable_c6(gt);
> +
>   	xe_display_pm_resume_early(xe);
>   
>   	/*
> @@ -698,13 +698,13 @@ int xe_pm_runtime_resume(struct xe_device *xe)
>   	xe_rpm_lockmap_acquire(xe);
>   
>   	if (xe->d3cold.allowed) {
> -		for_each_gt(gt, xe, id)
> -			xe_gt_idle_disable_c6(gt);
> -
>   		err = xe_pcode_ready(xe, true);
>   		if (err)
>   			goto out;
>   
> +		for_each_gt(gt, xe, id)
> +			xe_gt_idle_disable_c6(gt);
> +
>   		xe_display_pm_resume_early(xe);
>   
>   		/*