Re: [PATCH v8 11/15] drm/xe/xe_pci_error: Process errors in mmio_enabled

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

On 08-06-2026 02:17 pm, Riana Tauro wrote:
> Query system controller when any non fatal error occurs to check
> the type of the error, contain and recover.
>
> The system controller is queried in the mmio_enabled callback.
>
> Signed-off-by: Riana Tauro <riana.tauro@intel.com>
> Reviewed-by: Raag Jadav <raag.jadav@intel.com>
LGTM,
Reviewed-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> ---
> v2: use ras recovery enum (Raag)
>
> v3: add comment for mapping
>      use const (Mallesh)
>
> v4: use switch (Raag, Anshuman)
>
> v5: call pci_prepare_reset() before requesting SBR
>
> v6: rebase
> ---
>   drivers/gpu/drm/xe/xe_pci_error.c | 22 ++++++++++++++++++++--
>   1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pci_error.c b/drivers/gpu/drm/xe/xe_pci_error.c
> index ab17418aa164..b08601f470d6 100644
> --- a/drivers/gpu/drm/xe/xe_pci_error.c
> +++ b/drivers/gpu/drm/xe/xe_pci_error.c
> @@ -9,6 +9,7 @@
>   #include "xe_gt.h"
>   #include "xe_pci.h"
>   #include "xe_printk.h"
> +#include "xe_ras.h"
>   #include "xe_survivability_mode.h"
>   
>   static void prepare_device_for_reset(struct pci_dev *pdev)
> @@ -28,6 +29,21 @@ static void prepare_device_for_reset(struct pci_dev *pdev)
>   	pci_disable_device(pdev);
>   }
>   
> +static pci_ers_result_t ras_action_to_pci_result(struct pci_dev *pdev, u32 action)
> +{
> +	switch (action) {
> +	case XE_RAS_RECOVERY_ACTION_RECOVERED:
> +		return PCI_ERS_RESULT_RECOVERED;
> +	case XE_RAS_RECOVERY_ACTION_RESET:
> +		prepare_device_for_reset(pdev);
> +		return PCI_ERS_RESULT_NEED_RESET;
> +	case XE_RAS_RECOVERY_ACTION_DISCONNECT:
> +		return PCI_ERS_RESULT_DISCONNECT;
> +	default:
> +		return PCI_ERS_RESULT_DISCONNECT;
> +	}
> +}
> +
>   static pci_ers_result_t xe_pci_error_detected(struct pci_dev *pdev, pci_channel_state_t state)
>   {
>   	struct xe_device *xe = pdev_to_xe_device(pdev);
> @@ -56,11 +72,13 @@ static pci_ers_result_t xe_pci_error_detected(struct pci_dev *pdev, pci_channel_
>   static pci_ers_result_t xe_pci_error_mmio_enabled(struct pci_dev *pdev)
>   {
>   	struct xe_device *xe = pdev_to_xe_device(pdev);
> +	enum xe_ras_recovery_action action;
>   
>   	xe_err(xe, "PCI error: MMIO enabled\n");
>   
> -	/* TODO: Query system controller for the type of error and take appropriate action */
> -	return PCI_ERS_RESULT_RECOVERED;
> +	action = xe_ras_process_errors(xe);
> +
> +	return ras_action_to_pci_result(pdev, action);
>   }
>   
>   static pci_ers_result_t xe_pci_error_slot_reset(struct pci_dev *pdev)