From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Roger Quadros <rogerq@kernel.org>
Cc: Siddharth Vadapalli <s-vadapalli@ti.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, <linux-omap@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<srk@ti.com>, Pekka Varis <p-varis@ti.com>
Subject: Re: [PATCH net-next 2/2] net: ethernet: ti: am65-cpsw: enable DSCP to priority map for RX
Date: Mon, 11 Nov 2024 10:52:15 +0530 [thread overview]
Message-ID: <cfd634a1-3cff-4edd-8db8-d979b37cc2ea@ti.com> (raw)
In-Reply-To: <73f8d7a9-59ef-4d54-a024-4cf99d60abc0@kernel.org>
On Sat, Nov 09, 2024 at 12:31:24PM +0200, Roger Quadros wrote:
>
>
> On 08/11/2024 16:42, Siddharth Vadapalli wrote:
> > On Fri, Nov 08, 2024 at 02:55:18PM +0200, Roger Quadros wrote:
> >> Hi Siddharth,
> >>
> >> On 08/11/2024 14:30, Siddharth Vadapalli wrote:
> >
> > [...]
> >
> >>>> +#define AM65_CPSW_PORTN_REG_CTL 0x004
> >>>
> >>> nitpick: indentation needs to be fixed here to align with the macros
> >>> below.
> >>
> >> It is fine in the code and in my editor in this reply email.
> >
> > That's strange. But it appears the same to me as seen at:
> > https://lore.kernel.org/r/20241105-am65-cpsw-multi-rx-dscp-v1-2-38db85333c88@kernel.org/
> > where the indentation looks incorrect.
>
> It is probably editor specific. There are in fact 3 tab spaces to align it
> with the number.
>
> Can you please apply the patch and see if it is OK in the code?
I still see the indentation being off, but maybe it is just me seeing
this incorrectly.
Regards,
Siddharth.
prev parent reply other threads:[~2024-11-11 5:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 14:18 [PATCH net-next 0/2] net: ethernet: ti: am65-cpsw: enable DSCP to priority map for RX Roger Quadros
2024-11-05 14:18 ` [PATCH net-next 1/2] net: ethernet: ti: am65-cpsw: update pri_thread_map as per IEEE802.1Q-2004 Roger Quadros
2024-11-06 5:22 ` Siddharth Vadapalli
2024-11-06 8:51 ` Roger Quadros
2024-11-05 14:18 ` [PATCH net-next 2/2] net: ethernet: ti: am65-cpsw: enable DSCP to priority map for RX Roger Quadros
2024-11-08 12:30 ` Siddharth Vadapalli
2024-11-08 12:55 ` Roger Quadros
2024-11-08 14:42 ` Siddharth Vadapalli
2024-11-09 10:31 ` Roger Quadros
2024-11-11 5:22 ` Siddharth Vadapalli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfd634a1-3cff-4edd-8db8-d979b37cc2ea@ti.com \
--to=s-vadapalli@ti.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p-varis@ti.com \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.