From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-4192-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id 5B0761CB80F2 for ; Sat, 26 May 2018 00:22:32 -0700 (PDT) References: <1527180917-39737-1-git-send-email-sridhar.samudrala@intel.com> <1527180917-39737-3-git-send-email-sridhar.samudrala@intel.com> <20180525153456.28b44c7c@xeon-e3> <20180525162839.3c7028e1@xeon-e3> From: "Samudrala, Sridhar" Message-ID: Date: Sat, 26 May 2018 00:22:18 -0700 MIME-Version: 1.0 In-Reply-To: <20180525162839.3c7028e1@xeon-e3> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: [virtio-dev] Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework To: Stephen Hemminger Cc: mst@redhat.com, davem@davemloft.net, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com, alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com, loseweigh@gmail.com, jiri@resnulli.us, aaron.f.brown@intel.com, anjali.singhai@intel.com List-ID: On 5/25/2018 4:28 PM, Stephen Hemminger wrote: > On Fri, 25 May 2018 16:11:47 -0700 > "Samudrala, Sridhar" wrote: > >> On 5/25/2018 3:34 PM, Stephen Hemminger wrote: >>> On Thu, 24 May 2018 09:55:14 -0700 >>> Sridhar Samudrala wrote: >>> >>>> --- a/drivers/net/hyperv/Kconfig >>>> +++ b/drivers/net/hyperv/Kconfig >>>> @@ -2,5 +2,6 @@ config HYPERV_NET >>>> tristate "Microsoft Hyper-V virtual network driver" >>>> depends on HYPERV >>>> select UCS2_STRING >>>> + select FAILOVER >>> When I take a working kernel config, add the patches then do >>> make oldconfig >>> >>> It is not autoselecting FAILOVER, it prompts me for it. This means >>> if user says no then a non-working netvsc device is made. >> I see >> Generic failover module (FAILOVER) [M/y/?] (NEW) >> >> So the user is given an option to either build as a Module or part of the >> kernel. 'n' is not an option. > With most libraries there is no prompt at all. Not sure what you meant by this. Without any patches applied, i had a .config file with HYPERV_NET configured as a module. Then after applying the first 2 patches in this series, i did a make oldconfig and i see the above prompt. Are you saying that on some distros, 'make oldconfig creates a .config file without any prompt and FAILOVER is not getting selected even when HYPERV_NET is enabled? --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Samudrala, Sridhar" Subject: Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework Date: Sat, 26 May 2018 00:22:18 -0700 Message-ID: References: <1527180917-39737-1-git-send-email-sridhar.samudrala@intel.com> <1527180917-39737-3-git-send-email-sridhar.samudrala@intel.com> <20180525153456.28b44c7c@xeon-e3> <20180525162839.3c7028e1@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: mst@redhat.com, davem@davemloft.net, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com, alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com, loseweigh@gmail.com, jiri@resnulli.us, aaron.f.brown@intel.com, anjali.singhai@intel.com To: Stephen Hemminger Return-path: Received: from mga11.intel.com ([192.55.52.93]:53986 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031170AbeEZHWU (ORCPT ); Sat, 26 May 2018 03:22:20 -0400 In-Reply-To: <20180525162839.3c7028e1@xeon-e3> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 5/25/2018 4:28 PM, Stephen Hemminger wrote: > On Fri, 25 May 2018 16:11:47 -0700 > "Samudrala, Sridhar" wrote: > >> On 5/25/2018 3:34 PM, Stephen Hemminger wrote: >>> On Thu, 24 May 2018 09:55:14 -0700 >>> Sridhar Samudrala wrote: >>> >>>> --- a/drivers/net/hyperv/Kconfig >>>> +++ b/drivers/net/hyperv/Kconfig >>>> @@ -2,5 +2,6 @@ config HYPERV_NET >>>> tristate "Microsoft Hyper-V virtual network driver" >>>> depends on HYPERV >>>> select UCS2_STRING >>>> + select FAILOVER >>> When I take a working kernel config, add the patches then do >>> make oldconfig >>> >>> It is not autoselecting FAILOVER, it prompts me for it. This means >>> if user says no then a non-working netvsc device is made. >> I see >> Generic failover module (FAILOVER) [M/y/?] (NEW) >> >> So the user is given an option to either build as a Module or part of the >> kernel. 'n' is not an option. > With most libraries there is no prompt at all. Not sure what you meant by this. Without any patches applied, i had a .config file with HYPERV_NET configured as a module. Then after applying the first 2 patches in this series, i did a make oldconfig and i see the above prompt. Are you saying that on some distros, 'make oldconfig creates a .config file without any prompt and FAILOVER is not getting selected even when HYPERV_NET is enabled?