From: Stephane Chazelas <stephane.chazelas@gmail.com>
To: Hugo Mills <hugo@carfax.org.uk>
Cc: linux-btrfs@vger.kernel.org
Subject: [PATCH] [btrfs-progs integration] incorrect argument checking for "btrfs sub snap -r"
Date: Thu, 30 Jun 2011 13:34:38 +0100 [thread overview]
Message-ID: <chaz20110630123438.GE28702@seebyte.com> (raw)
In-Reply-To: <20110630105813.GD11170@carfax.org.uk>
Looks like this was missing in integration-20110626 for the
readonly snapshot patch:
diff --git a/btrfs.c b/btrfs.c
index e117172..be6ece5 100644
--- a/btrfs.c
+++ b/btrfs.c
@@ -49,7 +49,7 @@ static struct Command commands[] = {
/*
avoid short commands different for the case only
*/
- { do_clone, 2,
+ { do_clone, -1,
"subvolume snapshot", "[-r] <source> [<dest>/]<name>\n"
"Create a writable/readonly snapshot of the subvolume <source> with\n"
"the name <name> in the <dest> directory.",
Without that, "btrfs sub snap -r x y" would fail as it's not *2*
arguments.
--
Stephane
next prev parent reply other threads:[~2011-06-30 12:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 14:37 subvolumes missing from "btrfs subvolume list" output Stephane Chazelas
2011-06-29 15:00 ` Stephane Chazelas
2011-06-29 16:16 ` Josef Bacik
2011-06-29 16:47 ` Hugo Mills
2011-06-29 16:50 ` Hugo Mills
2011-06-29 20:41 ` Goffredo Baroncelli
2011-06-30 0:47 ` Li Zefan
2011-06-30 8:40 ` Stephane Chazelas
2011-06-30 9:18 ` Andreas Philipp
2011-06-30 10:43 ` Stephane Chazelas
2011-06-30 10:52 ` Andreas Philipp
2011-06-30 10:54 ` Hugo Mills
2011-06-30 10:58 ` Hugo Mills
2011-06-30 12:34 ` Stephane Chazelas [this message]
2011-06-30 13:07 ` [PATCH] [btrfs-progs integration] incorrect argument checking for "btrfs sub snap -r" Hugo Mills
2011-06-30 20:55 ` Andreas Philipp
2011-06-30 21:09 ` Hugo Mills
2011-07-01 8:26 ` [PATCH] " Stephane Chazelas
2011-07-01 10:13 ` Andreas Philipp
2011-07-01 10:42 ` Hugo Mills
2011-07-01 12:55 ` Stephane Chazelas
2011-08-11 4:30 ` Tsutomu Itoh
2011-08-11 6:45 ` Andreas Philipp
2011-08-11 12:40 ` Hugo Mills
2011-07-01 1:08 ` subvolumes missing from "btrfs subvolume list" output Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=chaz20110630123438.GE28702@seebyte.com \
--to=stephane.chazelas@gmail.com \
--cc=hugo@carfax.org.uk \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.