All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
	Jakub Narebski <jnareb@gmail.com>,
	Jay Soffian <jaysoffian@gmail.com>,
	Daniel Barkalow <barkalow@iabervon.org>
Subject: [PATCH v2 next 0/4] format-patch --cover-letter --in-reply-to
Date: Fri, 20 Feb 2009 20:55:36 +0100	[thread overview]
Message-ID: <cover.1235158956.git.trast@student.ethz.ch> (raw)
In-Reply-To: <alpine.LNX.1.00.0902191734110.19665@iabervon.org>

Daniel Barkalow wrote:
> On Thu, 19 Feb 2009, Thomas Rast wrote:
> 
> > Currently, format-patch can only track a single reference (the
> > In-Reply-To:) for each mail.  To ensure proper threading, we should
> > list all known references for every mail.
> > 
> > Change the rev_info.ref_message_id field to a string_list
> 
> It would be nice to change the field name to "ref_message_ids", which is 
> more likely to suggest that it's a list of ids, rather than a single id 
> stored strangely.

Good point, I changed that.

> Aside from that, parts 2-4 look good to me (I'm not up on reviewing shell 
> code).

Thanks.

I also noticed that there is a textual conflict with 0db5260 (Enable
setting attach as the default in .gitconfig for git-format-patch.,
2009-02-12), which is already in 'next'.  So I rebased the series to
'next'.



Thomas Rast (4):
  format-patch: threading test reactivation
  format-patch: track several references
  format-patch: thread as reply to cover letter even with in-reply-to
  format-patch: support deep threading

 Documentation/config.txt           |   10 ++
 Documentation/git-format-patch.txt |   10 ++-
 builtin-log.c                      |   66 ++++++++--
 log-tree.c                         |   11 +-
 revision.h                         |    2 +-
 t/t4014-format-patch.sh            |  265 ++++++++++++++++++++++++++++++------
 6 files changed, 308 insertions(+), 56 deletions(-)

  reply	other threads:[~2009-02-20 19:57 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-14 19:54 [PATCH] bash completion: offer more options for gitk Thomas Rast
2009-02-15  9:33 ` Junio C Hamano
2009-02-15  9:56   ` Santi Béjar
2009-02-16 16:34     ` [PATCH v2 0/2] bash completion: more options for gitk/log/shortlog Thomas Rast
2009-02-16 16:38       ` Thomas Rast
2009-02-16 19:00       ` [RFC PATCH] format-patch: thread as reply to cover letter even with in-reply-to Thomas Rast
2009-02-16 20:22         ` Jay Soffian
2009-02-16 20:34           ` Thomas Rast
2009-02-16 20:52             ` Jakub Narebski
2009-02-16 23:27               ` Thomas Rast
2009-02-19 21:26                 ` [PATCH 0/4] format-patch --cover-letter --in-reply-to Thomas Rast
2009-02-19 21:26                   ` [PATCH 1/4] format-patch: threading test reactivation Thomas Rast
2009-02-19 21:26                   ` [PATCH 2/4] format-patch: track several references Thomas Rast
2009-02-19 22:41                     ` Daniel Barkalow
2009-02-20 19:55                       ` Thomas Rast [this message]
2009-02-20 19:55                         ` [PATCH v2 next 1/4] format-patch: threading test reactivation Thomas Rast
2009-02-20 19:55                         ` [PATCH v2 next 2/4] format-patch: track several references Thomas Rast
2009-02-20 19:55                         ` [PATCH v2 next 3/4] format-patch: thread as reply to cover letter even with in-reply-to Thomas Rast
2009-02-20 19:55                         ` [PATCH v2 next 4/4] format-patch: support deep threading Thomas Rast
2009-02-22 16:49                         ` [PATCH v2 next 0/4] format-patch --cover-letter --in-reply-to Junio C Hamano
2009-02-19 21:26                   ` [PATCH 3/4] format-patch: thread as reply to cover letter even with in-reply-to Thomas Rast
2009-02-19 21:26                   ` [PATCH 4/4] format-patch: support deep threading Thomas Rast
2009-02-16 16:34     ` [PATCH v2 1/2] bash completion: refactor common log, shortlog and gitk options Thomas Rast
2009-02-16 16:34     ` [PATCH v2 2/2] bash completion: only show 'log --merge' if merging Thomas Rast
2009-02-18 17:05       ` Shawn O. Pearce
2009-02-18 19:02         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1235158956.git.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jaysoffian@gmail.com \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.