From: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>,
Pavel Machek <pavel-AlSwsSmVLrQ@public.gmane.org>,
Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: [PATCH 0/4] cgroup freezer: Fixes and CHECKPOINTING support
Date: Wed, 3 Jun 2009 02:31:17 -0700 [thread overview]
Message-ID: <cover.1244019829.git.matthltc@us.ibm.com> (raw)
This series fixes a bug with the mainline cgroup freezer code and
cleans up the cgroup freezer before introducing the new
CHECKPOINTING state in the last patch. All but this last patch are
independent of checkpoint/restart and hence should be suitable for
mainline.
The bug was noticed by Oren Ladaan and allows tasks frozen via the
cgroup freezer to be thawed during resume when they should remain
frozen. In Oren's checkpoint/restart tree is means that
sys_checkpoint() sometimes returns EBUSY even when the cgroup is,
in fact, fully frozen. (Workaround: cat /cgroup/foo/freezer.state
before doing checkpoint..)
The final patch, which adds the CHECKPOINTING state, incorporates
Oren's comments and should fix the lockdep bug he posted too. I
haven't tested this latest version yet myself and I have a few things to
attend to before I can get to it so I'm posting this for initial review
now. I believe this resolves all the pending comments I've seen about
the CHECKPOINTING state.
Cheers,
-Matt Helsley
Matt Helsley (4):
cgroup freezer: Fix buggy resume test for tasks frozen with cgroup
freezer
cgroup freezer: Avoid lazy state changes when convenient
cgroup freezer: Update stale locking comments
cgroup freezer: Add CHECKPOINTING state to safeguard container
checkpoint
Documentation/cgroups/freezer-subsystem.txt | 10 ++
checkpoint/checkpoint.c | 8 +-
include/linux/freezer.h | 15 ++-
kernel/cgroup_freezer.c | 163 +++++++++++++++++++--------
kernel/power/process.c | 2 +-
5 files changed, 146 insertions(+), 52 deletions(-)
next reply other threads:[~2009-06-03 9:31 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 9:31 Matt Helsley [this message]
[not found] ` <cover.1244019829.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-03 9:31 ` [PATCH 1/4] cgroup freezer: Fix buggy resume test for tasks frozen with cgroup freezer Matt Helsley
[not found] ` <91260d5797bcf233ca54c7b41da8278e99b4ca66.1244019829.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-03 16:05 ` Serge E. Hallyn
2009-06-04 0:55 ` Li Zefan
[not found] ` <20090603160551.GB7848-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-04 0:55 ` Li Zefan
2009-06-11 21:56 ` Matt Helsley
[not found] ` <4A271B75.7090607-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-11 21:56 ` Matt Helsley
2009-06-03 16:05 ` Serge E. Hallyn
2009-06-03 9:31 ` [PATCH 2/4] cgroup freezer: Avoid lazy state changes when convenient Matt Helsley
[not found] ` <03412f8681d89c99ac575330381ab49f6e5e61ba.1244019829.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-03 16:10 ` Serge E. Hallyn
[not found] ` <20090603161046.GC7848-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-03 17:52 ` Matt Helsley
[not found] ` <20090603175242.GQ9285-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-03 18:15 ` Serge E. Hallyn
[not found] ` <20090603181547.GA10141-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-04 3:18 ` Matt Helsley
[not found] ` <20090604031842.GR9285-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-07 21:36 ` Nathan Lynch
2009-06-03 19:52 ` Serge E. Hallyn
2009-06-03 9:31 ` [PATCH 3/4] cgroup freezer: Update stale locking comments Matt Helsley
2009-06-03 9:31 ` [PATCH 4/4] cgroup freezer: Add CHECKPOINTING state to safeguard container checkpoint Matt Helsley
[not found] ` <89c3726813accffb7c51cd30ff93b79a4391f382.1244019829.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-03 16:18 ` Serge E. Hallyn
[not found] ` <20090603161840.GD7848-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-04 0:01 ` Oren Laadan
[not found] ` <Pine.LNX.4.64.0906031957110.19096-CXF6herHY6ykSYb+qCZC/1i27PF6R63G9nwVQlTi/Pw@public.gmane.org>
2009-06-04 0:10 ` [PATCH 4/4] cgroup freezer: --- replacement patch 4/4 (a) Oren Laadan
[not found] ` <Pine.LNX.4.64.0906032008490.19096-CXF6herHY6ykSYb+qCZC/1i27PF6R63G9nwVQlTi/Pw@public.gmane.org>
2009-06-04 10:34 ` Matt Helsley
[not found] ` <20090604103418.GW9285-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-04 13:44 ` Oren Laadan
[not found] ` <Pine.LNX.4.64.0906040939100.25421-CXF6herHY6ykSYb+qCZC/1i27PF6R63G9nwVQlTi/Pw@public.gmane.org>
2009-06-04 13:54 ` Oren Laadan
2009-06-04 16:32 ` Oren Laadan
2009-06-04 14:32 ` Serge E. Hallyn
2009-06-04 0:12 ` [PATCH 4/4] cgroup freezer: --- replacement patch 4/4 (b) Oren Laadan
[not found] ` <Pine.LNX.4.64.0906032011470.19096-CXF6herHY6ykSYb+qCZC/1i27PF6R63G9nwVQlTi/Pw@public.gmane.org>
2009-06-04 10:45 ` Matt Helsley
[not found] ` <20090604104527.GY9285-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-04 13:52 ` Oren Laadan
2009-06-04 14:04 ` Serge E. Hallyn
2009-06-04 10:44 ` [PATCH 4/4] cgroup freezer: Add CHECKPOINTING state to safeguard container checkpoint Matt Helsley
2009-06-03 16:53 ` Oren Laadan
2009-06-03 9:31 ` [PATCH 1/4] cgroup freezer: Fix buggy resume test for tasks frozen with cgroup freezer Matt Helsley
-- strict thread matches above, loose matches on Subject: below --
2009-06-03 9:31 [PATCH 0/4] cgroup freezer: Fixes and CHECKPOINTING support Matt Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1244019829.git.matthltc@us.ibm.com \
--to=matthltc-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=pavel-AlSwsSmVLrQ@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.