From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 0/3] Make pcspk like rest of audio cards
Date: Tue, 11 Aug 2009 01:50:42 +0200 [thread overview]
Message-ID: <cover.1249948198.git.quintela@redhat.com> (raw)
v2
We use c99 initializers in malc style, open and closed parents in the same line,
and = signs aligned.
v1:
This patch series add c99 initializers to sound cards in vl.c.
Sound card support depends of target, move CONFIG_FOO generation there.
Once here, I wanted to disable CONFIG_PCSPK, but found a problem.
pcskpr is registered as a port on mips_jazz.c and pc.c, and then as an audio card.
Options are:
- let things as they are (if you get a pc or mips_jazz, you get a
pc speaker port and a pcspk audio card.
- be able to remove pc speaker audio support, but let the speaker port
as it is now
- make pcspk_init() an empty function in hw.h depending of CONFIG_PCSPK value.
Any thoughts?
Later, Juan.
Juan Quintela (3):
Bring audio cards structs to C99 initializers
What cards to compile is a per target thing
Make pc speaker be configured the same way that the rest of the cards
Makefile.target | 5 ++-
configure | 16 +++++++--
vl.c | 91 +++++++++++++++++++++++--------------------------------
3 files changed, 53 insertions(+), 59 deletions(-)
next reply other threads:[~2009-08-10 23:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 23:50 Juan Quintela [this message]
2009-08-10 23:50 ` [Qemu-devel] [PATCH 1/3] Bring audio cards structs to C99 initializers Juan Quintela
2009-08-10 23:50 ` [Qemu-devel] [PATCH 2/3] What cards to compile is a per target thing Juan Quintela
2009-08-10 23:50 ` [Qemu-devel] [PATCH 3/3] Make pc speaker be configured the same way that the rest of the cards Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1249948198.git.quintela@redhat.com \
--to=quintela@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.