From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 00/20] Const fixes
Date: Thu, 16 Dec 2010 11:36:08 +0100 [thread overview]
Message-ID: <cover.1292495195.git.zkabelac@redhat.com> (raw)
Primary reason for this patchset is to make stronger
const limitation around config_tree handling.
So we can be sure where this tree could be modified.
It also cleanup quite a few hidden const warning
(-Wbad-function-cast -Wcast-qual)
Patch is extended with few more minor patches gathers
from my tree which should be easy to review. Some of them
are probably some minor bugs in the code so it's worth to
check them in.
Zdenek Kabelac (20):
Add more strict const pointers around config tree
Const fixes and additions
Use const char* const *
Remove wrong cast to (char*)
Remove const from destroy callback
Replace void* arithmetic with char*
Use const char * arithmetic for offset calculation
Use const char * for name and old_name in vg
Replace stack trace with failure exit path
Simplify usage fprintf clvmd
Add test for 'read' result
Add test for allocation results for node clonning
Properly use dm_free
Remove dead store in _clog_ctr
Remove dead assignment in _init_logging
Remove dead store in lvm_run_command
Remove dead assignment in dev_manager_transient
Remove dead assignment in _remove
Remove unused dev_dir_provided
Add internal error if pointer is uninitialized
daemons/clvmd/clvmd.c | 41 ++++++++--------
daemons/cmirrord/functions.c | 32 +++++-------
lib/activate/activate.c | 6 +-
lib/activate/dev_manager.c | 2 +-
lib/commands/toolcontext.c | 17 +++----
lib/config/config.c | 100 ++++++++++++++++++++++----------------
lib/config/config.h | 14 +++---
lib/datastruct/btree.c | 2 +-
lib/device/dev-cache.c | 6 +-
lib/error/errseg.c | 4 +-
lib/filters/filter-persistent.c | 2 +-
lib/filters/filter-regex.c | 8 ++--
lib/filters/filter-regex.h | 2 +-
lib/filters/filter.c | 4 +-
lib/format1/format1.c | 4 +-
lib/format_pool/disk_rep.c | 5 ++
lib/format_pool/format_pool.c | 6 +-
lib/format_text/flags.c | 2 +-
lib/format_text/format-text.c | 12 ++--
lib/format_text/import-export.h | 12 ++--
lib/format_text/import.c | 2 +-
lib/format_text/import_vsn1.c | 67 +++++++++++++-------------
lib/format_text/tags.c | 2 +-
lib/freeseg/freeseg.c | 4 +-
lib/metadata/lv_manip.c | 4 +-
lib/metadata/metadata.h | 4 +-
lib/metadata/segtype.h | 4 +-
lib/metadata/vg.h | 4 +-
lib/mirror/mirrored.c | 8 ++--
lib/mm/memlock.c | 2 +-
lib/replicator/replicator.c | 8 ++--
lib/snapshot/snapshot.c | 4 +-
lib/striped/striped.c | 6 +-
lib/unknown/unknown.c | 4 +-
lib/zero/zero.c | 4 +-
libdm/libdevmapper.h | 4 +-
libdm/regex/matcher.c | 2 +-
liblvm/lvm_base.c | 2 +-
tools/dmsetup.c | 10 ++--
tools/lvmcmdline.c | 20 +++++---
tools/toollib.c | 2 -
41 files changed, 232 insertions(+), 216 deletions(-)
--
1.7.3.3
next reply other threads:[~2010-12-16 10:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 10:36 Zdenek Kabelac [this message]
2010-12-16 10:36 ` [PATCH 01/20] Add more strict const pointers around config tree Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 02/20] Const fixes and additions Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 03/20] Use const char* const * Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 04/20] Remove wrong cast to (char*) Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 05/20] Remove const from destroy callback Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 06/20] Replace void* arithmetic with char* Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 07/20] Use const char * arithmetic for offset calculation Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 08/20] Use const char * for name and old_name in vg Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 09/20] Replace stack trace with failure exit path Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 10/20] Simplify usage fprintf clvmd Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 11/20] Add test for 'read' result Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 12/20] Add test for allocation results for node clonning Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 13/20] Properly use dm_free Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 14/20] Remove dead store in _clog_ctr Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 15/20] Remove dead assignment in _init_logging Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 16/20] Remove dead store in lvm_run_command Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 17/20] Remove dead assignment in dev_manager_transient Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 18/20] Remove dead assignment in _remove Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 19/20] Remove unused dev_dir_provided Zdenek Kabelac
2010-12-16 10:36 ` [PATCH 20/20] Add internal error if pointer is uninitialized Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1292495195.git.zkabelac@redhat.com \
--to=zkabelac@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.