From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 0/2] PV_MIN_SIZE
Date: Fri, 11 Feb 2011 11:08:46 +0100 [thread overview]
Message-ID: <cover.1297418304.git.zkabelac@redhat.com> (raw)
Patch which adds parameter for minimal size of device to
be usable as PV.
Milan suggested other option to add new filter filter_pv_min_size
and keep the rest of the code as is. So pv_min_size() would be
used only in filter.c and pvresize & lib/metadata/metadata.c
would still use hardcoded define 512KB.
But IMHO this could lead to user confusion as user would be able
to create PV which is then invisible because of filter settings.
Looks to me more consistent to refuse any operation on such device.
But both ways are valid - we need decision which way to go.
Zdenek Kabelac (2):
Add find_config_tree_int64 function
Replace PV_MIN_SIZE with function pv_min_size()
doc/example.conf.in | 5 +++++
lib/commands/toolcontext.c | 11 ++++++++++-
lib/config/config.c | 6 ++++++
lib/config/config.h | 2 ++
lib/filters/filter.c | 2 +-
lib/metadata/metadata-exported.h | 1 -
lib/metadata/metadata.c | 6 +++---
lib/metadata/metadata.h | 1 -
lib/misc/lvm-globals.c | 12 ++++++++++++
lib/misc/lvm-globals.h | 5 ++++-
tools/pvresize.c | 6 +++---
11 files changed, 46 insertions(+), 11 deletions(-)
--
1.7.4
next reply other threads:[~2011-02-11 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 10:08 Zdenek Kabelac [this message]
2011-02-11 10:08 ` [PATCH 1/2] Add find_config_tree_int64 function Zdenek Kabelac
2011-02-11 10:08 ` [PATCH 2/2] Replace PV_MIN_SIZE with function pv_min_size() Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1297418304.git.zkabelac@redhat.com \
--to=zkabelac@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.