All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: qemu list <qemu-devel@nongnu.org>
Cc: Amit Shah <amit.shah@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 0/7] New iohandler API
Date: Tue, 22 Feb 2011 15:48:29 +0530	[thread overview]
Message-ID: <cover.1298369272.git.amit.shah@redhat.com> (raw)

Hello,

This is a new iohandler API implementation.  It gets rid of the
multiple callbacks and switches to just one callback with an event
mask that triggered the callback.

qemu-char.c has been trivially updated to replace all usage of
qemu_set_fd_handler* functions to the new api.

Future work includes removing the qemu_set_fd_handler* functions and
getting rid of #include "qemu-char.h" from all the src files that
don't need it (most of them).

The users of the char api can then be also converted over to a new api
in similar fashion, deprecating the usage of can_read callbacks
altogether.

I tested this series in two scenarios: monitor on stdio and by running
the virtio-serial testsuite, which uses unix sockets and does
open/close/read/write/poll calls on the sockets.  It all works fine.

Please review and apply.

Amit Shah (7):
  iohandlers: Mark current implementation as 'old'
  iohandlers: Introduce a new API
  char: tcp: Use new iohandler api
  char: udp: Use new iohandler api
  char: fd: Use new iohandler api
  char: stdio: Use new iohandler api
  char: pty: Use new iohandler api

 iohandler.h |   28 +++++++++++
 qemu-char.c |  140 +++++++++++++++++++++++++++++++++++++++++++----------
 vl.c        |  154 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
 3 files changed, 291 insertions(+), 31 deletions(-)
 create mode 100644 iohandler.h

-- 
1.7.4

             reply	other threads:[~2011-02-22 10:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-22 10:18 Amit Shah [this message]
2011-02-22 10:18 ` [Qemu-devel] [PATCH 1/7] iohandlers: Mark current implementation as 'old' Amit Shah
2011-02-22 11:09   ` Avi Kivity
2011-02-22 11:17     ` Amit Shah
2011-02-22 13:28       ` Avi Kivity
2011-02-22 14:37         ` Amit Shah
2011-02-22 14:43           ` Avi Kivity
2011-02-22 10:18 ` [Qemu-devel] [PATCH 2/7] iohandlers: Introduce a new API Amit Shah
2011-02-22 12:39   ` Alon Levy
2011-02-22 13:09     ` Amit Shah
2011-02-22 13:28   ` Avi Kivity
2011-02-22 14:39     ` Amit Shah
2011-02-22 15:00     ` Anthony Liguori
2011-02-22 16:21       ` Avi Kivity
2011-02-22 18:21         ` Anthony Liguori
2011-02-23 12:40           ` Avi Kivity
2011-02-22 14:49   ` [Qemu-devel] " Anthony Liguori
2011-02-22 10:18 ` [Qemu-devel] [PATCH 3/7] char: tcp: Use new iohandler api Amit Shah
2011-02-22 10:18 ` [Qemu-devel] [PATCH 4/7] char: udp: " Amit Shah
2011-02-22 10:18 ` [Qemu-devel] [PATCH 5/7] char: fd: " Amit Shah
2011-02-22 10:18 ` [Qemu-devel] [PATCH 6/7] char: stdio: " Amit Shah
2011-02-22 10:18 ` [Qemu-devel] [PATCH 7/7] char: pty: " Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1298369272.git.amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.