All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: qemu list <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	Markus Armbruster <armbru@redhat.com>,
	Amit Shah <amit.shah@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/6] atapi: Implement 'media' subcommand for GESN
Date: Tue, 12 Apr 2011 14:57:38 +0530	[thread overview]
Message-ID: <cover.1302600061.git.amit.shah@redhat.com> (raw)

The GET_EVENT_STATUS_NOTIFICATION ATAPI command is listed as a
mandatory command in the spec but we don't really implement it any of
its sub-commands.

The commit message for the last commit explains why implementing just
the media subcommand is helpful and how it goes a long way in getting
guests to behave as expected.

The difference from the RFC series sent earlier is:
- Split into more patches
- Add tray open/close notification (from Markus)

There certainly is much more work to be done for the other commands
and also for state change handling (tray open / close / new media)
overall for the block layer, but this is a good first step in being
spec-compliant and at the same time making guests work.

v2:
 - Update comments
 - Use struct instead of enum for cdb packet
 - Add a new subsection to vmstate for new fields for save/restore

v1:
 - Split into more patches
 - Add tray open/close notification (from Markus)

RFC:
 - Orig. series


Amit Shah (6):
  atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change
  atapi: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own
    function
  atapi: GESN: Spin off No Event Available handling into own function
  atapi: GESN: Use structs for commonly-used field types
  atapi: GESN: implement 'media' subcommand
  atapi: Save / load the new GESN event states during migration

 hw/ide/core.c     |  186 +++++++++++++++++++++++++++++++++++++++++++++++------
 hw/ide/internal.h |    6 ++
 2 files changed, 173 insertions(+), 19 deletions(-)

-- 
1.7.4.2

             reply	other threads:[~2011-04-12  9:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12  9:27 Amit Shah [this message]
2011-04-12  9:27 ` [Qemu-devel] [PATCH v2 1/6] atapi: Allow GESN after media change Amit Shah
2011-04-12  9:54   ` Kevin Wolf
2011-04-12  9:27 ` [Qemu-devel] [PATCH v2 2/6] atapi: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own function Amit Shah
2011-04-12  9:27 ` [Qemu-devel] [PATCH v2 3/6] atapi: GESN: Spin off No Event Available handling into " Amit Shah
2011-04-12  9:27 ` [Qemu-devel] [PATCH v2 4/6] atapi: GESN: Use structs for commonly-used field types Amit Shah
2011-04-12 10:07   ` Kevin Wolf
2011-04-12  9:27 ` [Qemu-devel] [PATCH v2 5/6] atapi: GESN: implement 'media' subcommand Amit Shah
2011-04-12 10:41   ` Kevin Wolf
2011-04-12  9:27 ` [Qemu-devel] [PATCH v2 6/6] atapi: Save / load the new GESN event states during migration Amit Shah
2011-04-12 10:43   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1302600061.git.amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.