All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Haxby <john.haxby@oracle.com>
To: netfilter-devel@vger.kernel.org
Cc: prarit@redhat.com, John Haxby <john.haxby@oracle.com>
Subject: [PATCH 0/2] Security improvements for xt_SYSRQ
Date: Fri, 24 Jun 2011 14:14:12 +0100	[thread overview]
Message-ID: <cover.1308920081.git.john.haxby@oracle.com> (raw)

Hello All,

These two patches are something I promised a long time ago and never
actually got around to.

The first patch is just housekeeping: it uses %pI4 and %pI6c for
address formatting in when the debug option is turned on.  Actually,
it's not just housekeeping: the IPv6 sysrq trigger never worked
because of some bad pointer arithmetic.  I also show the destination
IP (or IPv6) address in the debug output because that helps you when
debugging the remote sysrq script for the second patch.

The second patch removed a long standing issue I have had with
xt_SYSRQ.  Someone who doesn't carefully make sure all the hosts with
xt_SYSRQ rules have different, difficult to guess passwords runs the
risk of an attacker replaying a request to every host on the network
"just on the off chance".  The hash now includes the destination IP
address to make this kind of opportunistic hack less likely.

jch

John Haxby (2):
  Use %pI4/%pI6c instead of NIPQUAD_FMT/NIP6_FMT and make IPv6 work
  Improve security for xt_SYSRQ

 extensions/libxt_SYSRQ.man |   17 +++++++++++------
 extensions/xt_SYSRQ.c      |   27 ++++++++++++++++-----------
 2 files changed, 27 insertions(+), 17 deletions(-)

-- 
1.7.5.4


             reply	other threads:[~2011-06-24 13:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-24 13:14 John Haxby [this message]
2011-06-24 13:14 ` [PATCH 1/2] Use %pI4/%pI6c instead of NIPQUAD_FMT/NIP6_FMT and make IPv6 work John Haxby
2011-06-24 21:40   ` Jan Engelhardt
2011-06-24 13:14 ` [PATCH 2/2] Improve security for xt_SYSRQ John Haxby
2011-06-24 22:04   ` Jan Engelhardt
2011-06-24 13:30 ` [PATCH 0/2] Security improvements " John Haxby
2011-06-24 14:08   ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1308920081.git.john.haxby@oracle.com \
    --to=john.haxby@oracle.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=prarit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.