From: Amit Shah <amit.shah@redhat.com>
To: qemu list <qemu-devel@nongnu.org>
Cc: Amit Shah <amit.shah@redhat.com>, Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH 0/7] balloon: cleanups, fix segfault
Date: Wed, 20 Jul 2011 14:05:26 +0530 [thread overview]
Message-ID: <cover.1311149456.git.amit.shah@redhat.com> (raw)
'balloon 0' in the monitor causes a segfault. This happens because
the function that handles change in balloon values is also tasked with
handling stats retrieval from the guest, and it does the retrieval
when the balloon target is '0'.
Silly API, replace it. Also do a few cleanups along the way.
Amit Shah (7):
balloon: Make functions, local vars static
balloon: Add braces around if statements
balloon: Simplify code flow
virtio-balloon: Separate status handling into separate function
balloon: Separate out stat and balloon handling
balloon: Fix header comment; add Copyright
virtio-balloon: Fix header comment; add Copyright
balloon.c | 47 +++++++++++++++++++++------------------
balloon.h | 12 ++++------
hw/virtio-balloon.c | 60 +++++++++++++++++++++++++++++---------------------
3 files changed, 65 insertions(+), 54 deletions(-)
--
1.7.6
next reply other threads:[~2011-07-20 8:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 8:35 Amit Shah [this message]
2011-07-20 8:45 ` [Qemu-devel] [PATCH 1/7] balloon: Make functions, local vars static Amit Shah
2011-07-20 8:45 ` [Qemu-devel] [PATCH 2/7] balloon: Add braces around if statements Amit Shah
2011-07-20 8:45 ` [Qemu-devel] [PATCH 3/7] balloon: Simplify code flow Amit Shah
2011-07-20 8:45 ` [Qemu-devel] [PATCH 4/7] virtio-balloon: Separate status handling into separate function Amit Shah
2011-07-20 8:45 ` [Qemu-devel] [PATCH 5/7] balloon: Separate out stat and balloon handling Amit Shah
2011-07-22 14:45 ` Markus Armbruster
2011-07-23 3:10 ` Amit Shah
2011-07-25 14:11 ` Markus Armbruster
2011-07-20 8:45 ` [Qemu-devel] [PATCH 6/7] balloon: Fix header comment; add Copyright Amit Shah
2011-07-20 8:45 ` [Qemu-devel] [PATCH 7/7] virtio-balloon: " Amit Shah
2011-07-25 14:13 ` [Qemu-devel] [PATCH 0/7] balloon: cleanups, fix segfault Markus Armbruster
2011-07-25 15:49 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1311149456.git.amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.