All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Larson <kergoth@gmail.com>
To: bitbake-devel@lists.openembedded.org
Subject: [PATCH 0/2] Simplify PythonParser
Date: Fri, 28 Oct 2011 07:50:22 -0700	[thread overview]
Message-ID: <cover.1319813177.git.kergoth@gmail.com> (raw)

As you can see below, this simplifies the python parser by merging its nested
class into the main class, and by simplifying the name comparison logic. This
also seems to increase up front parse performance slightly, as can be seen
here, the result of wiping the cache and running bitbake -p repeatedly:

Old:
  77.72user 11.98system 1:12.54elapsed 123%CPU (0avgtext+0avgdata 509456maxresident)k
  0inputs+32136outputs (0major+132904minor)pagefaults 0swaps
  77.48user 12.73system 1:12.28elapsed 124%CPU (0avgtext+0avgdata 508704maxresident)k
  0inputs+32096outputs (0major+134062minor)pagefaults 0swaps
  80.30user 9.69system 1:04.96elapsed 138%CPU (0avgtext+0avgdata 511520maxresident)k
  0inputs+32112outputs (0major+132475minor)pagefaults 0swaps
  79.53user 11.29system 1:05.46elapsed 138%CPU (0avgtext+0avgdata 510704maxresident)k
  0inputs+32088outputs (0major+132093minor)pagefaults 0swaps
  78.89user 10.94system 1:09.31elapsed 129%CPU (0avgtext+0avgdata 505616maxresident)k
  0inputs+32136outputs (0major+132909minor)pagefaults 0swaps
  79.70user 10.41system 1:08.17elapsed 132%CPU (0avgtext+0avgdata 511632maxresident)k
  0inputs+32088outputs (0major+133901minor)pagefaults 0swaps

New:
  69.95user 17.44system 1:01.31elapsed 142%CPU (0avgtext+0avgdata 502032maxresident)k
  0inputs+32104outputs (0major+130402minor)pagefaults 0swaps
  75.36user 10.14system 1:04.88elapsed 131%CPU (0avgtext+0avgdata 504784maxresident)k
  0inputs+32096outputs (0major+133487minor)pagefaults 0swaps
  73.12user 12.70system 1:03.68elapsed 134%CPU (0avgtext+0avgdata 505440maxresident)k
  0inputs+32096outputs (0major+132893minor)pagefaults 0swaps
  74.68user 10.08system 1:04.64elapsed 131%CPU (0avgtext+0avgdata 522384maxresident)k
  0inputs+32056outputs (0major+132502minor)pagefaults 0swaps
  75.59user 9.59system 1:03.46elapsed 134%CPU (0avgtext+0avgdata 509760maxresident)k
  0inputs+32072outputs (0major+133315minor)pagefaults 0swaps
  75.33user 10.12system 1:02.48elapsed 136%CPU (0avgtext+0avgdata 509568maxresident)k
  0inputs+32104outputs (0major+133788minor)pagefaults 0swaps

The following changes since commit 8e4e75383e43d6da2c16ec5286186a0d0569b0f8:

  codeparser: make var_expands actually hold useful information (2011-10-27 22:45:52 -0700)

are available in the git repository at:
  https://github.com/kergoth/bitbake codeparser-cleanup

Christopher Larson (2):
      codeparser: merge the nested python parsing classes
      codeparser: simplify how we compare the called node names

 lib/bb/codeparser.py |  157 +++++++++++++++++--------------------------------
 1 files changed, 55 insertions(+), 102 deletions(-)

Christopher Larson (2):
  codeparser: merge the nested python parsing classes
  codeparser: simplify how we compare the called node names

 lib/bb/codeparser.py |  157 +++++++++++++++++--------------------------------
 1 files changed, 55 insertions(+), 102 deletions(-)

-- 
1.7.7




             reply	other threads:[~2011-10-28 14:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-28 14:50 Christopher Larson [this message]
2011-10-28 14:50 ` [PATCH 1/2] codeparser: merge the nested python parsing classes Christopher Larson
2011-10-28 14:50 ` [PATCH 2/2] codeparser: simplify how we compare the called node names Christopher Larson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1319813177.git.kergoth@gmail.com \
    --to=kergoth@gmail.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.