All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Lock <josh@linux.intel.com>
To: bitbake-devel@lists.openembedded.org
Subject: [PATCH 0/9] Hob changes to match visual design
Date: Thu, 22 Mar 2012 16:31:05 -0700	[thread overview]
Message-ID: <cover.1332458487.git.josh@linux.intel.com> (raw)

Here's another set of patches to move Hob closer to the proposed design.

* Replace HobXpmLabelButtonBox with a new HobImageButton, this is a gtk.Button
subclass which is modelled after the buttons in gnome-disk-utility, where Belen
informs me the buttons on the main page for Layers, Recipes and Packages are
modelled after.
Since the first submission of this patch I've also ensured the buttons use an
alternative icon for the hover state per Shane's suggestion.

* Various tweaks to the LayerSelectionDialog per feedback from design:
  - title is Layers
  - add hover state icon to add button
  - follow Gnome HIG and only use a close button

* Per feedback on my last pull request and the design document changes to the
HobAltButton
  - bold text which uses a pale blue colour per visual design
  - modified 'Back to image configuration' buttons to have << prefix

* Unify implementation of the primary action button as a shared widget HobButton
and make use of it where we currently set up an orange button (this class should
be used for all primary buttons in a future patch).

Cheers,
Joshua

The following changes since commit 96e235a151fa04f5a15cd8b46f50a5852e2ba739:

  Hob: Revert interfaces of callbacks for layer_button, view_recipes_button, and view_packages_button. (2012-03-22 14:36:04 +0000)

are available in the git repository at:
  git://github.com/incandescant/bitbake josh/hob
  https://github.com/incandescant/bitbake/tree/josh/hob
  git://git.yoctoproject.org/poky-contrib josh/hob
  http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=josh/hob

Joshua Lock (9):
  lib/bb/ui/icons: add new icons for use in Hob, autocrop some existing
    ones
  lib/bb/ui/crumbs: replace HobXpmLabelButtonBox with HobImageButton
  lib/bb/ui/crumbs/builder: only show a close button on the Layer
    Selector
  lib/bb/ui/crumbs/hig: tweak 'Add Layer' button per visual design
  lib/bb/ui/crumbs: add colour for HobAltButton per visual design
  lib/bb/ui/crumbs: fix 'Back to image configuration' alt button text
  lib/bb/ui/crumbs/hobwidget: add HobButton widget for the primary
    action
  lib/bb/ui/crumbs: make use of HobButton for existing primary action
    buttons
  lib/bb/ui/crumbs/builder: change dialogue title to Layers

 lib/bb/ui/crumbs/builder.py                 |    5 +-
 lib/bb/ui/crumbs/hig.py                     |   27 +++--
 lib/bb/ui/crumbs/hobcolor.py                |    1 +
 lib/bb/ui/crumbs/hobwidget.py               |  148 ++++++++++++++++-----------
 lib/bb/ui/crumbs/imageconfigurationpage.py  |   52 ++++------
 lib/bb/ui/crumbs/imagedetailspage.py        |   11 +--
 lib/bb/ui/crumbs/packageselectionpage.py    |   13 +--
 lib/bb/ui/crumbs/recipeselectionpage.py     |   13 +--
 lib/bb/ui/icons/indicators/add-hover.png    |  Bin 0 -> 1212 bytes
 lib/bb/ui/icons/indicators/remove-hover.png |  Bin 0 -> 2809 bytes
 lib/bb/ui/icons/layers/layers_hover.png     |  Bin 5390 -> 5257 bytes
 lib/bb/ui/icons/packages/packages_hover.png |  Bin 7308 -> 7121 bytes
 lib/bb/ui/icons/recipe/recipe_hover.png     |  Bin 5003 -> 4866 bytes
 13 files changed, 136 insertions(+), 134 deletions(-)
 create mode 100644 lib/bb/ui/icons/indicators/add-hover.png
 create mode 100644 lib/bb/ui/icons/indicators/remove-hover.png

-- 
1.7.7.6




             reply	other threads:[~2012-03-22 23:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-22 23:31 Joshua Lock [this message]
2012-03-22 23:31 ` [PATCH 1/9] lib/bb/ui/icons: add new icons for use in Hob, autocrop some existing ones Joshua Lock
2012-03-22 23:31 ` [PATCH 2/9] lib/bb/ui/crumbs: replace HobXpmLabelButtonBox with HobImageButton Joshua Lock
2012-03-22 23:31 ` [PATCH 3/9] lib/bb/ui/crumbs/builder: only show a close button on the Layer Selector Joshua Lock
2012-03-22 23:31 ` [PATCH 4/9] lib/bb/ui/crumbs/hig: tweak 'Add Layer' button per visual design Joshua Lock
2012-03-22 23:31 ` [PATCH 5/9] lib/bb/ui/crumbs: add colour for HobAltButton " Joshua Lock
2012-03-22 23:31 ` [PATCH 6/9] lib/bb/ui/crumbs: fix 'Back to image configuration' alt button text Joshua Lock
2012-03-22 23:31 ` [PATCH 7/9] lib/bb/ui/crumbs/hobwidget: add HobButton widget for the primary action Joshua Lock
2012-03-22 23:31 ` [PATCH 8/9] lib/bb/ui/crumbs: make use of HobButton for existing primary action buttons Joshua Lock
2012-03-22 23:31 ` [PATCH 9/9] lib/bb/ui/crumbs/builder: change dialogue title to Layers Joshua Lock
2012-03-23  8:56 ` [PATCH 0/9] Hob changes to match visual design Wang, Shane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1332458487.git.josh@linux.intel.com \
    --to=josh@linux.intel.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.