* [PATCH 0/2] SDK related misc changes
@ 2012-06-30 0:22 Mark Hatle
2012-06-30 0:22 ` [PATCH 1/2] libc-common: Allow debug package to append, not set depends Mark Hatle
2012-06-30 0:22 ` [PATCH 2/2] package.bbclass: Allow a package to skip per file dependency generation Mark Hatle
0 siblings, 2 replies; 5+ messages in thread
From: Mark Hatle @ 2012-06-30 0:22 UTC (permalink / raw)
To: openembedded-core
Two minor changes related to SDK generations. One is a bug fix, the other
allows for better control over the per-file dependency generation.
The following changes since commit 54429dfcca0e35a3aeaa78e509240b87d6a8f4ac:
mklibs-native: Upgrade to 0.1.34 (2012-06-29 13:21:19 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib mhatle/misc
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=mhatle/sdk
Mark Hatle (2):
libc-common: Allow debug package to append, not set depends
package.bbclass: Allow a package to skip per file dependency
generation
meta/classes/libc-common.bbclass | 6 +++---
meta/classes/package.bbclass | 3 +++
2 files changed, 6 insertions(+), 3 deletions(-)
--
1.7.3.4
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/2] libc-common: Allow debug package to append, not set depends 2012-06-30 0:22 [PATCH 0/2] SDK related misc changes Mark Hatle @ 2012-06-30 0:22 ` Mark Hatle 2012-07-02 20:26 ` Phil Blundell 2012-06-30 0:22 ` [PATCH 2/2] package.bbclass: Allow a package to skip per file dependency generation Mark Hatle 1 sibling, 1 reply; 5+ messages in thread From: Mark Hatle @ 2012-06-30 0:22 UTC (permalink / raw) To: openembedded-core Signed-off-by: Mark Hatle <mark.hatle@windriver.com> --- meta/classes/libc-common.bbclass | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/classes/libc-common.bbclass b/meta/classes/libc-common.bbclass index 9b91f0a..8145d64 100644 --- a/meta/classes/libc-common.bbclass +++ b/meta/classes/libc-common.bbclass @@ -29,7 +29,7 @@ python populate_packages_prepend () { d.setVar('PKG_'+bpn+'-dev', 'libc6-dev') d.setVar('PKG_'+bpn+'-dbg', 'libc6-dbg') # For backward compatibility with old -dbg package - d.setVar('RPROVIDES_' + bpn + '-dbg', 'libc-dbg') - d.setVar('RCONFLICTS_' + bpn + '-dbg', 'libc-dbg') - d.setVar('RREPLACES_' + bpn + '-dbg', 'libc-dbg') + d.appendVar('RPROVIDES_' + bpn + '-dbg', ' libc-dbg') + d.appendVar('RCONFLICTS_' + bpn + '-dbg', ' libc-dbg') + d.appendVar('RREPLACES_' + bpn + '-dbg', ' libc-dbg') } -- 1.7.3.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] libc-common: Allow debug package to append, not set depends 2012-06-30 0:22 ` [PATCH 1/2] libc-common: Allow debug package to append, not set depends Mark Hatle @ 2012-07-02 20:26 ` Phil Blundell 2012-07-02 20:37 ` Mark Hatle 0 siblings, 1 reply; 5+ messages in thread From: Phil Blundell @ 2012-07-02 20:26 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Fri, 2012-06-29 at 19:22 -0500, Mark Hatle wrote: > Signed-off-by: Mark Hatle <mark.hatle@windriver.com> This patch has no checkin message (other than the subject line) which is contrary to our fine guidelines. What bug is this fixing? Also, the subject line talks about "depends" but the patch actually modifies the way that RPROVIDES/RCONFLICTS/RREPLACES are set and I'm not sure that most people would class those as "depends". p. > --- > meta/classes/libc-common.bbclass | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meta/classes/libc-common.bbclass b/meta/classes/libc-common.bbclass > index 9b91f0a..8145d64 100644 > --- a/meta/classes/libc-common.bbclass > +++ b/meta/classes/libc-common.bbclass > @@ -29,7 +29,7 @@ python populate_packages_prepend () { > d.setVar('PKG_'+bpn+'-dev', 'libc6-dev') > d.setVar('PKG_'+bpn+'-dbg', 'libc6-dbg') > # For backward compatibility with old -dbg package > - d.setVar('RPROVIDES_' + bpn + '-dbg', 'libc-dbg') > - d.setVar('RCONFLICTS_' + bpn + '-dbg', 'libc-dbg') > - d.setVar('RREPLACES_' + bpn + '-dbg', 'libc-dbg') > + d.appendVar('RPROVIDES_' + bpn + '-dbg', ' libc-dbg') > + d.appendVar('RCONFLICTS_' + bpn + '-dbg', ' libc-dbg') > + d.appendVar('RREPLACES_' + bpn + '-dbg', ' libc-dbg') > } ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] libc-common: Allow debug package to append, not set depends 2012-07-02 20:26 ` Phil Blundell @ 2012-07-02 20:37 ` Mark Hatle 0 siblings, 0 replies; 5+ messages in thread From: Mark Hatle @ 2012-07-02 20:37 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On 7/2/12 3:26 PM, Phil Blundell wrote: > On Fri, 2012-06-29 at 19:22 -0500, Mark Hatle wrote: >> Signed-off-by: Mark Hatle <mark.hatle@windriver.com> > > This patch has no checkin message (other than the subject line) which is > contrary to our fine guidelines. What bug is this fixing? Exactly what the subject is. The libc-common.bbclass needs to be able to append the RPROVIDES, RCONFLICT_, RREPLACES_ and not just -set- them. The guidelines say that if the subject and code explain what is being changed, then repeating the subject is frowned upon. > Also, the subject line talks about "depends" but the patch actually > modifies the way that RPROVIDES/RCONFLICTS/RREPLACES are set and I'm not > sure that most people would class those as "depends". Sorry, terminology then.. I consider these all depends. I can reword it, but it was clear to me when I wrote it that the subject and patch itself explained what was happening. --Mark > p. > >> --- >> meta/classes/libc-common.bbclass | 6 +++--- >> 1 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/meta/classes/libc-common.bbclass b/meta/classes/libc-common.bbclass >> index 9b91f0a..8145d64 100644 >> --- a/meta/classes/libc-common.bbclass >> +++ b/meta/classes/libc-common.bbclass >> @@ -29,7 +29,7 @@ python populate_packages_prepend () { >> d.setVar('PKG_'+bpn+'-dev', 'libc6-dev') >> d.setVar('PKG_'+bpn+'-dbg', 'libc6-dbg') >> # For backward compatibility with old -dbg package >> - d.setVar('RPROVIDES_' + bpn + '-dbg', 'libc-dbg') >> - d.setVar('RCONFLICTS_' + bpn + '-dbg', 'libc-dbg') >> - d.setVar('RREPLACES_' + bpn + '-dbg', 'libc-dbg') >> + d.appendVar('RPROVIDES_' + bpn + '-dbg', ' libc-dbg') >> + d.appendVar('RCONFLICTS_' + bpn + '-dbg', ' libc-dbg') >> + d.appendVar('RREPLACES_' + bpn + '-dbg', ' libc-dbg') >> } > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] package.bbclass: Allow a package to skip per file dependency generation 2012-06-30 0:22 [PATCH 0/2] SDK related misc changes Mark Hatle 2012-06-30 0:22 ` [PATCH 1/2] libc-common: Allow debug package to append, not set depends Mark Hatle @ 2012-06-30 0:22 ` Mark Hatle 1 sibling, 0 replies; 5+ messages in thread From: Mark Hatle @ 2012-06-30 0:22 UTC (permalink / raw) To: openembedded-core Most of the time skipping per file dependency generation is a bad idea, but when building a nativesdk or similar you may be required to pickup host dependencies. These host dependencies can not always be reconciled within the scope of other nativesdk components, so if we skip them we can facilitate this unique situation. Signed-off-by: Mark Hatle <mark.hatle@windriver.com> --- meta/classes/package.bbclass | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass index 10c2f0a..db7b9ca 100644 --- a/meta/classes/package.bbclass +++ b/meta/classes/package.bbclass @@ -1154,6 +1154,9 @@ RPMDEPS = "${STAGING_LIBDIR_NATIVE}/rpm/bin/rpmdeps-oecore --macros ${STAGING_LI python package_do_filedeps() { import re + if d.getVar('SKIP_FILEDEPS', True) == '1': + return + pkgdest = d.getVar('PKGDEST', True) packages = d.getVar('PACKAGES', True) -- 1.7.3.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-07-02 20:49 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-06-30 0:22 [PATCH 0/2] SDK related misc changes Mark Hatle 2012-06-30 0:22 ` [PATCH 1/2] libc-common: Allow debug package to append, not set depends Mark Hatle 2012-07-02 20:26 ` Phil Blundell 2012-07-02 20:37 ` Mark Hatle 2012-06-30 0:22 ` [PATCH 2/2] package.bbclass: Allow a package to skip per file dependency generation Mark Hatle
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.