From: Alexey Shumkin <Alex.Crezoff@gmail.com>
To: git@vger.kernel.org
Cc: Alexey Shumkin <Alex.Crezoff@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Krzysztof Mazur <krzysiek@podlesie.net>
Subject: [PATCH resent] send-email: Honor multi-part email messages
Date: Fri, 25 Jan 2013 19:28:53 +0400 [thread overview]
Message-ID: <cover.1359126360.git.Alex.Crezoff@gmail.com> (raw)
Let's try to involve Krzysztof Mazur <krzysiek@podlesie.net>
who have met the similar problem recently
(according to this thread http://thread.gmane.org/gmane.comp.version-control.git/208297/focus=208310)
I recitate myself:
>Well, as I understand "current" algorithm:
>1. It assumes that file is one-part email message
>2. Function searches non-ASCII characters in Subject header
>3. If none then it looks non-ASCII characters at message body
>
>my changes are to skip looking at message body of a multi-part
>message as it has parts with their own Content-Type headers
>
>The said above in details:
>1. To set flag when we meet Content-Type: multipart/mixed header
>2. After we processed all headers and did not found non-ASCII characters
>in a Subject we take a look at this flag and exit with 0
>if it is a multi-part message
>>I think your patch is wrong. What happens when we see a Subject:
>>line with a non-ascii on it that causes an early return of the loop
>>before your new code has a chance to see Content-Type: header?
This function is used to determine "broken" (non-ASCII) headers (to be encode them)
The problem is if "Subject" is not broken, but message body contains non-ASCII chars,
subject is marked as broken and encoded again.
P.S.
To involved: the beginning of thread is here http://thread.gmane.org/gmane.comp.version-control.git/181743
Alexey Shumkin (1):
send-email: Honor multi-part email messages
git-send-email.perl | 5 ++++
t/t9001-send-email.sh | 66 +++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 71 insertions(+)
--
1.8.1.1.10.g9255f3f
next reply other threads:[~2013-01-25 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 15:28 Alexey Shumkin [this message]
2013-01-25 15:28 ` [PATCH] send-email: Honor multi-part email messages Alexey Shumkin
2013-01-25 17:47 ` Krzysztof Mazur
2013-01-25 22:24 ` Jeff King
2013-01-25 18:14 ` [PATCH resent] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1359126360.git.Alex.Crezoff@gmail.com \
--to=alex.crezoff@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=krzysiek@podlesie.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.