All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Spelvin <linux@horizon.com>
To: linux-serial@vger.kernel.org, peter@hurleysoftware.com
Cc: linux@horizon.com, linux-kernel@vger.kernel.org, giometti@linux.it
Subject: [PATCH 0/7] 3.8-rc regression with pps-ldisc due to 70ece7a731
Date: Fri, 8 Feb 2013 02:05:40 -0500	[thread overview]
Message-ID: <cover.1360307140.git.linux@horizon.com> (raw)

The standard N_TTY line discipline used to not use the tty->disc_data
field, so N_PPS felt free to use it.  That has now changed, requiring
that N_PPS use a different method to find its private data.

(In the current, buggy, state, N_PPS follows a wild pointer and explodes
in an interrupt hander as soon as a pulse actually arrives.)

Strictly speaking, only patches 5 and 6 are the bugfix proper; the
rest are various cleanups enabled by the looser coupling of the
line disciplines.

George Spelvin (4):
  pps: Additional cleanups in uart_handle_dcd_change
  pps: Add pps_lookup_dev() function
  pps: Use pps_lookup_dev to reduce ldisc coupling
  tty/tty_ldisc.c: use test_and_clear_bit in tty_ldisc_close

Peter Hurley (3):
  pps: Decouple N_PPS from N_TTY
  pps: Don't crash the machine when exiting will do
  tty: Remove ancient hardpps()

 drivers/pps/clients/pps-ldisc.c     | 33 +++++++++++++++++++++++----------
 drivers/pps/pps.c                   | 35 +++++++++++++++++++++++++++++++++++
 drivers/staging/speakup/selection.c |  1 +
 drivers/tty/amiserial.c             |  5 -----
 drivers/tty/n_tty.c                 |  3 ++-
 drivers/tty/serial/serial_core.c    | 24 +++++++-----------------
 drivers/tty/tty_buffer.c            |  1 +
 drivers/tty/tty_ldisc.c             |  3 +--
 include/linux/pps_kernel.h          | 17 ++++++++++++++---
 include/linux/serial_core.h         |  1 -
 include/linux/tty_ldisc.h           | 11 ++++-------
 11 files changed, 88 insertions(+), 46 deletions(-)

-- 
1.8.1.2


             reply	other threads:[~2013-02-08  9:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-08  7:05 George Spelvin [this message]
2013-02-06 15:55 ` [PATCH 3/7] pps: Don't crash the machine when exiting will do Peter Hurley
2013-02-06 15:55 ` [PATCH 4/7] tty: Remove ancient hardpps() Peter Hurley
2013-02-08  5:45 ` [PATCH 1/7] pps: Decouple N_PPS from N_TTY George Spelvin
2013-02-08  6:06 ` [PATCH 2/7] pps: Additional cleanups in uart_handle_dcd_change George Spelvin
2013-02-08  6:38 ` [PATCH 5/7] pps: Add pps_lookup_dev() function George Spelvin
2013-02-08  6:48 ` [PATCH 6/7] pps: Use pps_lookup_dev to reduce ldisc coupling George Spelvin
2013-02-08  6:50 ` [PATCH 7/7] tty/tty_ldisc.c: use test_and_clear_bit in tty_ldisc_close George Spelvin
2013-02-08 23:36 ` [PATCH 0/7] 3.8-rc regression with pps-ldisc due to 70ece7a731 Greg KH
2013-02-09  0:22   ` George Spelvin
2013-02-09  7:05   ` George Spelvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1360307140.git.linux@horizon.com \
    --to=linux@horizon.com \
    --cc=giometti@linux.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.