All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann Droneaud <ydroneaud@opteya.com>
To: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Cc: Yann Droneaud <ydroneaud@opteya.com>
Subject: [PATCH 00/15] Use test_config
Date: Sun, 24 Mar 2013 22:05:59 +0100	[thread overview]
Message-ID: <cover.1364158574.git.ydroneaud@opteya.com> (raw)
In-Reply-To: <7vvc8j8p9m.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vvc8j8p9m.fsf@alter.siamese.dyndns.org>

Please find some patches to use test_config/test_unconfig

Instead of using construct such as:
   test_when_finished "git config --unset <key>"
   git config <key> <value>
uses
   test_config <key> <value>
The latter takes care of removing <key> at the end of the test.
    
Additionally, instead of
   git config <key> ""
or
   git config --unset <key>
 uses
   test_unconfig <key>
The latter doesn't failed if <key> is not defined.

Patch "t7600: use test_config to set/unset git config variables"
is more important than the other and must be carefully reviewed
regarded to the --no-log --no-ff behavior.

Others patches are fairly simple.

Testsuite results are the same after the patches.
Tested against master, 7b592fadf1e23b10b913e0771b9f711770597266

Yann Droneaud (15):
  t4018: remove test_config implementation
  t7810: remove test_config implementation
  t7811: remove test_config implementation
  t3400: use test_config to set/unset git config variables
  t4304: use test_config to set/unset git config variables
  t4034: use test_config/test_unconfig to set/unset git config
    variables
  t4202: use test_config/test_unconfig to set/unset git config
    variables
  t5520: use test_config to set/unset git config variables
  t5541: use test_config to set/unset git config variables
  t7500: use test_config to set/unset git config variables
  t7502: use test_config to set/unset git config variables
  t7508: use test_config to set/unset git config variables
  t7600: use test_config to set/unset git config variables
  t9500: use test_config to set/unset git config variables
  t7502: remove clear_config

 t/t3400-rebase.sh                      |  3 +-
 t/t3404-rebase-interactive.sh          |  3 +-
 t/t4018-diff-funcname.sh               |  5 ---
 t/t4034-diff-words.sh                  |  7 ++--
 t/t4202-log.sh                         | 28 +++++-----------
 t/t5520-pull.sh                        | 12 +++----
 t/t5541-http-push.sh                   |  3 +-
 t/t7500-commit.sh                      |  6 ++--
 t/t7502-commit.sh                      | 40 +++++------------------
 t/t7508-status.sh                      | 46 +++++++++-----------------
 t/t7600-merge.sh                       | 60 +++++++++++++++-------------------
 t/t7810-grep.sh                        |  5 ---
 t/t7811-grep-open.sh                   |  5 ---
 t/t9500-gitweb-standalone-no-errors.sh |  3 +-
 14 files changed, 72 insertions(+), 154 deletions(-)

-- 
1.7.11.7

  reply	other threads:[~2013-03-24 21:07 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 14:55 git merge <tag> behavior Yann Droneaud
2013-03-19 16:19 ` Junio C Hamano
2013-03-19 17:54   ` Re* " Junio C Hamano
2013-04-01 19:57     ` [PATCH 0/3] Merging an annotated tag object Junio C Hamano
2013-04-01 19:57       ` [PATCH 1/3] merge: a random object may not necssarily be a commit Junio C Hamano
2013-04-01 22:51         ` Yann Droneaud
2013-04-02  5:30         ` Jeff King
2013-04-02 15:02           ` Junio C Hamano
2013-04-02 15:03             ` Jeff King
2013-04-01 19:57       ` [PATCH 2/3] t6200: use test_config/test_unconfig Junio C Hamano
2013-04-01 19:57       ` [PATCH 3/3] t6200: test message for merging of an annotated tag Junio C Hamano
2013-03-20 17:53   ` [PATCH] Documentation: merging a tag is a special case Yann Droneaud
2013-03-20 18:54     ` Jonathan Nieder
2013-03-20 19:07     ` Junio C Hamano
2013-03-21 19:50       ` Junio C Hamano
2013-03-21 19:56         ` Jonathan Nieder
2013-03-21 20:10           ` Junio C Hamano
2013-03-21 20:39             ` Jonathan Nieder
2013-03-21 21:47             ` Yann Droneaud
2013-03-21 21:57               ` [PATCH v2] " Yann Droneaud
2013-03-21 22:41                 ` Jonathan Nieder
2013-03-20 18:04   ` git merge <tag> behavior Yann Droneaud
2013-03-20 18:12     ` Yann Droneaud
2013-03-20 18:46       ` Junio C Hamano
2013-03-21 20:31 ` Max Nanasy
2013-03-22  9:16   ` Yann Droneaud
2013-03-22 10:09     ` [PATCH] t7600: test merge configuration override Yann Droneaud
2013-03-22 14:47       ` Junio C Hamano
2013-03-24 21:05         ` Yann Droneaud [this message]
2013-03-24 21:06           ` [PATCH 01/15] t4018: remove test_config implementation Yann Droneaud
2013-03-24 21:06           ` [PATCH 02/15] t7810: " Yann Droneaud
2013-03-24 21:06           ` [PATCH 03/15] t7811: " Yann Droneaud
2013-03-24 21:06           ` [PATCH 04/15] t3400: use test_config to set/unset git config variables Yann Droneaud
2013-03-24 21:06           ` [PATCH 05/15] t4304: " Yann Droneaud
2013-03-24 21:06           ` [PATCH 06/15] t4034: use test_config/test_unconfig " Yann Droneaud
2013-03-24 21:06           ` [PATCH 07/15] t4202: " Yann Droneaud
2013-03-24 21:06           ` [PATCH 08/15] t5520: use test_config " Yann Droneaud
2013-03-24 21:06           ` [PATCH 09/15] t5541: " Yann Droneaud
2013-03-24 21:06           ` [PATCH 10/15] t7500: " Yann Droneaud
2013-03-24 21:06           ` [PATCH 11/15] t7502: " Yann Droneaud
2013-03-24 21:06           ` [PATCH 12/15] t7508: " Yann Droneaud
2013-03-24 21:06           ` [PATCH 13/15] t7600: " Yann Droneaud
2013-03-24 21:06           ` [PATCH 14/15] t9500: " Yann Droneaud
2013-03-24 21:06           ` [PATCH 15/15] t7502: remove clear_config Yann Droneaud
2013-03-27 15:04             ` Junio C Hamano
2013-03-27 15:05           ` [PATCH 00/15] Use test_config Junio C Hamano
2013-03-27 16:19             ` Yann Droneaud
2013-03-22 15:23     ` git merge <tag> behavior Junio C Hamano
2013-03-22 10:57 ` [PATCH] t7600: merge tag shoud create a merge commit y
2013-03-22 10:57 ` y
2013-03-22 14:48   ` Junio C Hamano
2013-03-22 14:56     ` Yann Droneaud
2013-03-22 15:05       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1364158574.git.ydroneaud@opteya.com \
    --to=ydroneaud@opteya.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.