All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Amit Shah <amit.shah@redhat.com>,
	Virtualization List <virtualization@lists.linux-foundation.org>
Subject: [PATCH v2 0/2]  virtio: console: add locking around control out-vq
Date: Fri, 29 Mar 2013 16:30:06 +0530	[thread overview]
Message-ID: <cover.1364554596.git.amit.shah@redhat.com> (raw)

The in-vq operations were protected by a lock, but the out-vq
operations were not.  This caused panics / errors as described in
patch 2.  Fix that.

The first patch renames the existing cvq_lock to c_ivq_lock to match
c_ivq.  The second patch introduces the c_ovq_lock for the c_ovq.

Please apply.  I also believe this is a candidate for stable.

v2:
 * Use spin_lock instead of spin_lock_irq.  Pointed out by Wanlong
 Gao.

Amit Shah (2):
  virtio: console: rename cvq_lock to c_ivq_lock
  virtio: console: add locking around c_ovq operations

 drivers/char/virtio_console.c | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

-- 
1.8.1.4

             reply	other threads:[~2013-03-29 11:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-29 11:00 Amit Shah [this message]
2013-03-29 11:00 ` [PATCH v2 1/2] virtio: console: rename cvq_lock to c_ivq_lock Amit Shah
2013-03-29 11:04   ` Wanlong Gao
2013-03-29 11:00 ` [PATCH v2 2/2] virtio: console: add locking around c_ovq operations Amit Shah
2013-03-29 11:05   ` Wanlong Gao
2013-03-30  3:58   ` Rusty Russell
2013-04-02  5:26     ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1364554596.git.amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.