All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Rast <trast@inf.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: <git@vger.kernel.org>, Fredrik Gustafsson <iveqy@iveqy.com>,
	Jeff King <peff@peff.net>
Subject: [PATCH v4 0/8] --valgrind improvements
Date: Sun, 23 Jun 2013 20:12:51 +0200	[thread overview]
Message-ID: <cover.1372010917.git.trast@inf.ethz.ch> (raw)

> Please hold off; Fredrik found an issue with the test automation that
> bisects to "verbose mode for only tests matching a pattern"; when
> running with the 'test' target (not with prove however), the suite
> reports
> 
>   failed test(s):  
> 
>   fixed   0
>   success 9788
>   failed  2
>   broken  69
>   total   9989
> 
> Even worse, I botched a rebase that makes the commit before --
> "self-test that --verbose works" untestable.  I'm pretty sure that it
> has the same problem, too, though I'm still investigating the actual
> issue.

This should fix it.  The culprit was that the test suite generates
.counts files when not under $TEST_HARNESS, and these are seen and
reported by aggregate-results.  So this version changes 4/8 to set
TEST_HARNESS, instead of unsetting it.

Sorry for the trouble.


Thomas Rast (8):
  test-lib: enable MALLOC_* for the actual tests
  test-lib: refactor $GIT_SKIP_TESTS matching
  test-lib: rearrange start/end of test_expect_* and test_skip
  test-lib: self-test that --verbose works
  test-lib: verbose mode for only tests matching a pattern
  test-lib: valgrind for only tests matching a pattern
  test-lib: allow prefixing a custom string before "ok N" etc.
  test-lib: support running tests under valgrind in parallel

 t/README                |  10 ++
 t/t0000-basic.sh        |  61 +++++++++++-
 t/test-lib-functions.sh |   6 +-
 t/test-lib.sh           | 246 ++++++++++++++++++++++++++++++++++++++----------
 t/valgrind/valgrind.sh  |   3 +
 5 files changed, 274 insertions(+), 52 deletions(-)

-- 
1.8.3.1.727.gcbe3af3

             reply	other threads:[~2013-06-23 18:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-23 18:12 Thomas Rast [this message]
2013-06-23 18:12 ` [PATCH v4 1/8] test-lib: enable MALLOC_* for the actual tests Thomas Rast
2013-06-23 18:12 ` [PATCH v4 2/8] test-lib: refactor $GIT_SKIP_TESTS matching Thomas Rast
2013-06-23 18:12 ` [PATCH v4 3/8] test-lib: rearrange start/end of test_expect_* and test_skip Thomas Rast
2013-06-23 18:12 ` [PATCH v4 4/8] test-lib: self-test that --verbose works Thomas Rast
2013-06-23 18:12 ` [PATCH v4 5/8] test-lib: verbose mode for only tests matching a pattern Thomas Rast
2013-06-23 18:12 ` [PATCH v4 6/8] test-lib: valgrind " Thomas Rast
2013-06-23 18:12 ` [PATCH v4 7/8] test-lib: allow prefixing a custom string before "ok N" etc Thomas Rast
2013-06-23 18:12 ` [PATCH v4 8/8] test-lib: support running tests under valgrind in parallel Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1372010917.git.trast@inf.ethz.ch \
    --to=trast@inf.ethz.ch \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=iveqy@iveqy.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.