From: Thomas Rast <trast@inf.ethz.ch>
To: <git@vger.kernel.org>
Cc: "Dale R. Worley" <worley@alum.mit.edu>
Subject: [PATCH 0/2] open() error checking
Date: Fri, 12 Jul 2013 10:58:34 +0200 [thread overview]
Message-ID: <cover.1373618940.git.trast@inf.ethz.ch> (raw)
#1 is Dale's suggested change. Dale, to include it we'd need your
Signed-off-by as per Documentation/SubmittingPatches.
#2 is a similar error-checking fix; I reviewed 'git grep "\bopen\b"'
and found one case where the return value was obviously not tested.
The corresponding Windows code path has the same problem, but I dare
not touch it; perhaps someone from the Windows side can look into it?
I originally had a four-patch series to open 0/1/2 from /dev/null, but
then I noticed that this was shot down in 2008:
http://thread.gmane.org/gmane.comp.version-control.git/93605/focus=93896
Do you want to resurrect this?
The worst part about it is that because we don't have a stderr to rely
on, we can't simply die("stop playing mind games").
Dale R. Worley (1):
git_mkstemps: correctly test return value of open()
Thomas Rast (1):
run-command: dup_devnull(): guard against syscalls failing
run-command.c | 5 ++++-
wrapper.c | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
--
1.8.3.2.998.g1d087bc
next reply other threads:[~2013-07-12 8:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 8:58 Thomas Rast [this message]
2013-07-12 8:58 ` [PATCH 1/2] git_mkstemps: correctly test return value of open() Thomas Rast
2013-07-16 9:37 ` Thomas Rast
2013-07-17 19:29 ` Junio C Hamano
2013-07-18 12:32 ` Drew Northup
2013-07-18 17:46 ` Junio C Hamano
2013-07-18 17:47 ` Junio C Hamano
2013-07-18 20:32 ` Dale R. Worley
2013-07-18 20:49 ` Eric Sunshine
2013-07-18 20:54 ` Junio C Hamano
2013-07-18 22:46 ` Dale R. Worley
2013-07-18 23:23 ` Junio C Hamano
2013-07-18 23:29 ` Dale R. Worley
2013-07-12 8:58 ` [PATCH 2/2] run-command: dup_devnull(): guard against syscalls failing Thomas Rast
2013-07-12 17:29 ` [PATCH 0/2] open() error checking Junio C Hamano
2013-07-16 9:25 ` Thomas Rast
2013-07-16 9:27 ` [PATCH 1/2] daemon/shell: refactor redirection of 0/1/2 from /dev/null Thomas Rast
2013-07-16 9:27 ` [PATCH 2/2] git: ensure 0/1/2 are open in main() Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1373618940.git.trast@inf.ethz.ch \
--to=trast@inf.ethz.ch \
--cc=git@vger.kernel.org \
--cc=worley@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.