From: Milosz Tanski <milosz@adfin.com>
To: ceph-devel@vger.kernel.org
Cc: sage@inktank.com, zheng.z.yan@intel.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] fscache fixes for ceph
Date: Tue, 3 Sep 2013 19:10:24 -0400 [thread overview]
Message-ID: <cover.1378249347.git.milosz@adfin.com> (raw)
On the whole the current iteration of FSCache on Ceph has been quite stable for
me. We've had it deployed on 4 clients running for a week in a row. I did run
into two small issues.
First one, I wasn't checking if the page was marked with private_2 before
asking FSCache to write to it. I've never seen this before and I only seen this
issue once.
The second issue is similar to what I was seeing before with pages marked
private_2 when we return them to the page cache. In this case the start_read()
in addr.c was returning the pages in the error path of the code. I have plugged
that issue. I only seen this one a handful of times across all clients.
As usual please apply the changes from repo located at:
https://bitbucket.org/adfin/linux-fs.git branch: wip-ceph-fscache
Cheers,
- Milosz
Milosz Tanski (2):
ceph: ceph_readpage_to_fscache didn't check if marked
ceph: page still marked private_2
fs/ceph/addr.c | 1 +
fs/ceph/cache.c | 3 +++
fs/ceph/cache.h | 14 +++++++++++++-
3 files changed, 17 insertions(+), 1 deletion(-)
--
1.8.1.2
next reply other threads:[~2013-09-03 23:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 23:10 Milosz Tanski [this message]
2013-09-03 23:11 ` [PATCH 1/2] ceph: ceph_readpage_to_fscache didn't check if marked Milosz Tanski
2013-09-03 23:11 ` [PATCH 2/2] ceph: page still marked private_2 Milosz Tanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1378249347.git.milosz@adfin.com \
--to=milosz@adfin.com \
--cc=ceph-devel@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@inktank.com \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.