All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: rjw@sisk.pl
Cc: linaro-kernel@lists.linaro.org, patches@linaro.org,
	cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, srivatsa.bhat@linux.vnet.ibm.com,
	nicolas.pitre@linaro.org, Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH 0/4] CPUFreq stats: Bug fixes
Date: Thu, 26 Sep 2013 15:59:50 +0530	[thread overview]
Message-ID: <cover.1380190886.git.viresh.kumar@linaro.org> (raw)

Hi Rafael,

I know you asked me not to send any more patches before the earlier ones get
into kernel. I got to this as Nicolas Pitre required to send few CPUFreq patches
for ARM's big LITTLE In-Kernel-Switcher. And within linaro we have hacked these
bugs in a bad way..

Because of his dependency I am forced to send these.. These aren't introduced
recently and so they can be included in 3.13.

There are several problems/bugs in cpufreq-stats specially with cpufreq drivers
as modules and suspend/resume path. These are mentioned well in changelogs.

These are tested over my thinkpad (acpi-cpufreq) in following way:
[1] offline+online all CPUs except boot cpu in a while loop
[2] then do suspend resume
[3] repeat [1] and [2] several times.

No issues found..

Also tested on my exynos board:
- Added cpufreq_unregister/register while loop in exynos-cpufreq.c so that we
  continuously register/unregister driver... Stats were working fine now..
- Compile cpufreq-stats as module and insert/remove it several times after
  removing above hack (as that doesn't let linux boot :) )..

@Srivatsa: You also have fairly good idea of cpufreq now, so please give some
time to review this :)

@Nico: Can you remove the hacky code from IKS tree and test these instead to see
if we still have any issues?

--
viresh

Viresh Kumar (4):
  cpufreq: stats: handle cpufreq_unregister_driver() and suspend/resume
    properly
  cpufreq: stats: remove hotplug notifiers
  cpufreq: stats: free table and remove sysfs entry in a single routine
  cpufreq: stats: create sysfs entries when cpufreq_stats is a module

 drivers/cpufreq/cpufreq.c       |   5 ++
 drivers/cpufreq/cpufreq_stats.c | 109 ++++++++++++++++++----------------------
 include/linux/cpufreq.h         |   2 +
 3 files changed, 55 insertions(+), 61 deletions(-)

-- 
1.7.12.rc2.18.g61b472e

             reply	other threads:[~2013-09-26 10:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26 10:29 Viresh Kumar [this message]
2013-09-26 10:29 ` [PATCH 1/4] cpufreq: stats: handle cpufreq_unregister_driver() and suspend/resume properly Viresh Kumar
2013-09-26 10:29 ` [PATCH 2/4] cpufreq: stats: remove hotplug notifiers Viresh Kumar
2013-09-26 10:29 ` [PATCH 3/4] cpufreq: stats: free table and remove sysfs entry in a single routine Viresh Kumar
2013-09-26 10:29 ` [PATCH 4/4] cpufreq: stats: create sysfs entries when cpufreq_stats is a module Viresh Kumar
2013-10-22 21:06 ` [PATCH 0/4] CPUFreq stats: Bug fixes Nicolas Pitre
2013-10-23  4:23   ` Viresh Kumar
2014-01-06 21:02 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1380190886.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=cpufreq@vger.kernel.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=patches@linaro.org \
    --cc=rjw@sisk.pl \
    --cc=srivatsa.bhat@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.