All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <dborkman@redhat.com>
To: davem@davemloft.net
Cc: shemminger@networkplumber.org, fweimer@redhat.com,
	netdev@vger.kernel.org
Subject: [PATCH net-next 0/6] prandom fixes/improvements
Date: Mon, 11 Nov 2013 12:20:31 +0100	[thread overview]
Message-ID: <cover.1384160397.git.dborkman@redhat.com> (raw)

Hi Dave,

It would be great if you could still consider this series that fixes and
improves prandom for 3.13. We have sent it to netdev as prandom() originally
came from net/core/utils.c and networking is its main user. For a detailled
description, please see individual patches.

For patch 3 in this series, there will be a minor merge conflict with the
random tree that is for 3.13. See below how to resolve it.

====
Hannes says: on merge with the random tree I would suggest to resolve the
conflict in drivers/char/random.c like this:

if (r->entropy_total > 128) {
	r->initialized = 1;
	r->entropy_total = 0;
	if (r == &nonblocking_pool) {
		prandom_reseed_late();
		pr_notice("random: %s pool is initialized\n",
			  r->name);
	}
}

So it won't generate a warning if DEBUG_RANDOM_BOOT gets activated.
====

Patch 1 should probably also go to -stable.

Set tested on 32 and 64 bit machines.

Thanks a lot!

Ref. original discussion: http://patchwork.ozlabs.org/patch/289951/

Daniel Borkmann (4):
  random32: fix off-by-one in seeding requirement
  random32: move rnd_state to linux/random.h
  random32: upgrade taus88 generator to taus113 from errata paper
  random32: add test cases for taus113 implementation

Hannes Frederic Sowa (2):
  random32: add periodic reseeding
  random32: add prandom_reseed_late() and call when nonblocking pool
    becomes initialized

 drivers/char/random.c       |   5 +-
 include/linux/random.h      |  14 +-
 include/uapi/linux/random.h |   7 -
 lib/Kconfig                 |   7 +
 lib/random32.c              | 307 +++++++++++++++++++++++++++++++++++++++-----
 5 files changed, 294 insertions(+), 46 deletions(-)

-- 
1.8.3.1

             reply	other threads:[~2013-11-11 11:20 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11 11:20 Daniel Borkmann [this message]
2013-11-11 11:20 ` [PATCH net-next 1/6] random32: fix off-by-one in seeding requirement Daniel Borkmann
2013-11-11 11:20 ` [PATCH net-next 2/6] random32: add periodic reseeding Daniel Borkmann
2013-11-11 11:20 ` [PATCH net-next 3/6] random32: add prandom_reseed_late() and call when nonblocking pool becomes initialized Daniel Borkmann
2013-11-11 13:43   ` Theodore Ts'o
2013-11-12  0:03     ` Hannes Frederic Sowa
2013-11-12  0:37       ` Karl Beldan
2013-11-12  0:37         ` Karl Beldan
2013-11-12  8:36         ` Johannes Berg
2013-11-12  8:36           ` Johannes Berg
2013-11-12 11:13           ` Karl Beldan
2013-11-12 11:13             ` Karl Beldan
2013-11-12 13:09             ` Hannes Frederic Sowa
2013-11-12 11:53       ` Theodore Ts'o
2013-11-12 12:04         ` Johannes Berg
2013-11-12 13:16         ` Hannes Frederic Sowa
2013-11-12 13:16           ` Hannes Frederic Sowa
2013-11-12 13:46           ` [PATCH] random: seed random_int_secret at least poorly at core_initcall time Hannes Frederic Sowa
2013-11-12 13:46             ` Hannes Frederic Sowa
2013-11-14  2:54             ` Theodore Ts'o
2013-11-14  2:54               ` Theodore Ts'o
2013-11-14  4:18               ` Hannes Frederic Sowa
2013-11-14  5:05                 ` Hannes Frederic Sowa
2013-11-14  5:05                   ` Hannes Frederic Sowa
2013-11-15 18:42                 ` Kees Cook
2013-11-16  7:40                   ` Hannes Frederic Sowa
2013-11-16  7:40                     ` Hannes Frederic Sowa
2013-11-15 18:33               ` Kees Cook
2013-11-15 18:33                 ` Kees Cook
2013-11-15 18:45                 ` Dave Jones
2013-11-15 18:45                   ` Dave Jones
2013-11-15 19:07                   ` Kees Cook
2013-11-15 21:05                 ` Theodore Ts'o
2013-11-15 21:05                   ` Theodore Ts'o
2013-11-11 11:20 ` [PATCH net-next 4/6] random32: move rnd_state to linux/random.h Daniel Borkmann
2013-11-11 11:20 ` [PATCH net-next 5/6] random32: upgrade taus88 generator to taus113 from errata paper Daniel Borkmann
2013-11-11 11:20 ` [PATCH net-next 6/6] random32: add test cases for taus113 implementation Daniel Borkmann
2013-11-11 19:33 ` [PATCH net-next 0/6] prandom fixes/improvements David Miller
2013-11-11 19:44   ` Hannes Frederic Sowa
2013-11-11 20:00     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1384160397.git.dborkman@redhat.com \
    --to=dborkman@redhat.com \
    --cc=davem@davemloft.net \
    --cc=fweimer@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.