From: Lv Zheng <zetalog@gmail.com>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>
Cc: Lv Zheng <zetalog@gmail.com>, Lv Zheng <lv.zheng@intel.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: [PATCH 0/4] ACPI: Cleanup header inclusions.
Date: Sat, 23 Nov 2013 07:26:31 +0800 [thread overview]
Message-ID: <cover.1385094640.git.lv.zheng@intel.com> (raw)
From: Lv Zheng <lv.zheng@intel.com>
ACPICA header files are lacking in stub protections. This makes all ACPICA
header files could only be included for CONFIG_ACPI=y environment. This
infects new ACPI prototypes, if such prototypes referenced ACPICA defined
types, they must be incldued only in the CONFIG_ACPI=y environment. The
<acpi/acpi_bus.h> and <acpi/acpi_drivers.h> are the monstrosity infants
born under this background, directly including them in the CONFIG_ACPI=n
environment is not safe. The infection spreads to whole kernel source tree
that we can see "#ifdef CONFIG_ACPI" here and there.
This patchset tries to enforces <linux/acpi.h> inclusions instead of
<acpi/acpi.h>, <acpi/acpi_bus.h> and <acpi/acpi_drivers.h> inclusions.
Lv Zheng (4):
ACPICA: Linux: Cleanup wrong ACPICA inclusions.
ACPI: Cleanup <acpi/acpi_bus.h> and <acpi/acpi_drivers.h> inclusions.
ACPICA: Cleanup <acpi/acpi.h> inclusions.
ACPI: Add support to force header inclusion rules for <linux/acpi.h>.
arch/ia64/hp/common/aml_nfw.c | 3 +--
arch/x86/kernel/apic/apic_flat_64.c | 4 +---
arch/x86/kernel/apic/io_apic.c | 3 ---
arch/x86/pci/mmconfig_32.c | 1 -
arch/x86/platform/olpc/olpc-xo15-sci.c | 3 +--
drivers/acpi/ac.c | 3 +--
drivers/acpi/acpi_extlog.c | 1 -
drivers/acpi/acpi_pad.c | 3 +--
drivers/acpi/acpica/Makefile | 2 +-
drivers/acpi/apei/einj.c | 1 -
drivers/acpi/battery.c | 3 +--
drivers/acpi/blacklist.c | 1 -
drivers/acpi/bus.c | 2 --
drivers/acpi/button.c | 3 +--
drivers/acpi/custom_method.c | 2 +-
drivers/acpi/debugfs.c | 2 +-
drivers/acpi/dock.c | 2 --
drivers/acpi/ec.c | 3 +--
drivers/acpi/event.c | 2 +-
drivers/acpi/fan.c | 3 +--
drivers/acpi/hed.c | 2 --
drivers/acpi/numa.c | 1 -
drivers/acpi/nvs.c | 1 -
drivers/acpi/osl.c | 2 --
drivers/acpi/pci_irq.c | 2 --
drivers/acpi/pci_link.c | 3 +--
drivers/acpi/pci_root.c | 2 --
drivers/acpi/power.c | 3 +--
drivers/acpi/proc.c | 3 +--
drivers/acpi/processor_core.c | 2 +-
drivers/acpi/processor_idle.c | 1 -
drivers/acpi/processor_perflib.c | 3 +--
drivers/acpi/processor_thermal.c | 3 +--
drivers/acpi/processor_throttling.c | 3 +--
drivers/acpi/sbshc.c | 3 +--
drivers/acpi/scan.c | 1 -
drivers/acpi/sleep.c | 2 --
drivers/acpi/sysfs.c | 2 +-
drivers/acpi/thermal.c | 3 +--
drivers/acpi/utils.c | 2 --
drivers/acpi/video.c | 3 +--
drivers/acpi/wakeup.c | 1 -
drivers/ata/libata-acpi.c | 1 -
drivers/ata/pata_acpi.c | 2 +-
drivers/char/hpet.c | 1 -
drivers/char/tpm/tpm_acpi.c | 2 +-
drivers/char/tpm/tpm_ppi.c | 1 -
drivers/gpu/drm/i915/intel_acpi.c | 1 -
drivers/gpu/drm/nouveau/nouveau_acpi.c | 3 ---
drivers/gpu/drm/radeon/radeon_acpi.c | 2 --
drivers/hv/vmbus_drv.c | 1 -
drivers/hwmon/acpi_power_meter.c | 3 +--
drivers/hwmon/asus_atk0110.c | 5 +----
drivers/ide/ide-acpi.c | 1 -
drivers/input/misc/atlas_btns.c | 2 +-
drivers/iommu/amd_iommu_init.c | 1 -
drivers/iommu/intel_irq_remapping.c | 2 +-
drivers/pci/hotplug/acpiphp_ibm.c | 1 -
drivers/pci/hotplug/pciehp.h | 2 --
drivers/pci/ioapic.c | 1 -
drivers/pci/pci-acpi.c | 2 --
drivers/pci/pci-label.c | 1 -
drivers/platform/x86/acer-wmi.c | 1 -
drivers/platform/x86/asus-laptop.c | 3 +--
drivers/platform/x86/asus-wmi.c | 3 +--
drivers/platform/x86/classmate-laptop.c | 2 +-
drivers/platform/x86/dell-wmi-aio.c | 1 -
drivers/platform/x86/dell-wmi.c | 1 -
drivers/platform/x86/eeepc-laptop.c | 3 +--
drivers/platform/x86/eeepc-wmi.c | 2 +-
drivers/platform/x86/hp_accel.c | 2 +-
drivers/platform/x86/ideapad-laptop.c | 3 +--
drivers/platform/x86/intel-rst.c | 2 +-
drivers/platform/x86/intel-smartconnect.c | 2 +-
drivers/platform/x86/intel_menlow.c | 3 +--
drivers/platform/x86/intel_oaktrail.c | 2 --
drivers/platform/x86/mxm-wmi.c | 3 +--
drivers/platform/x86/panasonic-laptop.c | 3 +--
drivers/platform/x86/pvpanic.c | 3 +--
drivers/platform/x86/samsung-q10.c | 2 +-
drivers/platform/x86/sony-laptop.c | 2 --
drivers/platform/x86/tc1100-wmi.c | 4 +---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
drivers/platform/x86/toshiba_acpi.c | 2 +-
drivers/platform/x86/toshiba_bluetooth.c | 3 +--
drivers/platform/x86/wmi.c | 2 --
drivers/platform/x86/xo15-ebook.c | 3 +--
drivers/pnp/pnpacpi/core.c | 1 -
drivers/pnp/pnpacpi/pnpacpi.h | 1 -
drivers/sfi/sfi_acpi.c | 2 +-
drivers/staging/quickstart/quickstart.c | 2 +-
drivers/usb/core/usb-acpi.c | 1 -
drivers/xen/xen-acpi-cpuhotplug.c | 2 --
drivers/xen/xen-acpi-memhotplug.c | 1 -
drivers/xen/xen-acpi-pad.c | 3 +--
drivers/xen/xen-acpi-processor.c | 3 +--
include/acpi/acpi_bus.h | 6 +++++-
include/acpi/acpi_drivers.h | 7 +++++--
include/acpi/platform/aclinux.h | 6 ++++++
include/linux/acpi_io.h | 2 +-
include/linux/ide.h | 3 ---
include/linux/iscsi_ibft.h | 2 +-
include/linux/pci_hotplug.h | 3 +--
include/linux/sfi_acpi.h | 2 +-
include/linux/tboot.h | 2 +-
tools/power/cpupower/debug/kernel/cpufreq-test_tsc.c | 3 +--
106 files changed, 75 insertions(+), 166 deletions(-)
--
1.7.10
WARNING: multiple messages have this Message-ID (diff)
From: Lv Zheng <zetalog@gmail.com>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>
Cc: Lv Zheng <zetalog@gmail.com>, Lv Zheng <lv.zheng@intel.com>,
<linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org
Subject: [PATCH 0/4] ACPI: Cleanup header inclusions.
Date: Sat, 23 Nov 2013 07:26:31 +0800 [thread overview]
Message-ID: <cover.1385094640.git.lv.zheng@intel.com> (raw)
From: Lv Zheng <lv.zheng@intel.com>
ACPICA header files are lacking in stub protections. This makes all ACPICA
header files could only be included for CONFIG_ACPI=y environment. This
infects new ACPI prototypes, if such prototypes referenced ACPICA defined
types, they must be incldued only in the CONFIG_ACPI=y environment. The
<acpi/acpi_bus.h> and <acpi/acpi_drivers.h> are the monstrosity infants
born under this background, directly including them in the CONFIG_ACPI=n
environment is not safe. The infection spreads to whole kernel source tree
that we can see "#ifdef CONFIG_ACPI" here and there.
This patchset tries to enforces <linux/acpi.h> inclusions instead of
<acpi/acpi.h>, <acpi/acpi_bus.h> and <acpi/acpi_drivers.h> inclusions.
Lv Zheng (4):
ACPICA: Linux: Cleanup wrong ACPICA inclusions.
ACPI: Cleanup <acpi/acpi_bus.h> and <acpi/acpi_drivers.h> inclusions.
ACPICA: Cleanup <acpi/acpi.h> inclusions.
ACPI: Add support to force header inclusion rules for <linux/acpi.h>.
arch/ia64/hp/common/aml_nfw.c | 3 +--
arch/x86/kernel/apic/apic_flat_64.c | 4 +---
arch/x86/kernel/apic/io_apic.c | 3 ---
arch/x86/pci/mmconfig_32.c | 1 -
arch/x86/platform/olpc/olpc-xo15-sci.c | 3 +--
drivers/acpi/ac.c | 3 +--
drivers/acpi/acpi_extlog.c | 1 -
drivers/acpi/acpi_pad.c | 3 +--
drivers/acpi/acpica/Makefile | 2 +-
drivers/acpi/apei/einj.c | 1 -
drivers/acpi/battery.c | 3 +--
drivers/acpi/blacklist.c | 1 -
drivers/acpi/bus.c | 2 --
drivers/acpi/button.c | 3 +--
drivers/acpi/custom_method.c | 2 +-
drivers/acpi/debugfs.c | 2 +-
drivers/acpi/dock.c | 2 --
drivers/acpi/ec.c | 3 +--
drivers/acpi/event.c | 2 +-
drivers/acpi/fan.c | 3 +--
drivers/acpi/hed.c | 2 --
drivers/acpi/numa.c | 1 -
drivers/acpi/nvs.c | 1 -
drivers/acpi/osl.c | 2 --
drivers/acpi/pci_irq.c | 2 --
drivers/acpi/pci_link.c | 3 +--
drivers/acpi/pci_root.c | 2 --
drivers/acpi/power.c | 3 +--
drivers/acpi/proc.c | 3 +--
drivers/acpi/processor_core.c | 2 +-
drivers/acpi/processor_idle.c | 1 -
drivers/acpi/processor_perflib.c | 3 +--
drivers/acpi/processor_thermal.c | 3 +--
drivers/acpi/processor_throttling.c | 3 +--
drivers/acpi/sbshc.c | 3 +--
drivers/acpi/scan.c | 1 -
drivers/acpi/sleep.c | 2 --
drivers/acpi/sysfs.c | 2 +-
drivers/acpi/thermal.c | 3 +--
drivers/acpi/utils.c | 2 --
drivers/acpi/video.c | 3 +--
drivers/acpi/wakeup.c | 1 -
drivers/ata/libata-acpi.c | 1 -
drivers/ata/pata_acpi.c | 2 +-
drivers/char/hpet.c | 1 -
drivers/char/tpm/tpm_acpi.c | 2 +-
drivers/char/tpm/tpm_ppi.c | 1 -
drivers/gpu/drm/i915/intel_acpi.c | 1 -
drivers/gpu/drm/nouveau/nouveau_acpi.c | 3 ---
drivers/gpu/drm/radeon/radeon_acpi.c | 2 --
drivers/hv/vmbus_drv.c | 1 -
drivers/hwmon/acpi_power_meter.c | 3 +--
drivers/hwmon/asus_atk0110.c | 5 +----
drivers/ide/ide-acpi.c | 1 -
drivers/input/misc/atlas_btns.c | 2 +-
drivers/iommu/amd_iommu_init.c | 1 -
drivers/iommu/intel_irq_remapping.c | 2 +-
drivers/pci/hotplug/acpiphp_ibm.c | 1 -
drivers/pci/hotplug/pciehp.h | 2 --
drivers/pci/ioapic.c | 1 -
drivers/pci/pci-acpi.c | 2 --
drivers/pci/pci-label.c | 1 -
drivers/platform/x86/acer-wmi.c | 1 -
drivers/platform/x86/asus-laptop.c | 3 +--
drivers/platform/x86/asus-wmi.c | 3 +--
drivers/platform/x86/classmate-laptop.c | 2 +-
drivers/platform/x86/dell-wmi-aio.c | 1 -
drivers/platform/x86/dell-wmi.c | 1 -
drivers/platform/x86/eeepc-laptop.c | 3 +--
drivers/platform/x86/eeepc-wmi.c | 2 +-
drivers/platform/x86/hp_accel.c | 2 +-
drivers/platform/x86/ideapad-laptop.c | 3 +--
drivers/platform/x86/intel-rst.c | 2 +-
drivers/platform/x86/intel-smartconnect.c | 2 +-
drivers/platform/x86/intel_menlow.c | 3 +--
drivers/platform/x86/intel_oaktrail.c | 2 --
drivers/platform/x86/mxm-wmi.c | 3 +--
drivers/platform/x86/panasonic-laptop.c | 3 +--
drivers/platform/x86/pvpanic.c | 3 +--
drivers/platform/x86/samsung-q10.c | 2 +-
drivers/platform/x86/sony-laptop.c | 2 --
drivers/platform/x86/tc1100-wmi.c | 4 +---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
drivers/platform/x86/toshiba_acpi.c | 2 +-
drivers/platform/x86/toshiba_bluetooth.c | 3 +--
drivers/platform/x86/wmi.c | 2 --
drivers/platform/x86/xo15-ebook.c | 3 +--
drivers/pnp/pnpacpi/core.c | 1 -
drivers/pnp/pnpacpi/pnpacpi.h | 1 -
drivers/sfi/sfi_acpi.c | 2 +-
drivers/staging/quickstart/quickstart.c | 2 +-
drivers/usb/core/usb-acpi.c | 1 -
drivers/xen/xen-acpi-cpuhotplug.c | 2 --
drivers/xen/xen-acpi-memhotplug.c | 1 -
drivers/xen/xen-acpi-pad.c | 3 +--
drivers/xen/xen-acpi-processor.c | 3 +--
include/acpi/acpi_bus.h | 6 +++++-
include/acpi/acpi_drivers.h | 7 +++++--
include/acpi/platform/aclinux.h | 6 ++++++
include/linux/acpi_io.h | 2 +-
include/linux/ide.h | 3 ---
include/linux/iscsi_ibft.h | 2 +-
include/linux/pci_hotplug.h | 3 +--
include/linux/sfi_acpi.h | 2 +-
include/linux/tboot.h | 2 +-
tools/power/cpupower/debug/kernel/cpufreq-test_tsc.c | 3 +--
106 files changed, 75 insertions(+), 166 deletions(-)
--
1.7.10
next reply other threads:[~2013-11-22 23:27 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 23:26 Lv Zheng [this message]
2013-11-22 23:26 ` [PATCH 0/4] ACPI: Cleanup header inclusions Lv Zheng
2013-11-22 23:27 ` [PATCH 1/4] ACPICA: Linux: Cleanup wrong ACPICA inclusions Lv Zheng
2013-11-22 23:27 ` Lv Zheng
2013-11-25 23:54 ` Rafael J. Wysocki
2013-11-22 23:29 ` [PATCH 2/4] ACPI: Cleanup <acpi/acpi_bus.h> and <acpi/acpi_drivers.h> inclusions Lv Zheng
2013-11-22 23:29 ` Lv Zheng
2013-11-26 0:06 ` Rafael J. Wysocki
2013-11-26 0:29 ` Zheng, Lv
2013-11-26 0:29 ` Zheng, Lv
2013-11-22 23:32 ` [PATCH 3/4] ACPICA: Cleanup <acpi/acpi.h> inclusions Lv Zheng
2013-11-22 23:32 ` Lv Zheng
2013-11-22 23:37 ` [PATCH 4/4] ACPI: Add support to force header inclusion rules for <linux/acpi.h> Lv Zheng
2013-11-22 23:37 ` Lv Zheng
2013-11-26 0:09 ` [UPDATE PATCH " Rafael J. Wysocki
2013-11-26 0:32 ` Zheng, Lv
2013-11-26 0:32 ` Zheng, Lv
2013-11-26 5:21 ` [PATCH v2] ACPI: Cleanup <acpi/acpi.h>, <acpi/acpi_bus.h> and <acpi/acpi_drivers.h> inclusions Lv Zheng
2013-11-26 20:29 ` Rafael J. Wysocki
2013-11-26 20:27 ` Matthew Garrett
2013-11-26 20:29 ` Konrad Rzeszutek Wilk
2013-11-27 0:29 ` Rafael J. Wysocki
2013-11-28 1:12 ` Zheng, Lv
2013-11-28 1:12 ` Zheng, Lv
2013-11-28 2:34 ` Zheng, Lv
2013-11-26 20:54 ` Greg Kroah-Hartman
2013-11-28 0:54 ` Zheng, Lv
2013-11-28 0:54 ` Zheng, Lv
2013-11-28 14:18 ` Rafael J. Wysocki
2013-12-03 23:57 ` Rafael J. Wysocki
2013-12-04 3:31 ` Zheng, Lv
2013-12-04 3:31 ` Zheng, Lv
2013-11-26 21:07 ` Bjorn Helgaas
2013-12-04 0:41 ` [UPDTE PATCH 0/3] ACPI: Cleanup direct ACPICA inclusions Lv Zheng
2013-12-04 0:41 ` Lv Zheng
2013-12-04 0:38 ` [PATCH 1/3] ACPI/i915: Fix wrong <acpi/acpi.h> inclusion in i915 opregion module Lv Zheng
2013-12-04 0:38 ` Lv Zheng
2013-12-04 8:16 ` [Intel-gfx] " Daniel Vetter
2013-12-05 13:04 ` Jani Nikula
2013-12-05 13:04 ` [Intel-gfx] " Jani Nikula
2013-12-04 0:38 ` [PATCH 2/3] ACPI/SFI: Fix wrong <acpi/acpi.h> inclusion in SFI/ACPI wrapper - acpi_disabled linkage Lv Zheng
2013-12-04 0:38 ` Lv Zheng
2013-12-04 0:38 ` [RFC PATCH 3/3] ACPI/IBFT: Fix wrong <acpi/acpi.h> inclusion in iSCSI boot firmware module Lv Zheng
2013-12-04 0:38 ` Lv Zheng
2013-12-05 14:25 ` [PATCH v2] ACPI/i915: Fix wrong <acpi/acpi.h> inclusion in i915 opregion module Lv Zheng
2013-12-05 14:25 ` Lv Zheng
2013-12-06 8:51 ` [PATCH v3 0/6] ACPI: Cleanup header inclusions Lv Zheng
2013-12-06 8:51 ` Lv Zheng
2013-12-06 8:51 ` [PATCH v3 1/6] ACPI: Clean up incorrect inclusions of ACPICA headers Lv Zheng
2013-12-06 8:51 ` Lv Zheng
2013-12-06 8:51 ` [PATCH v3 2/6] ACPI: Clean up inclusions of ACPI header files Lv Zheng
2013-12-06 8:51 ` Lv Zheng
2013-12-06 14:31 ` Konrad Rzeszutek Wilk
2013-12-06 8:51 ` [PATCH v3 3/6] SFI: Fix warnings reported by W=1 builds Lv Zheng
2013-12-06 8:51 ` Lv Zheng
2013-12-06 8:52 ` [PATCH v3 4/6] ACPI/i915: Fix wrong <acpi/acpi.h> inclusion in i915 opregion module Lv Zheng
2013-12-06 8:52 ` Lv Zheng
2013-12-06 8:52 ` [PATCH v3 5/6] ACPI/SFI: Fix wrong <acpi/acpi.h> inclusion in SFI/ACPI wrapper - acpi_disabled linkage Lv Zheng
2013-12-06 8:52 ` Lv Zheng
2013-12-06 14:53 ` Zheng, Lv
2013-12-09 23:15 ` Bjorn Helgaas
2013-12-12 1:38 ` Rafael J. Wysocki
2013-12-06 8:52 ` [PATCH v3 6/6] ACPI/IBFT: Fix wrong <acpi/acpi.h> inclusion in iSCSI boot firmware module Lv Zheng
2013-12-06 8:52 ` Lv Zheng
2013-12-06 15:01 ` Zheng, Lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1385094640.git.lv.zheng@intel.com \
--to=zetalog@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.