From: Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
To: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
Subject: [PATCH v2 for v3.13 0/8] create_flow/destroy_flow fixes for v3.13
Date: Mon, 2 Dec 2013 12:12:42 +0100 [thread overview]
Message-ID: <cover.1385981934.git.ydroneaud@opteya.com> (raw)
Hi,
Please find the second revision of a patchset against create_flow/destroy_flow
and associated extended command scheme.
These are fixes that must be applied before making the new uverbs
widely available.
The first two patches address a warning reported by sparse.
The next patch handle an uncommon type of extended command.
Three patches ensure that commands will be extensible:
- One patch add a missing check of comp_mask;
- Two patches add checks on reserved fields.
The next patch fix an error path which was not setting the error code.
The last patch ensure the response buffer of an extended command
is a valid memory region for userspace. Doing the check earlier,
on the *full* response buffer, might be safer.
Please review and apply for v3.13.
Changes from patchset v1 [1]:
- add patch to verify early response buffer using access_ok(),
just like vfs_read().
Regards.
[1] [PATCH for v3.13 0/7] create_flow/destroy_flow fixes for v3.13
http://marc.info/?i=cover.1385501822.git.ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org
Yann Droneaud (8):
IB/core: const'ify inbuf in struct ib_udata
IB/uverbs: remove implicit cast in INIT_UDATA()
IB/uverbs: set outbuf to NULL when no core response space is provided
IB/uverbs: check reserved field in extended command header
IB/uverbs: check comp_mask in destroy_flow
IB/uverbs: check reserved fields in create_flow
IB/uverbs: set error code when fail to consume all flow_spec items
IB/uverbs: check access to userspace response buffer in extended
command
drivers/infiniband/core/uverbs.h | 12 ++++++------
drivers/infiniband/core/uverbs_cmd.c | 31 +++++++++++++++++++++----------
drivers/infiniband/core/uverbs_main.c | 21 ++++++++++++++++-----
include/rdma/ib_verbs.h | 2 +-
4 files changed, 44 insertions(+), 22 deletions(-)
--
1.8.4.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2013-12-02 11:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 11:12 Yann Droneaud [this message]
[not found] ` <cover.1385981934.git.ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
2013-12-02 11:12 ` [PATCH v2 for v3.13 1/8] IB/core: const'ify inbuf in struct ib_udata Yann Droneaud
2013-12-02 11:12 ` [PATCH v2 for v3.13 2/8] IB/uverbs: remove implicit cast in INIT_UDATA() Yann Droneaud
2013-12-02 11:12 ` [PATCH v2 for v3.13 3/8] IB/uverbs: set outbuf to NULL when no core response space is provided Yann Droneaud
2013-12-02 11:12 ` [PATCH v2 for v3.13 4/8] IB/uverbs: check reserved field in extended command header Yann Droneaud
2013-12-02 11:12 ` [PATCH v2 for v3.13 5/8] IB/uverbs: check comp_mask in destroy_flow Yann Droneaud
2013-12-02 11:12 ` [PATCH v2 for v3.13 6/8] IB/uverbs: check reserved fields in create_flow Yann Droneaud
2013-12-02 11:12 ` [PATCH v2 for v3.13 7/8] IB/uverbs: set error code when fail to consume all flow_spec items Yann Droneaud
2013-12-02 11:12 ` [PATCH v2 for v3.13 8/8] IB/uverbs: check access to userspace response buffer in extended command Yann Droneaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1385981934.git.ydroneaud@opteya.com \
--to=ydroneaud-rly5vtjfyj3qt0dzr+alfa@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.