All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timo Mueller <mail@timomueller.eu>
To: linux-bluetooth@vger.kernel.org
Cc: Timo Mueller <timo.mueller@bmw-carit.de>
Subject: [RFCv4 0/5] SSP MITM protection
Date: Thu, 19 Dec 2013 14:08:13 +0100	[thread overview]
Message-ID: <cover.1387450435.git.timo.mueller@bmw-carit.de> (raw)

From: Timo Mueller <timo.mueller@bmw-carit.de>

Hi,

this is a rebased version of the rfc v3. I've successfully tested
these changes in the last couple of months at the UPF #46 in Vienna,
with the CE4A golden device and the bluetooth PTS (where applicable).

At the UPF I've tested remotely initiated pairing with different io
capabilities, as well locally initiated pairing. Regardless of the
bonding mode, the protocol chosen in ssp has been consistent when
being responder and also when being initiator. Pairing tests have been
successful in all 22 test sessions.

The configuration I used for testing was as follows:
bluez: 5.9-154-gf7773c7
kernel: v3.12-rc3-65-gf927318
with the remaining patches from [RFC BlueZ v3 0/8] SSP MITM protection

I used the same configuration to test the patches with the CE4A golden
device. Pairing here has been working as expected with all
combinations of io capabilities, bonding mode and intiator role.

Lastly I've successfully ran the applicable GAP tests with the
bluetooth PTS on this rebased version and the current head of
bluez. Unfortunately the interesting bonding test cases are not yet
implemented with the test suite. So I could only make sure general
functionality is preserved.

from the original cover letter:
The way the kernel handles MITM Protection during pairing is
inconsistent: General Bonding and Dedicated Bonding are not treated
equally.
<snip>
Therefore, the safest choice is to always request MITM Protection,
also for General Bonding [1]. The proposal here is to do this for both
incoming (patch 6/8) and outgoing (patch 7/8) procedures, as it was
previously done for Dedicated Bonding. This "conservative" approach is
smart enough to fall back to not using MITM Protection if the IO
capabilities don't allow it (this policy already existed before for
Dedicated Bonding, see patch 5/8).
<snip>

Best regards
Timo

Mikel Astiz (3):
  Bluetooth: Refactor hci_get_auth_req()
  Bluetooth: Refactor code for outgoing dedicated bonding
  Bluetooth: Request MITM Protection when initiator

Timo Mueller (2):
  Bluetooth: Use MITM Protection when IO caps allow it
  Bluetooth: Add management command to relax MITM Protection

 include/net/bluetooth/hci.h  |  3 ++-
 include/net/bluetooth/mgmt.h |  3 +++
 net/bluetooth/hci_event.c    | 57 ++++++++++++++++++++++++++++----------------
 net/bluetooth/mgmt.c         | 50 ++++++++++++++++++++++++++++++++++----
 4 files changed, 87 insertions(+), 26 deletions(-)

-- 
1.8.3.1


             reply	other threads:[~2013-12-19 13:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19 13:08 Timo Mueller [this message]
2013-12-19 13:08 ` [RFCv4 1/5] Bluetooth: Refactor hci_get_auth_req() Timo Mueller
2013-12-19 13:08 ` [RFCv4 2/5] Bluetooth: Refactor code for outgoing dedicated bonding Timo Mueller
2013-12-19 13:08 ` [RFCv4 3/5] Bluetooth: Use MITM Protection when IO caps allow it Timo Mueller
2013-12-19 13:08 ` [RFCv4 4/5] Bluetooth: Request MITM Protection when initiator Timo Mueller
2013-12-19 13:08 ` [RFCv4 5/5] Bluetooth: Add management command to relax MITM Protection Timo Mueller
2014-01-09  8:51 ` [RFCv4 0/5] SSP MITM protection Timo Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1387450435.git.timo.mueller@bmw-carit.de \
    --to=mail@timomueller.eu \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=timo.mueller@bmw-carit.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.