From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/7] net: Convert aligned memcpy to ether_addr_copy
Date: Mon, 20 Jan 2014 09:52:13 -0800 [thread overview]
Message-ID: <cover.1390239869.git.joe@perches.com> (raw)
In-Reply-To: <20140115.164540.450877805879786067.davem@davemloft.net>
On Wed, 2014-01-15 at 16:45 -0800, David Miller wrote:
From: Joe Perches <joe@perches.com>
> Date: Wed, 15 Jan 2014 16:07:58 -0800
>
> > If you want the ones for net-next net/ now (but not
> > for batman-adv, that maybe could use a new function like
> > ether_addr_copy_unaligned) here's a changestat.
> >
> > Otherwise, I'll wait for the next cycle.
>
> This looks fine, why don't you toss it my way over the weekend as I
> still have some backlog to process at the moment?
I didn't get that done this weekend, so next cycle
for most of net/.
I don't want to introduce any breakage this late and
there are possible unaligned memcpy(foo, bar, ETH_ALEN)
where one or both of foo/bar are stack pointers where
the alignment is hard to verify.
There are also statics declared without __aligned(2)
that will need updating.
Maybe ether_addr_copy_unaligned should be added too.
Here are the ones I could easily verify...
No worries if it's this cycle or next.
Joe Perches (7):
8021q: Use ether_addr_copy
appletalk: Use ether_addr_copy
atm: Use ether_addr_copy
caif_usb: Use ether_addr_copy
netpoll: Use ether_addr_copy
pktgen: Use ether_addr_copy
dsa: Use ether_addr_copy
net/8021q/vlan.c | 2 +-
net/8021q/vlan_dev.c | 6 +++---
net/appletalk/aarp.c | 12 ++++++------
net/atm/lec.c | 9 +++++----
net/atm/mpc.c | 2 +-
net/caif/caif_usb.c | 4 ++--
net/core/netpoll.c | 4 ++--
net/core/pktgen.c | 8 ++++----
net/dsa/slave.c | 2 +-
9 files changed, 25 insertions(+), 24 deletions(-)
--
1.8.1.2.459.gbcd45b4.dirty
next prev parent reply other threads:[~2014-01-20 17:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 23:18 [RFC PATCH net-next] etherdevice: Use ether_addr_copy to copy an Ethernet address Joe Perches
2014-01-15 23:39 ` David Miller
2014-01-16 0:07 ` Joe Perches
2014-01-16 0:07 ` Joe Perches
2014-01-16 0:45 ` David Miller
2014-01-16 0:45 ` David Miller
2014-01-20 17:52 ` Joe Perches [this message]
2014-01-20 17:52 ` [PATCH 1/7] 8021q: Use ether_addr_copy Joe Perches
2014-01-22 2:13 ` David Miller
2014-01-20 17:52 ` [PATCH 2/7] appletalk: " Joe Perches
2014-01-20 17:52 ` [PATCH 3/7] atm: " Joe Perches
2014-01-20 17:52 ` [PATCH 4/7] caif_usb: " Joe Perches
2014-01-20 17:52 ` [PATCH 5/7] netpoll: " Joe Perches
2014-01-20 17:52 ` [PATCH 6/7] pktgen: " Joe Perches
2014-01-20 17:52 ` [PATCH 7/7] dsa: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1390239869.git.joe@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.