From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6S95-0001Im-IK for qemu-devel@nongnu.org; Thu, 23 Jan 2014 16:49:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6S8z-0001iq-J7 for qemu-devel@nongnu.org; Thu, 23 Jan 2014 16:49:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6S8z-0001iM-BW for qemu-devel@nongnu.org; Thu, 23 Jan 2014 16:49:01 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0NLn0pw003424 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 23 Jan 2014 16:49:00 -0500 From: Jeff Cody Date: Thu, 23 Jan 2014 16:48:54 -0500 Message-Id: Subject: [Qemu-devel] [PATCH v3 0/3] block: commits of snapshots larger than backing files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@redhat.com Changes, v2->v3: Patch 1/3: None Patch 2/3: Set errp for both bdrv_getlength() failure cases (Fam) Remove "." from error message (Eric Blake) Patch 3/3: Removed spurious double space (Eric Blake) Changes, v1->v2: Patch 1/3: Added error check for bdrv_getlength() return (Stefan) Patch 2/3: Restore flags in commit_active_start() on failures after the bdrv_reopen() (Fam) Patch 3/3: New patch, adds documentation clarification for the behavior of both offline commit, and live block commit, as it pertains to image truncation. (Stefan) If a snapshot is larger than a backing file, then the offline bdrv_commit and the live active layer commit will fail with an i/o error (usually). A live commit of a non-active layer will complete successfully, as it runs bdrv_truncate() on the backing image to resize it to the larger size. For both bdrv_commit() and commit_active_start(), this series will resize the underlying base image if needed. If the resize fails, an error will be returned. Jeff Cody (3): block: resize backing file image during offline commit, if necessary block: resize backing image during active layer commit, if needed block: update block commit documentation regarding image truncation block.c | 23 ++++++++++++++++++++--- block/mirror.c | 41 +++++++++++++++++++++++++++++++++++++++++ hmp-commands.hx | 5 +++++ qapi-schema.json | 7 +++++++ qemu-img.texi | 7 ++++++- qmp-commands.hx | 39 +++++++++++++++++++++++++++++++++++++++ 6 files changed, 118 insertions(+), 4 deletions(-) -- 1.8.3.1