All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@akamai.com>
To: bp@alien8.de
Cc: tony.luck@intel.com, hpa@zytor.com, mingo@kernel.org,
	dougthompson@xmission.com, m.chehab@samsung.com,
	mitake@dcl.info.waseda.ac.jp, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] Add new ie31200_edac driver
Date: Fri,  4 Apr 2014 21:13:45 +0000 (GMT)	[thread overview]
Message-ID: <cover.1396645124.git.jbaron@akamai.com> (raw)

Hi,

Add support for memory errors for the Intel E3-1200 processors.

While testing the driver, I found that doing a readq() on the
memory mapped memory controller hub registers caused a hard lockup
on my x86_64 system. It turns out that a read across a DW boundary
is a no no here.

"
Software must not access B0/D0/F0 32-bit memory-mapped registers with
requests that cross a DW boundary.
"

(http://www.intel.com/content/www/us/en/processors/xeon/xeon-e3-1200-family-vol-2-datasheet.html p. 16)

Thus, I've added a generic lo_hi_[read|write]_q API, to deal with
this issue.

I think longer term the right thing is maybe to simply add these
definitions to include/asm-generic/io.h, as I didn't see any
in tree users of 'io-64-nonatomic-hi-lo.h', and simply remove
io-64-nonatomic-hi-lo.h and io-64-nonatomic-lo-hi.h. But I didn't want to
tie that cleanup to this edac driver submission.

Thanks,

-Jason


Jason Baron (3):
  readq/writeq: Add explicit lo_hi_[read|write]_q and hi_lo_[read|write]_q
  x38_edac: make use of lo_hi_readq()
  ie31200_edac: Add driver

 drivers/edac/Kconfig                        |   7 +
 drivers/edac/Makefile                       |   1 +
 drivers/edac/ie31200_edac.c                 | 540 ++++++++++++++++++++++++++++
 drivers/edac/x38_edac.c                     |  15 +-
 include/asm-generic/io-64-nonatomic-hi-lo.h |  14 +-
 include/asm-generic/io-64-nonatomic-lo-hi.h |  14 +-
 6 files changed, 572 insertions(+), 19 deletions(-)
 create mode 100644 drivers/edac/ie31200_edac.c

-- 
1.8.2.rc2


             reply	other threads:[~2014-04-04 21:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-04 21:13 Jason Baron [this message]
2014-04-04 21:13 ` [PATCH 1/3] readq/writeq: Add explicit lo_hi_[read|write]_q and hi_lo_[read|write]_q Jason Baron
2014-04-04 21:13 ` [PATCH 2/3] x38_edac: make use of lo_hi_readq() Jason Baron
2014-04-04 21:14 ` [PATCH 3/3] ie31200_edac: Add driver Jason Baron
2014-04-08  9:09   ` Borislav Petkov
2014-04-08 22:16     ` Jason Baron
2014-04-08 22:34       ` Luck, Tony
2014-04-09  3:03         ` Jason Baron
2014-04-09 11:11           ` Borislav Petkov
2014-04-09 11:13       ` Borislav Petkov
2014-04-09 11:35   ` Borislav Petkov
2014-04-09 13:34     ` Aristeu Rozanski
2014-04-09 17:17       ` Luck, Tony
2014-04-09 17:36         ` Borislav Petkov
2014-04-09 18:57           ` Jason Baron
2014-04-09 19:14             ` Borislav Petkov
2014-04-09 19:53               ` Jason Baron
2014-04-09 20:16                 ` Borislav Petkov
2014-04-09 21:33                   ` Luck, Tony
2014-04-09 22:15                     ` Jason Baron
2014-04-09 22:44                       ` Luck, Tony
2014-04-10  1:52                         ` Jason Baron
2014-04-10  9:30                         ` Borislav Petkov
2014-06-11 21:54                     ` Jason Baron
2014-04-09 18:42     ` Jason Baron
2014-04-07 20:00 ` [PATCH 0/3] Add new ie31200_edac driver Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1396645124.git.jbaron@akamai.com \
    --to=jbaron@akamai.com \
    --cc=bp@alien8.de \
    --cc=dougthompson@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=mingo@kernel.org \
    --cc=mitake@dcl.info.waseda.ac.jp \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.