From: Peter Seebach <peter.seebach@windriver.com>
To: bitbake-devel <bitbake-devel@lists.openembedded.org>
Subject: [PATCH 0/1] utils.py: default mode on mkdirhier
Date: Mon, 19 May 2014 16:52:43 -0500 [thread overview]
Message-ID: <cover.1400270358.git.peter.seebach@windriver.com> (raw)
It turns out that bb.utils.mkdirhier() is occasionally called with
widely varying umasks, including but not limited to 022, 002, or 0.
This can result in unpredictable directory permissions, depending on
which context you were in when a directory got made, and it can
also result in mode 777 directories, which are Probably Bad. (The
most obvious case involves packages-split being created by
accident with umask 0 in populate_packages, shortly before a later
attempt to create it with umask 022.)
I've done test builds with this modification, and nothing seemed to
go wrong. I used an optional argument, rather than just hard-coding
the 0755, because if I use an optional argument it will always
be right, but if I don't I'm sure it will turn out to break something.
The following changes since commit d150226d11d5f041f78c8c3ce4abc5465dbc81d8:
fetch2/perforce: Ensure command has a default (2014-05-11 15:25:47 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib seebs/mkdirhier
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/mkdirhier
Peter Seebach (1):
utils.py: default mode for mkdirhier
lib/bb/utils.py | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
next reply other threads:[~2014-05-19 21:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 21:52 Peter Seebach [this message]
2014-05-19 21:52 ` [PATCH 1/1] utils.py: default mode for mkdirhier Peter Seebach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1400270358.git.peter.seebach@windriver.com \
--to=peter.seebach@windriver.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.