From: Jeremiah Mahler <jmmahler@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: git@vger.kernel.org, Jeremiah Mahler <jmmahler@gmail.com>
Subject: [PATCH v2 0/2] replace signal() with sigaction()
Date: Fri, 30 May 2014 13:58:15 -0700 [thread overview]
Message-ID: <cover.1401482787.git.jmmahler@gmail.com> (raw)
This is the second revision to the patch set to replace signal(2) with
sigaction(2) [1].
As Johannes pointed out [2], replacing signal with sigaction would break
MinGW compatibility. The first patch in this series addresses this
problem by expanding the faux sigaction function in compat/mingw.c to
support signals other than just SIGALRM. Details are in the patch
description.
The second patch is a proof of concept. It converts signal to sigaction
in a case where signal SIGCHILD was used. Previously this would have
failed with MinGW since the faux sigaction function only supported
SIGALRM. Now it works as expected.
I have tested these changes under Linux and under Windows 7 using Msysgit.
[1]: http://marc.info/?l=git&m=140125769223552&w=2
[2]: http://marc.info/?l=git&m=140126288325213&w=2
Jeremiah Mahler (2):
compat/mingw.c: expand MinGW support for sigaction
connect.c: replace signal() with sigaction()
compat/mingw.c | 9 +++++----
connect.c | 5 ++++-
2 files changed, 9 insertions(+), 5 deletions(-)
--
2.0.0.2.g1d11d5d
next reply other threads:[~2014-05-30 20:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 20:58 Jeremiah Mahler [this message]
2014-05-30 20:58 ` [PATCH v2 1/2] compat/mingw.c: expand MinGW support for sigaction Jeremiah Mahler
2014-05-30 20:58 ` [PATCH v2 2/2] connect.c: replace signal() with sigaction() Jeremiah Mahler
2014-05-30 21:48 ` Andreas Schwab
2014-05-31 10:39 ` Chris Packham
2014-05-31 14:45 ` Jeremiah Mahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1401482787.git.jmmahler@gmail.com \
--to=jmmahler@gmail.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.