All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, shobhit.kumar@linux.intel.com,
	gaurav.k.singh@intel.com
Cc: jani.nikula@intel.com
Subject: [PATCH 0/3] BYT DSI Dual Link Support
Date: Fri, 14 Nov 2014 16:54:20 +0200	[thread overview]
Message-ID: <cover.1415976065.git.jani.nikula@intel.com> (raw)
In-Reply-To: <5464C5E9.7090401@linux.intel.com>

Hi Shobhit and Gaurav -

I've been pondering this whole MIPI DSI pipes vs. ports thing and
discussing with Ville and others. Rather than try and fail in explaining
the ideas, here are some concrete patches to describe what I'd like to
be done first.

The most important thing is that we don't confuse the pipes and
ports. Getting confused was easy with the pipe B mapping to port C, and
the register defines being very confused/confusing about it. These
patches attempt to fix that. Before adding dual link support, there's a
simple function mapping the pipe to port.

Next up is expanding that to handle multiple ports driven from one
pipe. That's handled by adding intel_dsi->ports bitmap that has the bit
set for each port that is to be driven. I've added the bitmap and some
helpers to iterate over the configured ports, but there's no actual
support for doing the configuration. I'm hoping you could take over from
here. There's a sample patch about the usage.

I'm sorry it's taken me so long to reply. With the new stuff coming in,
I really think it's important to get the foundation right
first. Especially because I'm to blame for getting some of the port/pipe
stuff confused in the first place...

BR,
Jani.



Jani Nikula (3):
  drm/i915/dsi: clean up MIPI DSI pipe vs. port usage
  drm/i915/dsi: add ports to intel_dsi to describe the ports being
    driven
  drm/i915/dsi: an example how to handle dual link for each port

 drivers/gpu/drm/i915/i915_reg.h      | 303 ++++++++++++++++++-----------------
 drivers/gpu/drm/i915/intel_dsi.c     | 151 ++++++++---------
 drivers/gpu/drm/i915/intel_dsi.h     |  19 +++
 drivers/gpu/drm/i915/intel_dsi_cmd.c |  76 ++++-----
 4 files changed, 290 insertions(+), 259 deletions(-)

-- 
2.1.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2014-11-14 14:54 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29  8:42 [PATCH 00/11] BYT DSI Dual Link Support Gaurav K Singh
2014-10-29  8:42 ` [PATCH 01/11] drm/i915: New functions added for enabling & disabling MIPI Port Ctrl reg Gaurav K Singh
2014-10-29  8:42 ` [PATCH 02/11] drm/i915: MIPI Sequence to be sent to the DSI Controller based on the port no from VBT Gaurav K Singh
2014-10-29  8:42 ` [PATCH 03/11] drm/i915: Cleanup in i915_reg.h for all MIPI regs Gaurav K Singh
2014-10-29  8:42 ` [PATCH 04/11] drm/i915: Cleanup patch for " Gaurav K Singh
2014-10-29  8:42 ` [PATCH 05/11] drm/i915: Add support for port enable/disable for dual link configuration Gaurav K Singh
2014-10-29  8:42 ` [PATCH 06/11] drm/i915: Pixel Clock changes for DSI dual link Gaurav K Singh
2014-10-29  8:42 ` [PATCH 07/11] drm/i915: Dual link needs Shutdown and Turn on packet for both ports Gaurav K Singh
2014-10-29  8:42 ` [PATCH 08/11] drm/i915: Enable DSI PLL for both DSI0 and DSI1 in case of dual link Gaurav K Singh
2014-10-29  8:42 ` [PATCH 09/11] drm/i915: MIPI Timings related changes for " Gaurav K Singh
2014-10-29  8:42 ` [PATCH 10/11] drm/i915: Update the DSI disable path to support dual link panel disabling Gaurav K Singh
2014-10-29  8:42 ` [PATCH 11/11] drm/i915: Update the DSI enable path to support dual link panel enabling Gaurav K Singh
2014-11-13 14:53 ` [PATCH 00/11] BYT DSI Dual Link Support Kumar, Shobhit
2014-11-14 14:54   ` Jani Nikula [this message]
2014-11-14 14:54     ` [PATCH 1/3] drm/i915/dsi: clean up MIPI DSI pipe vs. port usage Jani Nikula
2014-11-26 17:20       ` Singh, Gaurav K
2014-11-26 18:08         ` Daniel Vetter
2014-11-26 18:43           ` Singh, Gaurav K
2014-11-27  7:28       ` Singh, Gaurav K
2014-11-14 14:54     ` [PATCH 2/3] drm/i915/dsi: add ports to intel_dsi to describe the ports being driven Jani Nikula
2014-11-27  7:24       ` Singh, Gaurav K
2014-11-14 14:54     ` [PATCH 3/3] drm/i915/dsi: an example how to handle dual link for each port Jani Nikula
2014-11-15  1:15       ` [PATCH 3/3] drm/i915/dsi: an example how to handle dual shuang.he
2014-11-24  8:10     ` [PATCH 0/3] BYT DSI Dual Link Support Singh, Gaurav K
2014-11-24  9:01       ` Jani Nikula
2014-11-26 17:21         ` Singh, Gaurav K
2014-11-27  7:50         ` Singh, Gaurav K
2014-11-28 17:19           ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1415976065.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=gaurav.k.singh@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=shobhit.kumar@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.