From: Peter Seebach <peter.seebach@windriver.com>
To: OE-core <openembedded-core@lists.openembedded.org>
Subject: [PATCH 0/1] package.bbclass: Do fixups even when FILES_foo is set
Date: Mon, 8 Dec 2014 17:53:58 -0600 [thread overview]
Message-ID: <cover.1418082021.git.peter.seebach@windriver.com> (raw)
There's some fixups for things like adding extra_depends to RDEPENDS
which ended up in the "if not oldfiles" clause of a test against
a setting for FILES_foo, but which I think should probably be done
either way. The one that specifically affected us is that in some
code for using a prebuilt toolchain, we set FILES_packagename from
a manifest, which resulted in FILES_glibc-gconv-localename being
set, which meant that RDEPENDS wasn't getting "glibc-gconv" appended
for any of the glibc-gconv-localename packages, because the processing
of extra_depends was conditional.
Two of these variables (summary and description) looked like things
where the assumption might have been that you'd define SUMMARY_foo
and DESCRIPTION_foo if you were defining FILES_foo, so I've also
made those settings conditional on there not being an existing setting.
I ran builds of core-image-sato with and without this change, and looked
at build history. 26 packages changed, but 23 were changes to PKGSIZE
and nothing else.
The other three changes:
gst-plugins-good-gconfelements-dev has changes to RRECCOMMENDS, adding
gst-plugins-good-dev, and gst-plugins-good-gconfelements has changes to
RDEPENDS, adding gst-plugins-good. Both of these look reasonable to me.
perl-module-cpan has a change to RDEPENDS, adding perl. I think that's
also reasonable.
So I don't think this breaks anything.
The following changes since commit 219e793907406eabf632e784e3a11ab9acb77cfb:
qemu/libc-package: Fix qemu option handling (2014-12-05 17:59:42 +0000)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib seebs/package_files
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/package_files
Peter Seebach (1):
package.bbclass: do variable fixups even when FILES was set
meta/classes/package.bbclass | 18 ++++++++++--------
1 files changed, 10 insertions(+), 8 deletions(-)
next reply other threads:[~2014-12-08 23:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 23:53 Peter Seebach [this message]
2014-12-08 23:53 ` [PATCH 1/1] package.bbclass: do variable fixups even when FILES was set Peter Seebach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1418082021.git.peter.seebach@windriver.com \
--to=peter.seebach@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.